Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CA+G9fYuifLivwhCh33kedtpU=6zUpTQ_uSkESyzdRKYp8WbTFQ@mail.gmail.com>
 <ZJLzsWsIPD57pDgc@FVFF77S0Q05N> <ZJQXdFxoBNUdutYx@FVFF77S0Q05N>
In-Reply-To: <ZJQXdFxoBNUdutYx@FVFF77S0Q05N>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Thu, 22 Jun 2023 18:05:40 +0530
Message-ID: <CA+G9fYtAutjL3KpZsQyJuk4WqS=Ydi2iyVb5jdecZ-SOuzKCmA@mail.gmail.com>
Subject: Re: next: Rpi4: Unexpected kernel BRK exception at EL1
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     Linux ARM <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        linux-rpi-kernel@lists.infradead.org,
        Netdev <netdev@vger.kernel.org>, lkft-triage@lists.linaro.org,
        Arnd Bergmann <arnd@arndb.de>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Puranjay Mohan <puranjay12@gmail.com>,
        Song Liu <song@kernel.org>, Alexei Starovoitov <ast@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Mark,

On Thu, 22 Jun 2023 at 15:12, Mark Rutland <mark.rutland@arm.com> wrote:
>
> On Wed, Jun 21, 2023 at 01:57:21PM +0100, Mark Rutland wrote:
> > On Wed, Jun 21, 2023 at 06:06:51PM +0530, Naresh Kamboju wrote:
> > > Following boot warnings and crashes noticed on arm64 Rpi4 device running
> > > Linux next-20230621 kernel.
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > boot log:
> > >
> > > [   22.331748] Kernel text patching generated an invalid instruction
> > > at 0xffff8000835d6580!
> > > [   22.340579] Unexpected kernel BRK exception at EL1
> > > [   22.346141] Internal error: BRK handler: 00000000f2000100 [#1] PREEMPT SMP
> >
> > This indicates execution of AARCH64_BREAK_FAULT.
> >
> > That could be from dodgy arguments to aarch64_insn_gen_*(), or elsewhere, and
> > given this is in the networking code I suspect this'll be related to BPF.
> >
> > Looking at next-20230621 I see commit:
> >
> >   49703aa2adfaff28 ("bpf, arm64: use bpf_jit_binary_pack_alloc")
> >
> > ... which changed the way BPF allocates memory, and has code that pads memory
> > with a bunch of AARCH64_BREAK_FAULT, so it looks like that *might* be related.
>
> For the benefit of those just looknig at this thread, there has been some
> discussion in the original thread for this commit. Summary and links below.
>
> We identified a potential issue with missing cache maintenance:
>
>   https://lore.kernel.org/linux-arm-kernel/ZJMXqTffB22LSOkd@FVFF77S0Q05N/
>
> Puranjay verified that was causing the problem seen here:
>
>   https://lore.kernel.org/linux-arm-kernel/CANk7y0h5ucxmMz4K8sGx7qogFyx6PRxYxmFtwTRO7=0Y=B4ugw@mail.gmail.com/
>
> Alexei has dropped this commit for now:
>
>   https://lore.kernel.org/linux-arm-kernel/CAADnVQJqDOMABEx8JuU6r_Dehyf=SkDfRNChx1oNfqPoo7pSrw@mail.gmail.com/

Thanks for the detailed information.
I am happy to test any proposed fix patches.


>
> Thanks,
> Mark.

- Naresh