Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20230615160806.94000-1-marcel@holtmann.org>
References: <20230615160806.94000-1-marcel@holtmann.org>
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     dhowells@redhat.com, linux-cachefs@redhat.com,
        linux-kernel@vger.kernel.org, arnd@arndb.de,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH] cachefiles: allocate static minor for /dev/cachefiles
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1886145.1687441374.1@warthog.procyon.org.uk>
Date:   Thu, 22 Jun 2023 14:42:54 +0100
Message-ID: <1886146.1687441374@warthog.procyon.org.uk>
Precedence: bulk

Marcel Holtmann <marcel@holtmann.org> wrote:

> The cachefiles misc character device uses MISC_DYNAMIC_MINOR and thus
> doesn't support module auto-loading. Assign a static minor number for it
> and provide appropriate module aliases for it. This is enough for kmod to
> create the /dev/cachefiles device node on startup and facility module
> auto-loading.

Why?  The systemd unit file for it just modprobe's the module first.  It's a
specialist device file only for use by the appropriate daemon.

David