Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp10948174rwd; Thu, 22 Jun 2023 07:00:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Czn5SBHp6Rk9kASwNXAYtVYtPIiHjp/1WpOWqB+KoG3RTYMnXAdL9GUetmGqmC/MyleQx X-Received: by 2002:a05:6a20:9192:b0:10f:be0:4dce with SMTP id v18-20020a056a20919200b0010f0be04dcemr21917721pzd.8.1687442449405; Thu, 22 Jun 2023 07:00:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687442449; cv=none; d=google.com; s=arc-20160816; b=AFj6oT0a5673e2CuKvQC8wErP96V74XWkJqFMAzMkDXAvY5drUJh+PI4abwDEEfhdN R6jNlKHZz7tfsM4b5zayBzjo2IMc8rxtXq6eNLEvNtAno6kz51xq+RcrwtIha1LC7/0Z eReEWqsuqZjCPI7jtg6AbbQ5XaFelVf2NWY/OOrl0t9pHChdTjlgZJEAd464wIApYO0G KKKhx2RAgOWFvk7bwbiQHDQTUabtJAAHI4NPyBIGJ0+sM5M0JYNO0j+4jPrEbLp9cbkb Vzr3RFqU/YeE8hNnwP7s0E7SXnJ9QFh2T8R9EOvCjjby+J2C4ZjoBcmbUSLWsgIvgPlz JNnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8T3/cuVNEiFbgv70qW1rnElJ4hAinl+t/6U+Zh4RCas=; b=o57N7azYWpscLV5mFLOXGrHS+w1SH2RpVDxQ2qn1qIELReR9fEWLkO9MtRXcszXeCp sh27k0k6vLvSsBvebh3H3THtBUhfyWFkIZXkeE5y+TMsTff8TWCQPT8DuafFaoEwSKWd k7DMR4HtE3rA3Uz/qn5ZMV2Bg4emIli5+Sgep/BHIjKQCTCuikBq2a2TNAGMRoLomyIK S/2j10UUkZDTxvWrwgAZ7WX4xR4QEpgryynGyfzq3dpezwsup4nAaG992Tww9S58SiW7 bgldM/cgAiaIhceVOiAU87jMhdI/Rs37Xc2sQ3WxrZ5zzfZo2HiQ5Ujax0lhZiSnZE1N 2UNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eU8ALiWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y17-20020aa79e11000000b006642e5dd553si136622pfq.221.2023.06.22.07.00.34; Thu, 22 Jun 2023 07:00:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eU8ALiWH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbjFVN4W (ORCPT + 99 others); Thu, 22 Jun 2023 09:56:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231134AbjFVN4T (ORCPT ); Thu, 22 Jun 2023 09:56:19 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0EA4199B; Thu, 22 Jun 2023 06:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687442178; x=1718978178; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=iwvWjTXOATc+/cgzxfPqHvCL/9Mmo5XEzzxlVw4W7tY=; b=eU8ALiWHbzzojEw+on4Ad/Lr4y8ajV/2sC1uEFU7T2oVMRhVps303hho fyu34K+3FR6Le7rWLCnS5v9wItVFZb+WrofOl1RxZQKJhEPeG9sezM5cu ACcvCPlMYQjTuLi9sEEuCjSwXnCg5r+tEya32nlmcPbiJK/CIx82SKe/a StLBxVc/U6zHftiW2Z7c6PQxn16Gr//PN/4EeTQrjlo1S454JwMVHJvca T3iAzRK54hMHAiaI/kj8OEtx4JfUiTUKk7QwCueMHhEDm5DGQ1aKsw8rv OaBOrPN0qdolbOdwp3j+IQzcsrXY2cpo/d/z3bEOCt8EfxUEOaMoiysds w==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="390236806" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="390236806" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 06:56:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="804794065" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="804794065" Received: from akivisil-mobl.ger.corp.intel.com (HELO intel.com) ([10.251.215.96]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2023 06:56:09 -0700 Date: Thu, 22 Jun 2023 15:56:06 +0200 From: Andi Shyti To: Thomas =?iso-8859-15?Q?Hellstr=F6m?= Cc: intel-xe@lists.freedesktop.org, Christian =?iso-8859-15?Q?K=F6nig?= , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian =?iso-8859-15?Q?K=F6nig?= Subject: Re: [Intel-gfx] [PATCH 4/4] drm/ttm: Don't leak a resource on swapout move error Message-ID: References: <20230622101412.78426-1-thomas.hellstrom@linux.intel.com> <20230622101412.78426-5-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230622101412.78426-5-thomas.hellstrom@linux.intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Thu, Jun 22, 2023 at 12:14:12PM +0200, Thomas Hellstr?m wrote: > If moving the bo to system for swapout failed, we were leaking > a resource. Fix. > > Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") > Cc: Christian K?nig > Cc: "Christian K?nig" > Cc: dri-devel@lists.freedesktop.org > Cc: # v5.14+ > Signed-off-by: Thomas Hellstr?m Reviewed-by: Andi Shyti Andi