Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb2ca23e-dbde-7e1c-8e3c-3163292fd824@amd.com>
Date:   Thu, 22 Jun 2023 09:02:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v6 03/27] cxl: Updates for CXL Test to work with RCH
To:     Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc:     alison.schofield@intel.com, vishal.l.verma@intel.com,
        ira.weiny@intel.com, bwidawsk@kernel.org, dan.j.williams@intel.com,
        dave.jiang@intel.com, linux-cxl@vger.kernel.org, rrichter@amd.com,
        linux-kernel@vger.kernel.org, bhelgaas@google.com
References: <20230622035126.4130151-1-terry.bowman@amd.com>
 <20230622035126.4130151-4-terry.bowman@amd.com>
 <20230622105326.00006302@Huawei.com>
Content-Language: en-US
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <20230622105326.00006302@Huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z3pFb2xhekY0YkZUS3NJSDRvNmtkOWpCNkxnWFRYQ2VtZzB5VnlBeGxGaTh1?=
 =?utf-8?B?UExyTG8wZzExRGdZaWJIcUxzQWRuK2h0OU0waVdkYkpQS21PZ01rZ0Jrb2c2?=
 =?utf-8?B?YTNYQXp2Yk9NbXFQWkN3ZW81WG1sQlVoaHM3ZHpiK2NHNmZRYzNtc0tFejJr?=
 =?utf-8?B?TVBXNTJFcVExckxzN2p1MGdiTTU3S0dWTUV2TkhNd2d3ell1ZHowd3dPUnZt?=
 =?utf-8?B?NDBRWnVBa0k0OFdTRCtwNGlpdi9MdnA0ZlBvTzQ3Y2Nub3hiRUJHSUY1Tzlq?=
 =?utf-8?B?MGRIUjI2cWdxSy9uWkxQT0MwdWhzSk5nTzBMLzFIcUNwOGFOYnhNdEJYTWdQ?=
 =?utf-8?B?VXA0WG1qMkNEZVpCQzhzQWZVbnhTYzYyYWNoTHlkVmk1Sml2N0FwdHc4M29v?=
 =?utf-8?B?cStJNko4dmNLOXV2SGREZEdyMkFYVzZ1MnB6blozd3o1WFFtTHc2TXE5L0k1?=
 =?utf-8?B?clFZdXRnVFJ3SjJwL1p0b2l6Q1F3M0h3UDdQUmF1Ym01MzJlTGZMREJJa2tN?=
 =?utf-8?B?SktKSUVlc2oyOTJrMjNsR2xlSGJMbUdOMllWdGxUeVVpNHpDYjJId2hPZkIw?=
 =?utf-8?B?aENLK01DOFd6ZlROVzA1cStkc3lDUXJrbW1za0dIeVIrRzhKM1dBUkdUZnhw?=
 =?utf-8?B?UTZOWG80bWJQTDBkNDcyV2RjZmZYZm5mZFlVSVhObWF0aXVRRG1nZFVzZytL?=
 =?utf-8?B?WTZTbllkc2dFejR1NjBMNXRXVTR4VitDOVlSMmsvbElzQ0t3OGVtU3YrZGho?=
 =?utf-8?B?dnVEMStyeDdxdUUxWkhLNldOM01OUndRbWNyc2F5WFBZblE0d2dFTG9RbUJv?=
 =?utf-8?B?aE5NSHIvUkVQZm5Vd2U0QlY3ZC9CSEwwSGxyWGhGK2t1S0lmS0x4QTlzUzZY?=
 =?utf-8?B?UmE0UEo4anl2K2FrbWRhRkthbjFoV05yZG01YldsVWNMU05UcUVYZ2FDVi94?=
 =?utf-8?B?bm8veGVZV3psZ0QzSEFyWithWGtYbWZJNnF3ZGppcm1SM05VTlphaVR1cndR?=
 =?utf-8?B?SnZKaGtMVlNCTGF5UVlzRWFPTy96SXhycjhKZXBXcUc1MnEzbC8zdFg3Mkho?=
 =?utf-8?B?ejhNVXNKcVZVWHVFQVluT1JERUdJOFQ2OStZOXVUZnphWFZZV0E5aUc2c0tp?=
 =?utf-8?B?QnNtdlo4bUVVTlZpNC9RbExySTFGRUJWYmp3ZzMvdTVDUVRVMDVmYmRFNzg3?=
 =?utf-8?B?YnZCRjdDN0VLN2Vkd1ZWOTJNVTh6ajVJWGx6czV3emhFMG1YYytDbWFHSHli?=
 =?utf-8?B?bE5OUTZPbUh0UEdXQ1hkeEtkamRwb3NFcU0zcFBUdjJ0T3JMUk9MS0RKTTBZ?=
 =?utf-8?B?RHN0SHc2aDFCL1ZOQnBQUFEza001TGFBRU44cUpvd1REY1VlUDI1S1Jka1lt?=
 =?utf-8?B?V0dIMFk2aUpIalFVN1ZUSXc0YnZHL0pVQWtaY1NQS3pZcUdiSlhvUUVSR244?=
 =?utf-8?B?UldFK0huZkFtelpvY25DdmFnL0Iwd3dhSG1CeVlLTnlQS3dXUURQYkd3d1d2?=
 =?utf-8?B?U1kwVGM5VnVGdmM2OUpyaFlFdGl5UFNxaGx4czR3Y3hkbE1lVWFCZFU0MFBn?=
 =?utf-8?B?WTh1bUx1TGNSVEI0WnN5UnNXUnVKQjE4Szk3dkdGbnprTzRVeG1KWEd3Y3Qw?=
 =?utf-8?B?YjRJdkE1Tjc0bU1XV29TTWtOVVR1c3BDTUY4MytYa2tpZm1mT2dvTlU2RmNH?=
 =?utf-8?B?SWJDU1RZYWNxcW1CZjE3R2xLYVQwR3FpYU9RQUxkS1ZTcWJVZGxqanhFdkRu?=
 =?utf-8?B?MDArOXV5aUd3ckVwSk5hdWh1U3NHUUhsODR0cHJoK2sxVHVrb1Q4SjkxMktj?=
 =?utf-8?B?K3VpN3ZFQ0ZKY28xbnVIK0lVZ1J3RkdsLyt3S2lGM3ZGTDdjVU1ua0J4eThh?=
 =?utf-8?B?ZER0MndxQzNmWmw0UUx1dTdRRDlTMFR1alczVG9veFR1TnFIaktvR2d1aDMz?=
 =?utf-8?B?ekNwSmJEMFEyQUUzODJmK052VmFpbDNlSHZ3Zk9oeFkwUENWeEx1ajBOVmNh?=
 =?utf-8?B?Wkd3VkRoZmF6Szhoa0d4Y2RwZjQ2OURKclJuNTZ2bWp2QzN2QUZGWUxnVi8z?=
 =?utf-8?B?M2puMHVhMHQ1cGxYQTc0KzNETmZrRFJkclpzV2UwK09BWWdNMTBMWS9pZGVW?=
 =?utf-8?B?YmhZRURDNWlKMU14TlZMeTg2dGFzc3lraWpjMkgxR3A0ZlBvUDNPT2x0S0dV?=
 =?utf-8?Q?yvxzrFoMf1ggxDY6RHicEQTV4lL799g/MjH5jIKHsTUp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b2748f8-f295-4351-f7ce-08db73295f29
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6380.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 14:02:53.5563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aiGl4ThIyHvciZ5+uVjqW+QILc3eMfC4Fu3KgJ3pOqqg5tJL15naG9mpHXm/6lubILwnAn8pKdNEv/lwq60lvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7721
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jonathan,

On 6/22/23 04:53, Jonathan Cameron wrote:
> On Wed, 21 Jun 2023 22:51:02 -0500
> Terry Bowman <terry.bowman@amd.com> wrote:
> 
>> From: Dan Williams <dan.j.williams@intel.com>
>>
>> CXL test needs to be updated to work with latest RCH changes.
>> Add CXL test support for devm_cxl_add_rch_dport and
>> cxl_rcd_component_reg_phys functions.
>>
>> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
>> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
>> Signed-off-by: Robert Richter <rrichter@amd.com>
> 
> This chain is getting confusing.
> 
> Why a SoB from Robert on this one?
> As Terry sent the series I'd expect Terry to be last unless there
> was some codevelopment involved in which case that should be indicated
> in the tags.
> 

This was a mistake on my part. I'll remove Robert. Thanks for pointing out.

Regards,
Terry

> For weird corner cases it's worth adding some comments on why a SoB chain
> is non obvious.
> 
> I'm far from an expert on cxl-test so I'll leave reviewing this in
> depth to others.  FWIW looks fine to me.
> 
> Jonathan
>