Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp11033575rwd; Thu, 22 Jun 2023 07:59:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ViW/IHFuQ3KjJSR9I3MvrjN0dvxl91EVgp6nQCBuH0dgQwfkDYPzJlfCmrHxUmDlBGC/X X-Received: by 2002:a05:6a20:3d11:b0:121:d478:4d91 with SMTP id y17-20020a056a203d1100b00121d4784d91mr10081734pzi.16.1687445979052; Thu, 22 Jun 2023 07:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687445979; cv=none; d=google.com; s=arc-20160816; b=wE77r+dBcynKclGx9sdh9InvUJsZJTPpkb2awFoQv3mtnNADTm/CzyZU1H2WfDHXi2 TCwawE8ESJItnKR0WcVP/LvCTx9XYZOm+cw2uvosR6UWelJX8PrMBNtjJmjx2d37A57e Gnh20Vzef2z+X6jUlXzWiVCw7MGfm6JzRhu6dVWjK/0bRg+zrwYqA46kjX9pfr0jQP2z sdpzJ6Qt9ap7XQHcmKW45ZzTBSb60uUAIKKTl6Y+CiIGl6ZdFOThUtnWxKh8e3bTcTzC 2ca+43KuI/MI3rXZ3dPtyw+X6fPh51WrqrwtGf9vzu/DO6FgHK8EAtMpJE783tz8NeFv DGwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1UK5fJ9lghN0a3tJZNkGRLRGkG7YCjSPkVdW4p+p350=; b=tdq0/w1GVHOD6EvmkuCqAgbzYbW7pI6Y2bmFnY8UVaN2ssgH9U3+QvGc8Xf8DgRmOr nFLJtdA4PWey6XOFbp2ezWsB2vU5HmNJwp+brNR+m/CDsWT4aQHAGIOnYNp9bsdknPwb WSioO69sc4x6hJj/19BjFLsRavpnJ77cchCusZwtpQVhOuQKEdWCzysr0JWGaYirE2uS Ytz0CKi4f3OwhgezIITMEi/BGGvp/gqsyC3rmOzBP1hzjOUXGxF0Hzfw8VTGbN/Be2qV N/BfaxfdJriWvYlq07Fps+glkVxOd7ZvyUwfkGaVUEajVGM5UNMwaSsaQzvC//LtPcYA WEoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a126-20020a624d84000000b0063bba133a6esi6446183pfb.4.2023.06.22.07.59.26; Thu, 22 Jun 2023 07:59:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231959AbjFVOoX (ORCPT + 99 others); Thu, 22 Jun 2023 10:44:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231949AbjFVOoF (ORCPT ); Thu, 22 Jun 2023 10:44:05 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52F2426A5; Thu, 22 Jun 2023 07:43:38 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1qCLWv-0000VU-6n; Thu, 22 Jun 2023 16:43:25 +0200 Date: Thu, 22 Jun 2023 16:43:25 +0200 From: Florian Westphal To: Gavrilov Ilia Cc: Simon Horman , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Patrick McHardy , "netfilter-devel@vger.kernel.org" , "coreteam@netfilter.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return value. Message-ID: <20230622144325.GC29784@breakpoint.cc> References: <20230426150414.2768070-1-Ilia.Gavrilov@infotecs.ru> <6f2b5c12-82b5-2496-23a3-05ab22d7b14b@infotecs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f2b5c12-82b5-2496-23a3-05ab22d7b14b@infotecs.ru> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gavrilov Ilia wrote: > Hi, Simon. > I'm sorry to bother you. > Will this patch be applied or rejected? Please resend, keeping Simons Reviewd-by tag. Please update the commit message as per your and Simons conversation, i.e. that the return value is now a tristate, 0 for not found and -1 for 'malformed' and that you checked all callers that they will do the right thing.