Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 17:56:15 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: ipaq-micro: Use %*ph for printing hexdump of
 a small buffer
Message-ID: <ZJRhD8QoqMtg8reI@smile.fi.intel.com>
References: <20230612212007.3621-1-andriy.shevchenko@linux.intel.com>
 <20230621171040.GK10378@google.com>
 <ZJQ/L7+hpCLi7grQ@smile.fi.intel.com>
 <20230622140058.GW10378@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622140058.GW10378@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jun 22, 2023 at 03:00:58PM +0100, Lee Jones wrote:
> On Thu, 22 Jun 2023, Andy Shevchenko wrote:
> > On Wed, Jun 21, 2023 at 06:10:40PM +0100, Lee Jones wrote:
> > > On Tue, 13 Jun 2023, Andy Shevchenko wrote:
> > > > The kernel already has a helper to print a hexdump of a small
> > > > buffer via pointer extension. Use that instead of open coded
> > > > variant.
> > > 
> > > That's not all you're doing is it?
> > > 
> > > Nice try.  2 patches please.
> > 
> > I'm not sure it's possible to split to two clean patches that don't overlap
> > each other like by 70%. Can you elaborate a bit more on your vision on this?
> 
> What does the 'break' have to do with changing print format?

Ah, indeed! Thank you for spotting this. Yes, 2 patches.

-- 
With Best Regards,
Andy Shevchenko