Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5fe03be6-8c95-0bfa-687d-68e7ddffd97c@siemens.com>
Date:   Thu, 22 Jun 2023 16:58:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v6 4/4] efivarfs: automatically update super block flag
Content-Language: en-US
To:     Masahisa Kojima <masahisa.kojima@linaro.org>,
        Ard Biesheuvel <ardb@kernel.org>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Sumit Garg <sumit.garg@linaro.org>,
        linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org
Cc:     Ilias Apalodimas <ilias.apalodimas@linaro.org>,
        Johan Hovold <johan+linaro@kernel.org>,
        Jeremy Kerr <jk@ozlabs.org>, linux-efi@vger.kernel.org
References: <20230622085112.1521-1-masahisa.kojima@linaro.org>
 <20230622085112.1521-5-masahisa.kojima@linaro.org>
From:   Jan Kiszka <jan.kiszka@siemens.com>
In-Reply-To: <20230622085112.1521-5-masahisa.kojima@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnNRdCsyQ2FqSW1LcjRuL1RUNWhhekc1S3NVc1Y2STRCWXBJRDV0YURQQ2Jt?=
 =?utf-8?B?MUVpWXBYRVcxSG9hM2gvOUhrdWVmOXhkcjNNK2RSWVlaR0g4bXZ3b2lEd0FL?=
 =?utf-8?B?YlE3ZnlqdmVpeEtqMmxsa3BNWVd1aHEwaTJtdm50TzF0TnpZR3NsendNb25a?=
 =?utf-8?B?UzBjTCtpUXJ0cG03S0V4VURyOHVhZDU5dXpuMkZTczdlQ2VaM0tPb1A0cGJW?=
 =?utf-8?B?ZWxmczRXNkMrTkhZV0kvajVJNVlDQ1M3ZWpqMDMzM05zVjhxSjI3NXhBanNx?=
 =?utf-8?B?TDJXUE1xYVpKdUhzZkdQdG9Kb1pHRDQxcElsY1UxTWJOWUVURlBHNURNMExo?=
 =?utf-8?B?Wi9YMkZNU2U0ZWlidHFTZExaeStNTUQ0alRJZUlRd1U2NXd3NWxkRTNUME9G?=
 =?utf-8?B?YlhKc2RoVzRkUkoyL2pVdkFISWg2OFAyREx2bStIc0s0djZ5dm5BWW1nS0dt?=
 =?utf-8?B?alFwRlpUMFB1cVdma1g2ZW1VNzBLNTA5U0w0TjNrbEJObXpVMWxYbGRKaU9B?=
 =?utf-8?B?c0E1V2U0RXpQTmVHbVJzbC8rMnptdE94bkxUZERDbVhQRU5PWG9seTVROWZm?=
 =?utf-8?B?dllRbXVKczU5WkVSelF4OUhVSWh0cmFXWGxqdjh2MmRKeUJ2NS9nVHZYUFF0?=
 =?utf-8?B?TkRVOUI4ZmM5WFJ0bno1MGo2UXlHb1JWN0FGNjdFbVlXakhHVCtmR1RJbk9k?=
 =?utf-8?B?ZGttUGxlREg3cC9PM0ZPS2RwTEdvYUFjUVZDcjFtTFB2MlZIVEhNWHFBU0lY?=
 =?utf-8?B?MWtKNDNXeTFXZjhyRUFabC91UlFSazNGY1dJMm1wekhxWHNyMUxpNkF2MjR4?=
 =?utf-8?B?U3RqdjNWZXNIVGkwZ2o1OUlqcGlTaEJkTG9ZNU04Ris3TTBWTHBJOGpUNkI0?=
 =?utf-8?B?cUNraVdzQVhtL1lYOWNYSUxuaUU4dFRhOEJPbHdQb21EdEtXcVI4czZUcHdD?=
 =?utf-8?B?YzV6SmgrVTFGYkFwNCtlMlVCOGsrU01RdlNWa0FBMjBDL2VUc1M3OGxFNEg3?=
 =?utf-8?B?NCs4dS9VT1NmVDV6bjNTMWhiNFhPbVhHN1hOWWhQaGtEWlY0aUp0TmpNNE04?=
 =?utf-8?B?b1hOWjlVQnRCQXNnRXY3OE5ndFNPV0V0YmFOd1JEb0Q5ekdCb1E1ajBPNW90?=
 =?utf-8?B?VFdMZTVsRFlCYlc5dkFwRjdhVU5Gdy9WaXExYmszNTVLS0piSGFzOVRsaWts?=
 =?utf-8?B?ME1jZ2xGeG1tYXFmWFdCbnAvbUtKcUdIMzFKc3UxaUp3a05lSTRsbEFPamxV?=
 =?utf-8?B?ckpTN2xTb3FjN0pHS3luS01zcStJcXBIY2ROY0t0b3dqanVxWTRwbEt3bWNE?=
 =?utf-8?B?cnMvWjAvV3ZsTjFZUHdaRFJpNTZmVDdlNzlVU3M2dTBpbUQxWUhmWTFPYUd2?=
 =?utf-8?B?MlNQWGUvS0FMdEsxYnNlZDNNVFIyWTdTelJobXpTMHdYV3BiSXFqSlNtbHhB?=
 =?utf-8?B?V2ZibjBDRHZybGxBcThRR1UwWjFYZHlkRkNrZnAzQkZzbmdRcU5lQmdFUXJ2?=
 =?utf-8?B?cVp4ZldEa29vYzVPNHh2NjRkOTluNGlKQXdrSXp1S3lXcnEzdHFvRTNXTGNU?=
 =?utf-8?B?SWpvTkV2dWJHMWxVelVlNklDYmsyT01LZm5JR3o1TVh4UTlXd0xZazBka0ZF?=
 =?utf-8?B?R3JUOG5KUjVLUE1QYStZQS9rZUgrbmFiNktvSTVybHo0eDVaUVRxMC9OUmdS?=
 =?utf-8?B?QnV1NDdMY1Vrb3FQd0ZDOXUyQ3JPeGc3cm15YjJPWExnU1llYUdrbVUvT3Bw?=
 =?utf-8?B?dHdodks1YWRnSllKamx1SndNQkM4OGJla2gyOHpOZkJkMXNpV0JHMGd3QnM1?=
 =?utf-8?B?VS9LNnNkeWtZdWYzRE5odlFFdHpDM05YMVhwSGd5MTZRNVNmTHp0VkxRTlNw?=
 =?utf-8?B?VTVvTy8xSFk4ZnlYM1BmYWN5djdEc2Q2VTZzQXljRkx0Tk4wMUtYeDBVQklh?=
 =?utf-8?B?MXhnRmUyanNaWE1MemVEWVZLV1UrdFZNdW9VTzJHb1ZTSmJ3N0tjZ1Jxck56?=
 =?utf-8?B?OHo3aVR6bjdMVHZHNGN1K0ZRMzZGMnBpNnBkOGp4eG5YV1lRSHJHKzE1TmU5?=
 =?utf-8?B?bEpabGhFWUgyQ2hYQjV5V1NZdEwyUTFVbnNrL3YxbWlBdW5SMDRxd0tjUEZl?=
 =?utf-8?B?dUMvVERuYUExWnFYTEpxaGdpUmV3L2ZDaFRsaWlNcU9nckJHZDdyUVEwaDBa?=
 =?utf-8?B?MkE9PQ==?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2dc7df4-1bc1-4154-6095-08db73313221
X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 14:58:53.5621
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 15220h7ydC8ykgyoQ0yrS0Evt3htESwemTxdjpEpgE5X24QVrEYIPbcPMkKHEaKyeuW9mSAdiBqb9f2BqCxAPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6152
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 22.06.23 10:51, Masahisa Kojima wrote:
> efivar operation is updated when the tee_stmm_efi module is probed.
> tee_stmm_efi module supports SetVariable runtime service,
> but user needs to manually remount the efivarfs as RW to enable
> the write access if the previous efivar operation does not support
> SerVariable and efivarfs is mounted as read-only.
> 
> This commit notifies the update of efivar operation to
> efivarfs subsystem, then drops SB_RDONLY flag if the efivar
> operation supports SetVariable.

But it does not re-add it and prevents further requests to the TA (that
will only cause panics there) when the daemon terminates, does it?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux