Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33
Mime-Version: 1.0
Message-Id: <388c9fbb-2782-4990-b432-eeb999308869@app.fastmail.com>
In-Reply-To: <20230621223600.1348693-1-sohil.mehta@intel.com>
References: <e1a2665d-2e11-7722-a7ae-ef534829ed37@intel.com>
 <20230621223600.1348693-1-sohil.mehta@intel.com>
Date:   Thu, 22 Jun 2023 17:10:34 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Sohil Mehta" <sohil.mehta@intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
        Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] syscalls: Remove file path comments from headers
Content-Type: text/plain
Precedence: bulk

On Thu, Jun 22, 2023, at 00:36, Sohil Mehta wrote:
> Source file locations for syscall definitions can change over a period
> of time. File paths in comments get stale and are hard to maintain long
> term. Also, their usefulness is questionable since it would be easier to
> locate a syscall definition using the SYSCALL_DEFINEx() macro.
>
> Remove all source file path comments from the syscall headers. Also,
> equalize the uneven line spacing (some of which is introduced due to the
> deletions).
>
> Signed-off-by: Sohil Mehta <sohil.mehta@intel.com>
> ---
>  include/linux/compat.h                  |  82 ++------------
>  include/linux/syscalls.h                | 140 +++---------------------
>  include/uapi/asm-generic/unistd.h       | 129 +++++-----------------
>  kernel/sys_ni.c                         | 110 +------------------
>  tools/include/uapi/asm-generic/unistd.h | 129 +++++-----------------
>  5 files changed, 85 insertions(+), 505 deletions(-)

Applied to the asm-generic tree, thanks!

   Arnd