Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Yazen Ghannam <yazen.ghannam@amd.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: RE: [PATCH 1/2] x86/mce: Disable preemption for CPER decoding
Thread-Topic: [PATCH 1/2] x86/mce: Disable preemption for CPER decoding
Thread-Index: AQHZpQwiSV5YEcM40EuivrL9zu2Y2a+W8n2Q
Date:   Thu, 22 Jun 2023 15:35:27 +0000
Message-ID: <SJ1PR11MB6083664BCFC8047A5FE8F6A9FC22A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230622131841.3153672-1-yazen.ghannam@amd.com>
 <20230622131841.3153672-2-yazen.ghannam@amd.com>
In-Reply-To: <20230622131841.3153672-2-yazen.ghannam@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PtBsyWM7iRiVLu+zJ2zgPG6EFHjto6kbo+o9c/Fx1XR1JCJVIHmhQCbU/Yda?=
 =?us-ascii?Q?ZVHyPoEISmeQdUzWhoPKNqmaIJx1lVQ7PQ/oUDJW247KNTWaJ2TQmDgGmXXO?=
 =?us-ascii?Q?CFLKxuBGle1IgXSm849aDpWKMAV1UmNv/F3HIG22oAf+ShEeGK2eSeiOfdZW?=
 =?us-ascii?Q?uIKOv60IX8RUrG7+0xEVoaC5sVoD6wi//Vnp2WPHtNUnBf3mdVtsSlAUUtFD?=
 =?us-ascii?Q?4lWyMisYZchzCkYfQCt18VsX5OFNynjNTN4u9NTGE015K/ZQEUhbSY7kQSZh?=
 =?us-ascii?Q?I5oS52Ggi5GbbN+dqdJz2k7gQCMJmsW1fyeXhZ/9qSjwkrlD85iUiU44ML7x?=
 =?us-ascii?Q?fNe3bm8KSe0WbYVlhkW7H0crmwtVQ/THKAShd61C+IEA0NK04kaYTEVq56S0?=
 =?us-ascii?Q?OBMWLULZfDSe9VTXFjIxxXlfmv1hOZ979NBZy4Kz9FyRfg1r1MPYq0bt5Q2G?=
 =?us-ascii?Q?MVxnj+cvqf4Hp8F4/pXtyc8Bp9FSpvKVW2GiGHYqLglxmMzx6ALZtxXvMZTo?=
 =?us-ascii?Q?ZG8ut32UYtk22GAe+DBxItnfNEIPJhj+9FcWGO3mqPTB2GjVCZl7NlEUbsXA?=
 =?us-ascii?Q?DP/nWbtt2g7Crp6XrAZ1FAmLxgLgoj12483q9had+jmUrVv1Fk1FXuO6aH+Q?=
 =?us-ascii?Q?wMZKSO+PYLdQ+dFALoW5W3aejenX/6VYP9TAD+JPZZzpv28dgOv3aty8UwBi?=
 =?us-ascii?Q?3pdggppdOQHkEuAK8f3MTxXoOIwFbIIA2y2X2lToPDoxDIEVenSdOq9nOc6C?=
 =?us-ascii?Q?NRbQW6KxQi8ftEJURPDN2EaoTK/fNKc9BTX9DbZ7OsAsrGKsxmA5XatfcPTD?=
 =?us-ascii?Q?EkIRhgqebgdqWgd31JEj7juzdt5iUnOLF9/7PLm8y7IX7GuvOfYbjVEdiad9?=
 =?us-ascii?Q?GYHz49/FW4jiK5AsRV5CmYp51haCkadaO6UqdVmS4rX+TOuZ1dhxZIz3vHNh?=
 =?us-ascii?Q?TSuIPfA5fDK6StE8v0N8qxOyskDkziOJG0B7hWhE3fIGnjl+FG5wvQOKmi35?=
 =?us-ascii?Q?NAxv+EudBAlye7e6fOD87J+s0wDia+dYGpFolkW1QaFQ7wHhOBR5hTsWkgoH?=
 =?us-ascii?Q?S827G6IsqATRjj60lzjByA/zkTpHbTZDdKTp6dojalUKKvNBWeNHAfgJVBYw?=
 =?us-ascii?Q?lf0rRVHtXGIlwlAxZvU3LVR+lcOk+OT2TEx4JwgzzUIWWpqWxwtSkzjxSOwY?=
 =?us-ascii?Q?dlNR2cjsgS/gtLoC6nEZm3KzN0P8qR/JRVdeoZKLUAnRMQb/a3E8lrQGwkA1?=
 =?us-ascii?Q?YNPu8czkJomCgSVi3oHMYAjgoIKIFNjtrRsGJDRxqQDCUBLZ0NOjRxOk/50e?=
 =?us-ascii?Q?oyatIjj4OrL5sCOrB8TNwoxCQRjaGpEqKfgA1RLclNnbnpwbYpJBH8q59woB?=
 =?us-ascii?Q?qZnRpHNA73HglJuIhlZUE/EHTryLu82C+VlIjOL04W+E7iLljQ2SfoDridyP?=
 =?us-ascii?Q?jW3WgUFR3mRuL0miOh5BieBKnwOe3PhMDCYLIjCLrZM9EjZyC1f7eADRheTG?=
 =?us-ascii?Q?PJ3G8IvisVDiz+IX/tSMSdvfzSvo5jybV4Ffvj2kVbEUTBl8kM0S5XZh+sDf?=
 =?us-ascii?Q?BfpD6UTcdu/IMJ3yIcA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47a8831a-40e9-47d7-852e-08db73364e1a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2023 15:35:27.8374
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EXjwm9AKJ1k/VlW/FRE0HCkBs2l2cXR5E6s/WeARJMmYN/EIHKQvkhQOjR1fxyUJ6V4e6Z8UYEHtvS+xE+d6Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4819
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> All the above is done when the BERT is processed during late init. This
> can be scheduled on any CPU, and it may be preemptible.

> 2) mce_setup() will pull info from the executing CPU, so some info in
>   struct mce may be incorrect for the CPU with the error. For example,
>   in a dual-socket system, an error logged in socket 1 CPU but
>   processed by a socket 0 CPU will save the PPIN of the socket 0 CPU.

> Fix the first issue by locally disabling preemption before calling
> mce_setup().

It doesn't really fix the issue, it just makes the warnings go away.

The BERT record was created because some error crashed the
system. It's being parsed by a CPU that likely had nothing
to do with the actual error that occurred in the previous incarnation
of the OS.

If there is a CPER record in the BERT data that includes CPU
information, that would be the right thing to use. Alternatively
is there some invalid CPU value that could be loaded into the
"struct mce"?

-Tony