Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 17:35:12 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: broadcom: drop brcm_phy_setbits() and use
 phy_set_bits() instead
Message-ID: <ZJRqMLepCTPqvCD9@corigine.com>
References: <20230622123737.8649-1-giulio.benetti@benettiengineering.com>
 <12d3d3e7-da90-cc73-57e6-1aa7859dce90@benettiengineering.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12d3d3e7-da90-cc73-57e6-1aa7859dce90@benettiengineering.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fyEO1JU/VnsXfFiBlu5JPGNSRV6F+PDZS1qV349xu1ZgvGfKTXXwjRfCWt/3?=
 =?us-ascii?Q?AzG+ELkIE36OBviKprPQz5fvLwqJV+t5SFy1goVVTl+JZb5p3YfkTMvbuaRQ?=
 =?us-ascii?Q?QuZEYsLxWb+b6jgdfUD/I92Fk6vblZeRcSfslEuhTBfy0QApW3EPq0lANFw3?=
 =?us-ascii?Q?laMgZLwbAA/6NM+cLSPH0W9px9Udp2wNsoYbtEOUzKw5flFF7TxfzvHOpBZQ?=
 =?us-ascii?Q?SRd4GpCTGgJH/HTtJnsNNRy2CtOej/yaKF41d5jyIMUVHgy98Qx1RdP+Gpd/?=
 =?us-ascii?Q?Xc8MrRMJZNA5pXiV42t21o/HBpCJ0QnWmy0xrPqebieHNkuTD/o3UxyxUSXr?=
 =?us-ascii?Q?aEWwVpKiGQ8FwKvOBzkWvlMk6NN3t0Lc5/txEBEdQpEnNdBBfyAhmLJrpauc?=
 =?us-ascii?Q?DnYTpVWMnoV2aUajffWBb36Ze6q3BHl00NLRcz+mwET0oO+q/Fqx/Zy+2DrW?=
 =?us-ascii?Q?W5BIRfl1Q9bD5oYAZRQrF8JZEs7i2RcNNqRnsp3xHj8kZ3RVlJn1JGnhh7hq?=
 =?us-ascii?Q?2qAVn7DzMQEL7kkjZAQwNfxP8aBYs5uDIx1Qo2h7eocKHM4e2VtnB/VwpJHD?=
 =?us-ascii?Q?giG9/s3+9c1e1E8tfh27AtSfqXc1B8Kh1b7BCK2H81e5BW/b/6ZpAaNPb2GP?=
 =?us-ascii?Q?v5+a+HURe2tOxfqdbF5/LXYiPvOq1YSwIF/+ama4lJj+4zebRvBqXi9iZ+8j?=
 =?us-ascii?Q?b6nc8wWUiPAI6xCXSEyoombsjR+zaZKUdDgl8l+pPSIEJSdsoiV7r0TDyctj?=
 =?us-ascii?Q?lzCGZ3TymCf+dT0BViRdrU2gC0B/d+pQ6fCJhStDXLf4fKv6oOQox43yUI/L?=
 =?us-ascii?Q?Uj9eTH1CxfY5gMygBD7af464xxe0xzuIwqY98LqPaqvv/zTbaakZXKmVMiCj?=
 =?us-ascii?Q?djDmT9yb5jrBuWbjiXwp2wSvpo5h1kcdfsJgZRxCjhwwOx+zZ3Ua+UkHUsJf?=
 =?us-ascii?Q?8ZnCPxXSYXMQ4Dh4b4CVZtJ4Mq6WWOsKo1gJZiKjDAUlPl1O6axHXR9lO+LG?=
 =?us-ascii?Q?4R6aXFx7FwIzGMnSlBHG1pIgoE+54T+qjfISyyYdgYrk/0tyVd34/CILiADS?=
 =?us-ascii?Q?85R3oj8kvmTFgtIpvWXhn83yjUeceBK9GRzpXSfK28IhGOyZA5fW5xQvzSlh?=
 =?us-ascii?Q?/hWYYDhATCodtddmqrQ0rx6z63xwDtEJFjvYg0xm/oiPE8ngCWoiS96PoAbb?=
 =?us-ascii?Q?oDWd6i+d8GnLFVW6fCMwQlzrrzZYO5sGddVWMj9arBrWl/XDgbD01+WR4Kpy?=
 =?us-ascii?Q?zLqURQ+kGKqHPQ4EnMYahdsykzZLtvCHTxFrZC0dm49ryKruijUVT5p8q/HH?=
 =?us-ascii?Q?gmYDh9yn79IaEKot/ewY7nvyqKMUO8cQ1WML+CiizSXqGiGN1OjhzpMrnXvf?=
 =?us-ascii?Q?7JFazSMxO4WwQYh2bPUN2LOxqcGvJZTklAIEoPPtXBFbCjda1llJ7CZ7WglM?=
 =?us-ascii?Q?3cphkQWNsID0jdIByWJgWXXThoCKoZVz/0BOjmC+SKZdyP5uxjamD9RhR7Wd?=
 =?us-ascii?Q?tvilzhrs/hZr1VI7UKvyWFS7rRRkV663lU4P24jMWRPIElxGSPdNFNOH0K5/?=
 =?us-ascii?Q?9n37gVNgj1iHRh9gDlD79sM2tjfyKTfQodSz85uhoM5EVxJRE4ur8QNjeWln?=
 =?us-ascii?Q?mbmw2UrWmG6otPiNExfcOlFnUPLBS9DXYUvphz5b2MEmBgUsniNBEkfIZ+Pc?=
 =?us-ascii?Q?yu0hWw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: edb13e7f-e331-487d-d4cb-08db7336494b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 15:35:20.0117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4kTi8mqQLy9QrU5XjoXlHdSkYqWDQxaAPVKIHV+Vmsrjv+wnROF09JzaVCwkcSSOGTiGcUWPaABpafvoSN8FlVdXCO+ZY8R3D7IZwnYULs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB4413
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 22, 2023 at 02:48:46PM +0200, Giulio Benetti wrote:
> Pardon,
> 
> On 22/06/23 14:37, Giulio Benetti wrote:
> > Linux provides phy_set_bits() helper so let's drop brcm_phy_setbits() and
> > use phy_set_bits() in its place.
> > 
> > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > ---
> >   drivers/net/phy/broadcom.c | 15 ++-------------
> >   1 file changed, 2 insertions(+), 13 deletions(-)
> > 
> > diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> > index ad71c88c87e7..d684c5be529a 100644
> > --- a/drivers/net/phy/broadcom.c
> > +++ b/drivers/net/phy/broadcom.c
> > @@ -608,17 +608,6 @@ static int bcm54616s_read_status(struct phy_device *phydev)
> >   	return err;
> >   }
> > -static int brcm_phy_setbits(struct phy_device *phydev, int reg, int set)
> > -{
> > -	int val;
> > -
> > -	val = phy_read(phydev, reg);
> > -	if (val < 0)
> > -		return val;
> > -
> > -	return phy_write(phydev, reg, val | set);
> > -}
> > -
> >   static int brcm_fet_config_init(struct phy_device *phydev)
> >   {
> >   	int reg, err, err2, brcmtest;
> > @@ -689,14 +678,14 @@ static int brcm_fet_config_init(struct phy_device *phydev)
> >   		goto done;
> >   	/* Enable auto MDIX */
> > -	err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_MISCCTRL,
> > +	err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_MISCCTRL,
> >   				       MII_BRCM_FET_SHDW_MC_FAME);
> 
> I've missed to checkpatch.pl and there is a style error ^^^
> 
> >   	if (err < 0)
> >   		goto done;
> >   	if (phydev->dev_flags & PHY_BRCM_AUTO_PWRDWN_ENABLE) {
> >   		/* Enable auto power down */
> > -		err = brcm_phy_setbits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2,
> > +		err = phy_set_bits(phydev, MII_BRCM_FET_SHDW_AUXSTAT2,
> >   					       MII_BRCM_FET_SHDW_AS2_APDE);
> 
>                                       and here ^^^
> 
> I wait some time for any feedback and then I send a V2.

Hi Giulio,

Please include the target tree, net-next, when you send v2:

	Subject: [PATCH net-next v2] ...