Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c59ab814-32d2-963d-e098-7965f6ff1441@meta.com>
Date:   Thu, 22 Jun 2023 09:26:41 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH bpf-next v5 2/3] bpf, x86: allow function arguments up to
 12 for TRACING
Content-Language: en-US
To:     David Laight <David.Laight@ACULAB.COM>,
        "menglong8.dong@gmail.com" <menglong8.dong@gmail.com>,
        "alexei.starovoitov@gmail.com" <alexei.starovoitov@gmail.com>
Cc:     "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "andrii@kernel.org" <andrii@kernel.org>,
        "martin.lau@linux.dev" <martin.lau@linux.dev>,
        "song@kernel.org" <song@kernel.org>, "yhs@fb.com" <yhs@fb.com>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "sdf@google.com" <sdf@google.com>,
        "haoluo@google.com" <haoluo@google.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "benbjiang@tencent.com" <benbjiang@tencent.com>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Menglong Dong <imagedong@tencent.com>
References: <20230613025226.3167956-1-imagedong@tencent.com>
 <20230613025226.3167956-3-imagedong@tencent.com>
 <ca490974-0c5c-cfe9-0c6f-3ead163e7a7b@meta.com>
 <7a82744f454944778f55c36e8445762f@AcuMS.aculab.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <7a82744f454944778f55c36e8445762f@AcuMS.aculab.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dU5xY0dGbElkTG8vRnJlckd3blZaM3pkUCt5dDRUdG8wMVg1WFowZW9QTFhw?=
 =?utf-8?B?anFDSFp1SnhENGpXeC8xVGNrY1FqYWVvRUpNR2dSQjZ6SHJpdDhkZ3BoMGlB?=
 =?utf-8?B?M0NtVDluR3VIV1V2c2hHMTRlZ2JhaGQ0dTJ4aGg3L21WRTZNTkxDM2gyUFFs?=
 =?utf-8?B?TkdYWWoxN0s4UERJVkJCcWpUUEZ6S3VlKzF2ZU5oYUZKUS92RFpGV0hQUnZN?=
 =?utf-8?B?d1o1Y2hCalZYUlZMd21tK3ZhTUZvT0hDdkd5eEN5dEt3SndDeVZxbUlLUWRx?=
 =?utf-8?B?RzVtKzF2YlRlQk1PS2JvdWU0d2J0M1ZkNXlCWXRnV0pYSFZHcHNFSzdsVVc1?=
 =?utf-8?B?c0svY0daZTF1WlVTTEJKUlVTNjJGZ29jRVd2Y2RYaTROY0NLZ0R0N2p2a3Bs?=
 =?utf-8?B?aEJOY1RqMFhFSDRVMkhrOWRvV3VRYnZRY05DMjZrekxEcUVpZ0dyQ2p2YjZq?=
 =?utf-8?B?Ry9XdWJUdlFSVmJmMVVvOCtNOGpVak5PZkxGWUNvUXJRNWlaT1RFUGJ3ZFAx?=
 =?utf-8?B?cThMeEtyZXZDS1FvY3VCRFNYQytBQzZBWDBsODdYZkdmL0t6d0NHbEp6M050?=
 =?utf-8?B?eDRVKytRREpFYlhlc29CeUpNN2ptVVkwRVozSi94REFJMjZQQ2JqWFBUamlj?=
 =?utf-8?B?eUtoS2tkOEtoMHdKYitucFBjcTF0ZjZ6TFAvUU5JRTdCWEc2c1hsR2xmdUZ2?=
 =?utf-8?B?ckdyL3lqb0VDZ0V0c09Ed1Z4b1dPeDRjZUhxanJuVGpTVFkwT2tWOWMrbjh6?=
 =?utf-8?B?a3hUVmhQcGdCM0NmSnlObjFVakczYUtTVlNHcGZtSUI1WGY2OEpEanNQY0lp?=
 =?utf-8?B?d21la0ZSR3JOZEFud1J1VGNKb3dLV3ZMcXU1NXR4cjZsdWdTSU9rQkowMk4v?=
 =?utf-8?B?MWo1dVRKb0pyQ1BkVEtDZzYrZlU4MFdTeUN4L0RnTWk0d25La3dIZ2hSdmQ1?=
 =?utf-8?B?UG9xSU8xc1RxSUQ3QSsxTm1LNi9KNU55SXZYbHhZMDU1WjNMY040MURlWS9y?=
 =?utf-8?B?SE9aUWdFSHQ1V1UyQmozdkgxWjRrK0JWY0RTVGVXdDRaR2hMeHR6dTRrNVNn?=
 =?utf-8?B?TmJob2FDQ0NkV1ZBUXN3RUlRcE0rRHd2SVg0NGxaT252R25ETXdKdnhQV2J6?=
 =?utf-8?B?K3pnMit1ejMrUU5aZEZ0a2JQZTVBOE4xV0xxVkJ1YnJmUExWblpWTUVVOUR2?=
 =?utf-8?B?UUpTZ2o4cnlPdEw0WGNTOHBDZ1BIYmlyTWtlbXpiYWg2N3paQ2x6T2duM2Uy?=
 =?utf-8?B?bXA5RHFWaVFYQWs5TERvUWdRZjNqWTFhV2V1OXhlb0sxVkJnMXZjWkZhOWwy?=
 =?utf-8?B?S3FGMTNzNFNmOE4xbGpqUVE5OUxQVVRpY2JXR0dnQjBOYlFoaHF0T3ROUzRM?=
 =?utf-8?B?bmdsbFgrelhNWmJ1blBNMnZrMFI1bmNlZ2tDc1hlMmtEaHBCU1FUbHZVRUVt?=
 =?utf-8?B?Z1NKbHZtZFEwd0ozR2N1dmJpRXdlcGtmUk42Qmo3VjhNM1BuNGUxaUxYeTBa?=
 =?utf-8?B?YVhHRElQM3BYSHBxdUUvUmRKeU5zS05kT2ZDRU5XT3pJc1BHeDNyVmwxb0NL?=
 =?utf-8?B?M2ZaSk91cXU1RWFoWlFMN0lNcllKeEFTUnRuV2RnZjF1bzVId0tob0FORmVH?=
 =?utf-8?B?R2VadlhVWU84WGl5V1dvdzYvT2dlSXhGbnNHSUJRdlp2eXhwR01kUHA1UTdm?=
 =?utf-8?B?NGl2MFg5YWxBUGUwR0tQcE5GL0RXUlhycyt5Uys5ejlZLzNZNGxwUW9lMk1J?=
 =?utf-8?B?TmtENGUyZUlYV1Fpd3JodGRNVjBFdkdQSWxlbTROSFhhaUZOQ1BoUEdJVG1p?=
 =?utf-8?B?eVkyTUFNcVR0aXZlZVBFeHo4QmlPWDRmZ0FBelNpN1ZNVXlBZ0ZCZ0xDY3BP?=
 =?utf-8?B?S1NzMlJMKzhEc0o4THNzSHA3dGZrdzFDWDkrV0dmNmxOdFhsRTdWbC9kZWhX?=
 =?utf-8?B?UkM5TGhndHVYNFcvMTQwQ3dHK3lSTEt5dm9weDR6QS9PaTA2NXpyMXhaMXF6?=
 =?utf-8?B?WmtSenloM2pReXdFY0l1dWV0NmxuQWZ2eCtRWDgrRjRIVGkyYUsxSlVSWk44?=
 =?utf-8?B?Vyt2YnZlZFl1VVRHWmVWSS9YeUIzZnVIa0c1dUpvL2FuMkxRM0I4ME1NWms0?=
 =?utf-8?B?WFhrb3RCUlRTTFBwNHVVZVdCNnhhdHdQaFZZUVpSUDR0Q1NDSlNWUmNZN08y?=
 =?utf-8?B?Zmc9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df7a69f4-6998-4883-6f3c-08db733d78b6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 16:26:45.9740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PVOJ73yvFcGD6YS4eyHJcrM5i3WEpY4kmCuENuR7yNLHqKuAFC9jpE9+h4JrFp5y
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR15MB6002
X-Proofpoint-ORIG-GUID: GLotAy8hc79X671MWQGcHaUJHUOexgd7
X-Proofpoint-GUID: GLotAy8hc79X671MWQGcHaUJHUOexgd7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-22_11,2023-06-22_02,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/22/23 2:06 AM, David Laight wrote:
> ...
>>> +	/* Generally speaking, the compiler will pass the arguments
>>> +	 * on-stack with "push" instruction, which will take 8-byte
>>> +	 * on the stack. On this case, there won't be garbage values
>>
>> On this case -> In this case. The same for below another case.
>>
>>> +	 * while we copy the arguments from origin stack frame to current
>>> +	 * in BPF_DW.
>>> +	 *
>>> +	 * However, sometimes the compiler will only allocate 4-byte on
>>> +	 * the stack for the arguments. For now, this case will only
>>> +	 * happen if there is only one argument on-stack and its size
>>> +	 * not more than 4 byte. On this case, there will be garbage
>>> +	 * values on the upper 4-byte where we store the argument on
>>> +	 * current stack frame.
> 
> Is that right for 86-64?

yes,

> 
> IIRC arguments always take (at least) 64bits.
> For any 32bit argument (register or stack) the high bits are undefined.
> (Maybe in kernel they are always zero?
>  From 32bit userspace they are definitely random.)
> 
> I think the called code is also responsible form masking 8 and 16bit
> values (in reality char/short args and return values just add code
> bloat).

yes, it does. For example, if an argument has type u8, so
x86_64 might only put a u8 value into 1-byte subregister
and rest of if is undefined. This is what happened to bpf program,
   (1). the whole register/stack is saved to 8-byte stack slot.
   (2). in bpf program, the 8-byte stack slot will be read
        and then cast to u8, so the compiler will do proper
        left shift and right shift to get proper value.

If the argument is u32/s32, the 32-bit subregister 'w*' could
be used without left/right shifting (similar to x86_64 subregister).

So we should be okay here.

> 
> A 128bit value is either passed in two registers or two stack
> slots. If the last register is skipped it will be used for the
> next argument.
> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)