Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 18:56:46 +0200
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390/decompresser: fix misaligned symbol build error
Message-ID: <ZJR9Tnmooclgvt6H@osiris>
References: <20230622125508.1068457-1-hca@linux.ibm.com>
 <20230622143538.GA1138962@dev-arch.thelio-3990X>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622143538.GA1138962@dev-arch.thelio-3990X>
MIME-Version: 1.0
Precedence: bulk

On Thu, Jun 22, 2023 at 02:35:38PM +0000, Nathan Chancellor wrote:
> On Thu, Jun 22, 2023 at 02:55:08PM +0200, Heiko Carstens wrote:
> > Nathan Chancellor reported a kernel build error on Fedora 39:
> > 
> > $ clang --version | head -1
> > clang version 16.0.5 (Fedora 16.0.5-1.fc39)
> > 
> > $ s390x-linux-gnu-ld --version | head -1
> > GNU ld version 2.40-1.fc39
> > 
> > $ make -skj"$(nproc)" ARCH=s390 CC=clang CROSS_COMPILE=s390x-linux-gnu- olddefconfig all
> > s390x-linux-gnu-ld: arch/s390/boot/startup.o(.text+0x5b4): misaligned symbol `_decompressor_end' (0x35b0f) for relocation R_390_PC32DBL
> > make[3]: *** [.../arch/s390/boot/Makefile:78: arch/s390/boot/vmlinux] Error 1
> > 
> > It turned out that the problem with misaligned symbols on s390 was fixed
> > with commit 80ddf5ce1c92 ("s390: always build relocatable kernel") for the
> > kernel image, but did not take into account that the decompressor uses its
> > own set of CFLAGS, which come without -fPIE.
> > 
> > Add the -fPIE flag also to the decompresser CFLAGS to fix this.
> > 
> 
> I think this should also have:
> 
> Reported-by: CKI <cki-project@redhat.com>
> Link: https://lore.kernel.org/32935.123062114500601371@us-mta-9.us.mimecast.lan/
> 
> I technically just forwarded the report and did a little extra testing.

Ok, added.

> Thanks for the quick patch, this fixes the error and I did a simple boot
> test in QEMU with the resulting kernel, which showed no issues.
> 
> Tested-by: Nathan Chancellor <nathan@kernel.org>

And this as well. :) Thanks a lot!