Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp11236691rwd; Thu, 22 Jun 2023 10:24:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70pqiZIVDsU/HhddEeT7rr3127tJzlTX66gsbrYvIsLm8QOwfNN9xP2vCh8CQ8xO7scYtK X-Received: by 2002:a17:903:18a:b0:1b6:6b8d:9d9f with SMTP id z10-20020a170903018a00b001b66b8d9d9fmr11174692plg.59.1687454684429; Thu, 22 Jun 2023 10:24:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687454684; cv=none; d=google.com; s=arc-20160816; b=NMS2cBYSiJNwj9d64izycW3JKYZD6v3Itgj2qVuc9KbqXFudBhUk6NC2RP7enwO4RN ctwfxtQRey00+lcuDezpngTORkjdmN4IB8QT+UR7pDpnKocz8QAfjMRs3boq7gP/RJxx RgX3mdD3tBkhNIpJgAETWPIoEotkcrcpuhkAnC1IQeWpQ2QcZoKsZ0S6Mu+v0ISG6BbO XdbD85S6+CeuoK/9ipUNoktS7yXSKvNct5XM/j+VS78fOl4ajC0ZzyxuS10UnNFc3yXO UJjzhJcjkZmw4TfyzIsPqIyTgL0m0PHuJwlxDiV/GMtAaZg7p4DI14GGwDrWEkSbSGAd 4V8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+caNylAFJnS4RfDuuqPQ5kEyaoWMVveGgJSagPXpK3E=; b=oeTSk8vm5yP+fahe7aRPZSFAZk4Y3vf1WOZr7uq8rPXVdcjsWG68k8gfXKmiRD+YxR ANIc084Pb06t6ZljiHSN8zwsz+fHsltVta8D6BxZlZN8lVF0Mh77iTXmd6tZyXKT5zjL TxTm2nCOdzVCEHqoWX/bxIO5KBZrGAYtrAKoUMd3OXh8p+9oO/YBnljdFbgksdJqYhhO ul13r3No3bRGV0Fbdyp/FJjNXX+l6DgRHDaOWE6hlhuLTKmb4Vwy1ZxdqTolmyAF0oQi XEIkbWumCGrERUo/ZVwHjhkDEHoWCGNZxMD9g5RPN4RTHGtekzb9ohrkOwADztG7hXjn 5PvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eWwIE86g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o8-20020a170902d4c800b001ab147e4543si8006589plg.418.2023.06.22.10.24.32; Thu, 22 Jun 2023 10:24:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eWwIE86g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229854AbjFVRR3 (ORCPT + 99 others); Thu, 22 Jun 2023 13:17:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjFVRR2 (ORCPT ); Thu, 22 Jun 2023 13:17:28 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF48173F for ; Thu, 22 Jun 2023 10:17:27 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-668704a5b5bso4686336b3a.0 for ; Thu, 22 Jun 2023 10:17:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687454246; x=1690046246; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+caNylAFJnS4RfDuuqPQ5kEyaoWMVveGgJSagPXpK3E=; b=eWwIE86gJ1vNE6oGTJapOZQFT46TllCzUn6zfU2GJowNtlE4ccaAhmjBf1y6GkqZMQ Jav+kIow91KofjqIfAO67sRRofF5Lc3/t38LsiHYAXUYTAxQLN7SFoAttjh96+DhY+FA TxusneS92lYEmaAbHSGHOV5jRmE2njvUR81kooDRK6RS2zHGqhaTZJL5L/TJB3gWpNYs ZRYJ1C/Z1HtyufIbMTq6CSXbOkYWLaSfZEDR1aMWR7EcQKcxtXegPTtDIWhI86ZZ3PEG iaRxBCeSN3cuCMYJsP7PBCYE5qfoQ0qHuUeuhpYPaUmvk9TVOMXrp2Ps+OKItL5slb+c UA/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687454246; x=1690046246; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+caNylAFJnS4RfDuuqPQ5kEyaoWMVveGgJSagPXpK3E=; b=CzeMnOmZDOBf3Nd2P/PpkAL9RF7Qfo9HVaSARTtySJpgyfOI2EcaLSDifgjrjwEgjt F7X5HmppNzRtijRsT548aV1pXGv2pFHkVSwtPsweVkdWiF1RXTXWiF5vaJHZ5mOX5o3P X9p5k/qS1BfQEUOyx94df7ycevussrL5K6LZ+ewdxXIJsY09aV/2+ACr4mtzCxGtMwqu HabLRy3LRlmGWxKdYqwTG003+7aoPHYUcLHE0rbdv0pY+aRGc8SOpmdku6WBbp8EUMcG 3GCVJdwtqhn1/7FB+JW9ZaJOz60vBcZ09AS2LqGwLm9ZADwbCjlDvzVMpMNopn35Ztet qkKQ== X-Gm-Message-State: AC+VfDzIiw5rJU5HiXZsilRHumki3pyDWFjhHqNZLpdYoHnVEBay6k0N pZ5lbNVF9XfDBEQwWPeiHSPkTQ== X-Received: by 2002:a05:6a20:7d8b:b0:122:7e50:f71b with SMTP id v11-20020a056a207d8b00b001227e50f71bmr11414744pzj.34.1687454246493; Thu, 22 Jun 2023 10:17:26 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:2d81:4abe:75da:eae]) by smtp.gmail.com with ESMTPSA id c11-20020a62e80b000000b00649ac17779csm4780000pfi.160.2023.06.22.10.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 10:17:25 -0700 (PDT) Date: Thu, 22 Jun 2023 11:17:22 -0600 From: Mathieu Poirier To: AngeloGioacchino Del Regno Cc: Tinghan Shen , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v13 00/11] Add support for MT8195 SCP 2nd core Message-ID: References: <20230607072222.8628-1-tinghan.shen@mediatek.com> <5a9beeec-5762-c469-6e03-b71babb5f7ed@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5a9beeec-5762-c469-6e03-b71babb5f7ed@collabora.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 22, 2023 at 12:00:08PM +0200, AngeloGioacchino Del Regno wrote: > Il 07/06/23 09:22, Tinghan Shen ha scritto: > > The mediatek remoteproc driver currently only allows bringing up a > > single core SCP, e.g. MT8183. It also only bringing up the 1st > > core in SoCs with a dual-core SCP, e.g. MT8195. This series support > > to bring-up the 2nd core of the dual-core SCP. > > > > Hello TingHan, > > Can you please address the comments on patch [05/11] and send a new version ASAP? > That's the only remaining issue, so after that the series should be ready. > There is also the refactoring work in patch 07, and I expect that to take a while. > Thanks, > Angelo > > > v12 -> v13: > > 1. replace subdevice with new mediatek scp operations in patchset 7 > > 2. add review tag to patchset 3 > > 3. modify mediatek,scp phandle name of video-codec@18000000 at patchset 11 > > > > v11 -> v12: > > 1. add scp_add_single/multi_core() to patchset 6 > > 2. remove unused comment in patchset 6 > > 3. rename list name from mtk_scp_cluster to mtk_scp_list > > 4. rewrite the multi-core probe flow > > 5. disable rproc->autoboot and boot rproc by request_firmware_nowait at patchset 7 > > 6. remove patchset 7 review tag > > > > v10 -> v11: > > 1. rewrite patchset 5 to probe single-core SCP with the cluster list > > 2. Also in patchset 5, move the pointer of mtk_scp object from the > > platform data property to the driver data property > > 3. move the appearance of mtk_scp cluster property to patcheset 7 > > > > v9 -> v10: > > 1. move the global mtk_scp list into the platform device driver data structure > > 2. remove an unnecessary if() condition > > > > v8 -> v9: > > 1. initialize l1tcm_size/l1tcm_phys at patchset 05/11 > > 2. rewrite patchset 06/11 to unify the flow and remove hacks > > > > v7 -> v8: > > 1. update the node name of mt8192 asurada SCP rpmsg subnode > > 2. squash register definitions into driver patches > > 3. initialize local variables on the declaration at patch v8 06/11 > > > > v6 -> v7: > > 1. merge the mtk_scp_cluster struct into the mtk_scp structure > > at the "Probe multi-core SCP" patch > > > > v5 -> v6: > > 1. move the mtk_scp_of_regs structure from mtk_common.h to mtk_scp.c > > 2. rename the SCP core 0 label from 'scp' to 'scp_c0' > > > > v4 -> v5: > > 1. move resource release actions to the platform driver remove operation > > 2. fix dual-core watchdog handling > > > > v3 -> v4: > > 1. change the representation of dual-core SCP in dts file and update SCP yaml > > 2. rewrite SCP driver to reflect the change of dts node > > 3. drop 'remove redundant call of rproc_boot for SCP' in v3 for further investigation > > > > v2 -> v3: > > 1. change the representation of dual-core SCP in dts file and update SCP yaml > > 2. rewrite SCP driver to reflect the change of dts node > > 3. add SCP core 1 node to mt8195.dtsi > > 4. remove redundant call of rproc_boot for SCP > > 5. refine IPI error message > > > > v1 -> v2: > > 1. update dt-binding property description > > 2. remove kconfig for scp dual driver > > 3. merge mtk_scp_dual.c and mtk_scp_subdev.c to mtk_scp.c > > > > > > Tinghan Shen (11): > > dt-bindings: remoteproc: mediatek: Improve the rpmsg subnode > > definition > > arm64: dts: mediatek: Update the node name of SCP rpmsg subnode > > dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP > > remoteproc: mediatek: Add MT8195 SCP core 1 operations > > remoteproc: mediatek: Introduce cluster on single-core SCP > > remoteproc: mediatek: Probe multi-core SCP > > remoteproc: mediatek: Add scp_boot_peers and scp_shutdown_peers > > operations > > remoteproc: mediatek: Setup MT8195 SCP core 1 SRAM offset > > remoteproc: mediatek: Handle MT8195 SCP core 1 watchdog timeout > > remoteproc: mediatek: Refine ipi handler error message > > arm64: dts: mediatek: mt8195: Add SCP 2nd core > > > > .../bindings/remoteproc/mtk,scp.yaml | 176 +++++++- > > .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +- > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 2 +- > > .../boot/dts/mediatek/mt8195-cherry.dtsi | 6 +- > > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 32 +- > > drivers/remoteproc/mtk_common.h | 26 ++ > > drivers/remoteproc/mtk_scp.c | 425 ++++++++++++++++-- > > 7 files changed, 594 insertions(+), 75 deletions(-) > > >