Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i83e94755:Fastmail
Date:   Thu, 22 Jun 2023 10:51:02 -0700
From:   Josh Triplett <josh@joshtriplett.org>
To:     Allen Ballway <ballway@chromium.org>
Cc:     arun.r.murthy@intel.com, dri-devel@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be
 dimmed
Message-ID: <ZJSKBg+LymhvINoG@localhost>
References: <20230606211901.1.I06e778109090b5dc85c44da7b742d185aa6adb59@changeid>
 <20230622172817.2281527-1-ballway@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622172817.2281527-1-ballway@chromium.org>
Precedence: bulk

On Thu, Jun 22, 2023 at 05:28:15PM +0000, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct intel_connector *connector)
> 
>  	drm_WARN_ON(&i915->drm, panel->backlight.pwm_level_max == 0);
> 
> +	if (intel_has_quirk(i915, QUIRK_NO_DIM)) {
> +		/* Cannot dim backlight, set minimum to hightest value */

Typo: s/hightest/highest/