Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Frank Filz" <ffilzlnx@mindspring.com>
To:     "'Chuck Lever III'" <chuck.lever@oracle.com>,
        "'stsp'" <stsp2@yandex.ru>
Cc:     "'Jeff Layton'" <jlayton@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        "'Al Viro'" <viro@zeniv.linux.org.uk>,
        "'Christian Brauner'" <brauner@kernel.org>,
        <linux-fsdevel@vger.kernel.org>, "'Shuah Khan'" <shuah@kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-api@vger.kernel.org>
References: <20230621152214.2720319-1-stsp2@yandex.ru> <20230621152214.2720319-3-stsp2@yandex.ru> <4db7c65bee0739fe7983059296cfc95f20647fa3.camel@kernel.org> <7bbb29d2-4cae-48bd-1b97-9f4dbf6ffb19@yandex.ru> <8F45F47C-86C0-472E-B701-001A4FF90DBC@oracle.com> <26a798ae-b93b-2f68-71ed-35950240927d@yandex.ru> <187C3E49-A977-492E-99CB-97F032B24E5F@oracle.com>
In-Reply-To: <187C3E49-A977-492E-99CB-97F032B24E5F@oracle.com>
Subject: RE: [PATCH 2/2] selftests: add OFD lock tests
Date:   Thu, 22 Jun 2023 10:34:33 -0700
Message-ID: <0a2001d9a52f$cfd24450$6f76ccf0$@mindspring.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: AQFRuQ0uoMlieQo9bLavrmguyfHQFQJxeCDcAuSmYXMCWoer6wFUNlsYArCPQ1cBeWn8P7A9dY2w
Precedence: bulk

> > On Jun 22, 2023, at 1:05 PM, stsp <stsp2@yandex.ru> wrote:
> >
> >
> > 22.06.2023 21:58, Chuck Lever III =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >> IMO that's not a reason not to do this properly.
> >>
> >> You should work with Jeff and the maintainer of xfstests to make it
> >> happen.
> > But its not going to be in this patch-set anyway, as its a different
> > source tree...
>=20
> If others agree with me, then please drop the selftests patch from =
this series.
> There is a considerably higher probability that the new test will be =
run frequently
> by CI if it's in xfstests.
>=20
>=20
> > So I should prepare it when this is merged, or?
>=20
> I don't have a strong preference. A good choice is to push the test =
before the
> kernel changes are merged.

As an aside, an additional testing option for OFD locks is the multilock =
test tool that is in the nfs-ganesha project. In preparation to use OFD =
locks in Ganesha, I added them to multilock to check them out, and that =
incidentally also allows testing how the NFS client and server work when =
OFD locks are taken on a file from an NFS mount.

Frank