Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 20:18:54 +0100
From:   Conor Dooley <conor@kernel.org>
To:     kah.jing.lee@intel.com
Cc:     Dinh Nguyen <dinguyen@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org,
        Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout
 for UBIFS
Message-ID: <20230622-campsite-uncloak-37c292c37862@spud>
References: <20230622085319.562868-1-kah.jing.lee@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="NOZVfU//uCalvVia"
Content-Disposition: inline
In-Reply-To: <20230622085319.562868-1-kah.jing.lee@intel.com>
Precedence: bulk


--NOZVfU//uCalvVia
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 22, 2023 at 04:53:19PM +0800, kah.jing.lee@intel.com wrote:
> From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
>=20
> This patch is to update the QSPI flash layout to support UBIFS in mtd
> root partition.

That much is clear from the diff. Surely it'd be better to explain *why*
this change is being made, no?

Thanks,
Conor.

>=20
> Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
> Signed-off-by: Kah Jing Lee <kah.jing.lee@intel.com>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
>  arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts     | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
>=20
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arc=
h/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 38ae674f2f02..12b960b9183c 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -202,12 +202,12 @@ partitions {
> =20
>  			qspi_boot: partition@0 {
>  				label =3D "Boot and fpga data";
> -				reg =3D <0x0 0x03FE0000>;
> +				reg =3D <0x0 0x04200000>;
>  			};
> =20
> -			qspi_rootfs: partition@3FE0000 {
> -				label =3D "Root Filesystem - JFFS2";
> -				reg =3D <0x03FE0000 0x0C020000>;
> +			root: partition@4200000 {
> +				label =3D "Root Filesystem - UBIFS";
> +				reg =3D <0x04200000 0x0BE00000>;
>  			};
>  		};
>  	};
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/ar=
m64/boot/dts/intel/socfpga_agilex_socdk.dts
> index 07c3f8876613..608017e6e36a 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -128,12 +128,12 @@ partitions {
> =20
>  			qspi_boot: partition@0 {
>  				label =3D "Boot and fpga data";
> -				reg =3D <0x0 0x03FE0000>;
> +				reg =3D <0x0 0x04200000>;
>  			};
> =20
> -			qspi_rootfs: partition@3FE0000 {
> -				label =3D "Root Filesystem - JFFS2";
> -				reg =3D <0x03FE0000 0x0C020000>;
> +			root: partition@4200000 {
> +				label =3D "Root Filesystem - UBIFS";
> +				reg =3D <0x04200000 0x0BE00000>;
>  			};
>  		};
>  	};
> --=20
> 2.25.1
>=20

--NOZVfU//uCalvVia
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJSengAKCRB4tDGHoIJi
0iIHAQDqf/4QTbMLRWbau04J+oH+gmsUEGjqswKbSS1iRPgujQD/WYs72WN7X8cQ
Kyh5apQuOAG+A15BRctp0ltJ/65I+Ac=
=vLev
-----END PGP SIGNATURE-----

--NOZVfU//uCalvVia--