Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 20:05:48 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Praveen Talari <quic_ptalari@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        broonie@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com,
        quic_vnivarth@quicinc.com, quic_arandive@quicinc.com
Subject: Re: [PATCH v3 2/3] spi: dt-bindings: qcom,spi-geni-qcom: Add SPI
 device mode support for GENI based QuPv3
Message-ID: <20230622-sustained-marauding-5c6c8a76c834@spud>
References: <20230622135955.941-1-quic_ptalari@quicinc.com>
 <20230622135955.941-3-quic_ptalari@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="BpA4WeFicj+70oUn"
Content-Disposition: inline
In-Reply-To: <20230622135955.941-3-quic_ptalari@quicinc.com>
Precedence: bulk


--BpA4WeFicj+70oUn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 22, 2023 at 07:29:54PM +0530, Praveen Talari wrote:
> Add a property to configure QUPv3 SE as SPI Device mode.
>=20
> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
> ---
> v2 -> v3:
> - modified commit message to use device mode instead of slave mode

Suitability or w/e of the property aside, I don't understand this.
Why not change the *property*, which has far more visibility than the
commit message, to use device rather than slave?

Chers,
Conor.

> ---
>  Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yam=
l b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index 2e20ca313ec1..5c7d0293bbf7 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -66,6 +66,10 @@ properties:
>    reg:
>      maxItems: 1
> =20
> +  qcom,slv-ctrl:
> +    description: configure QUPv3 SE as Device mode
> +    type: boolean
> +
>  required:
>    - compatible
>    - clocks
> --=20
> 2.17.1
>=20

--BpA4WeFicj+70oUn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJSbjAAKCRB4tDGHoIJi
0rQBAP9VpTT/MeUMABsfUwyLydR8mL17cNI3B76hNRLlyLp64AEAqfYCLzbG42gx
ytwOhlHoaVCMHkXXoV3Z855RkLCYXAU=
=n14M
-----END PGP SIGNATURE-----

--BpA4WeFicj+70oUn--