Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230620120521.688124-1-masahiroy@kernel.org> <20230620120521.688124-2-masahiroy@kernel.org>
In-Reply-To: <20230620120521.688124-2-masahiroy@kernel.org>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 22 Jun 2023 12:01:39 -0700
Message-ID: <CAKwvOdnuXJOiDrdGjux6JMb8akYQTi1ohPZtH1i_ZhYuJpshbQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] modpost: factor out Elf_Sym pointer calculation to section_rel()
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nathan Chancellor <nathan@kernel.org>,
        Nicolas Schier <nicolas@fjasle.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 20, 2023 at 5:05=E2=80=AFAM Masahiro Yamada <masahiroy@kernel.o=
rg> wrote:
>
> Pass the Elf_Sym pointer to addend_arm_rel() as well as to
> check_section_mismatch().
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
>  scripts/mod/modpost.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index 2551ac9d5bd3..ffe45c54f024 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1295,10 +1295,9 @@ static int32_t sign_extend32(int32_t value, int in=
dex)
>         return (int32_t)(value << shift) >> shift;
>  }
>
> -static int addend_arm_rel(void *loc, struct elf_info *elf, Elf_Rela *r)
> +static int addend_arm_rel(void *loc, Elf_Sym *sym, Elf_Rela *r)
>  {
>         unsigned int r_typ =3D ELF_R_TYPE(r->r_info);
> -       Elf_Sym *sym =3D elf->symtab_start + ELF_R_SYM(r->r_info);
>         uint32_t inst, upper, lower, sign, j1, j2;
>         int32_t offset;
>
> @@ -1493,6 +1492,7 @@ static void section_rel(struct module *mod, struct =
elf_info *elf,
>                 return;
>
>         for (rel =3D start; rel < stop; rel++) {
> +               Elf_Sym *tsym;
>                 void *loc;
>
>                 r.r_offset =3D TO_NATIVE(rel->r_offset);
> @@ -1514,6 +1514,7 @@ static void section_rel(struct module *mod, struct =
elf_info *elf,
>                 r.r_addend =3D 0;
>
>                 loc =3D sym_get_data_by_offset(elf, fsecndx, r.r_offset);
> +               tsym =3D elf->symtab_start + ELF_R_SYM(r.r_info);
>
>                 switch (elf->hdr->e_machine) {
>                 case EM_386:
> @@ -1521,7 +1522,7 @@ static void section_rel(struct module *mod, struct =
elf_info *elf,
>                                 continue;
>                         break;
>                 case EM_ARM:
> -                       if (addend_arm_rel(loc, elf, &r))
> +                       if (addend_arm_rel(loc, tsym, &r))
>                                 continue;
>                         break;
>                 case EM_MIPS:
> @@ -1532,7 +1533,7 @@ static void section_rel(struct module *mod, struct =
elf_info *elf,
>                         fatal("Please add code to calculate addend for th=
is architecture\n");
>                 }
>
> -               check_section_mismatch(mod, elf, elf->symtab_start + r_sy=
m,
> +               check_section_mismatch(mod, elf, tsym,
>                                        fsecndx, fromsec, r.r_offset, r.r_=
addend);
>         }
>  }
> --
> 2.39.2
>


--=20
Thanks,
~Nick Desaulniers