Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 20:52:19 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Claudiu Beznea <claudiu.beznea@microchip.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: microchip,sama7g5-pdmc: Simplify
 "microchip,mic-pos" constraints
Message-ID: <20230622-canary-hull-0bbce1bb5fe2@spud>
References: <20230621231044.3816914-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="n5Hq6IEtyp/Vfwcf"
Content-Disposition: inline
In-Reply-To: <20230621231044.3816914-1-robh@kernel.org>
Precedence: bulk


--n5Hq6IEtyp/Vfwcf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 21, 2023 at 05:10:44PM -0600, Rob Herring wrote:
> "enum" values should be integers or strings, not arrays (though json-sche=
ma
> does allow arrays, we do not). In this case, all possible combinations are
> allowed anyways, so there's little point in expressing as an array.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  .../devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pd=
mc.yaml b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.ya=
ml
> index 9b40268537cb..9aa65c975c4e 100644
> --- a/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> +++ b/Documentation/devicetree/bindings/sound/microchip,sama7g5-pdmc.yaml
> @@ -56,13 +56,9 @@ properties:
>      items:
>        items:
>          - description: value for DS line
> +          enum: [0, 1]
>          - description: value for sampling edge
> -      anyOf:
> -        - enum:
> -            - [0, 0]
> -            - [0, 1]
> -            - [1, 0]
> -            - [1, 1]
> +          enum: [0, 1]
>      minItems: 1
>      maxItems: 4
>      uniqueItems: true
> --=20
> 2.40.1
>=20

--n5Hq6IEtyp/Vfwcf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJSmcgAKCRB4tDGHoIJi
0h+1AQDWLZ2+pN5p+5p3PIsPYI5oFDt7Ss2qa5ERr4sm355wlAEAjghMkJ5HE9Ne
vIGqP1DEh9LawMW96u8DCm1mEtVA6g8=
=JDj9
-----END PGP SIGNATURE-----

--n5Hq6IEtyp/Vfwcf--