Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Anup Sharma <anupnewsmail@gmail.com>
Date:   Fri, 23 Jun 2023 01:33:10 +0530
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Anup Sharma <anupnewsmail@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] Add support for Firefox's gecko profile format
Message-ID: <ZJSo/uzJNyfcflNY@yoga>
References: <cover.1687375189.git.anupnewsmail@gmail.com>
 <a44290cc-5954-8d5a-f84c-9e5a68732ea4@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a44290cc-5954-8d5a-f84c-9e5a68732ea4@intel.com>
Precedence: bulk

On Thu, Jun 22, 2023 at 07:43:13AM +0300, Adrian Hunter wrote:
> On 21/06/23 22:35, Anup Sharma wrote:
> > This patch series adds support for Firefox's gecko profile format.
> > The format is documented here [1]
> > 
> > The series adds a new python script that can be used to convert the 
> > perf script to gecko profile format. To use this script, use the
> > following commands: 
> > 
> > perf record 
> > perf script -F +pid > perf_data.txt
> > python3 firefox-gecko-converter.py > gecko_profile.json
> 
> Why not use the perf script python interface?

Hi Adrian,
Thank you for your suggestion. I am working on it and will try to implement 
it in the next version.

> https://perf.wiki.kernel.org/index.php/Latest_Manual_Page_of_perf-script-python.1
> 
> > 
> > Also dont forget to change the chown of the output file to the user[2].
> > 
> > [1] https://github.com/firefox-devtools/profiler/blob/main/docs-developer/gecko-profile-format.md
> > [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1823421
> > 
> > Anup Sharma (9):
> >   scripts: python: Add check for correct perf script format
> >   scripts: python: implement add sample function and return it
> >   scripts: python: Introduce thread sample processing in
> >     convertPerfScriptProfile
> >   scripts: python: Implement parsing of input data in
> >     convertPerfScriptProfile
> >   scripts: python: implement function for thread creation
> >   scripts: python: implement get or create stack function
> >   scripts: python: implement get or create frame function
> >   scripts: python: Finalize convertPerfScriptProfile and return profile
> >     data
> >   scripts: python: Add temporary main function for testing purposes
> > 
> >  .../scripts/python/firefox-gecko-converter.py | 249 ++++++++++++++++++
> >  1 file changed, 249 insertions(+)
> >  create mode 100644 tools/perf/scripts/python/firefox-gecko-converter.py
> > 
>