Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 22 Jun 2023 20:14:53 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc:     devicetree@vger.kernel.org, tglx@linutronix.de, maz@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: add Ralink SoCs
 interrupt controller
Message-ID: <20230622-algebra-superglue-40955b223774@spud>
References: <20230622110451.1504823-1-sergio.paracuellos@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="QXySfpWsCJAcdqLS"
Content-Disposition: inline
In-Reply-To: <20230622110451.1504823-1-sergio.paracuellos@gmail.com>
Precedence: bulk


--QXySfpWsCJAcdqLS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 22, 2023 at 01:04:51PM +0200, Sergio Paracuellos wrote:
> Add YAML doc for the interrupt controller which is present on Ralink SoCs.
>=20
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes in v2:
>  - Drop label from the example.
>=20
>  .../ralink,rt2880-intc.yaml                   | 54 +++++++++++++++++++
>  1 file changed, 54 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controlle=
r/ralink,rt2880-intc.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ralin=
k,rt2880-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller=
/ralink,rt2880-intc.yaml
> new file mode 100644
> index 000000000000..533d6d03aa75
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/ralink,rt288=
0-intc.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/ralink,rt2880-in=
tc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ralink SoCs Interrupt Controller
> +
> +maintainers:
> +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> +
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#
> +
> +description: |

FWIW, you don't need a | unless you have some formatting to preserve.

> +  This interrupt controller support a central point for interrupt aggreg=
ation
> +  for platform related blocks.
> +
> +properties:
> +  compatible:
> +    const: ralink,rt2880-intc
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  '#interrupt-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-controller
> +  - '#interrupt-cells'
> +
> +unevaluatedProperties: false

You explicitly allow two properties from interrupt-controller.yaml, so
it seems like this should actually be additionalProperties: false to
block things like interrupt-map etc?

If your intention was only to allow interrupt-controller, with
s/unevaluated/additional/ you can add
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> +
> +examples:
> +  - |
> +    interrupt-controller@200 {
> +      compatible =3D "ralink,rt2880-intc";
> +      reg =3D <0x200 0x100>;
> +      interrupt-controller;
> +      #interrupt-cells =3D <1>;
> +
> +      interrupt-parent =3D <&cpuintc>;
> +      interrupts =3D <2>;
> +    };
> +...
> --=20
> 2.25.1
>=20

--QXySfpWsCJAcdqLS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJSdrQAKCRB4tDGHoIJi
0uqDAQCcgFbS7S9oLnnfQqMN3+amaFefAoNne1acSsTviyeCJwD/TSQTo0ZuxjUK
2lewMQmES4YW/S7KigE/HufFPK5FGQ4=
=qUnP
-----END PGP SIGNATURE-----

--QXySfpWsCJAcdqLS--