Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp11600165rwd; Thu, 22 Jun 2023 16:02:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6/j+ZG1Sgt4hYTfGy+/99OdkR6Uqty185+rgvxPLsIN0mnteq5nP6Wq51wCnFE/vYRhD4V X-Received: by 2002:a05:6a00:2d9a:b0:66a:386c:e6a3 with SMTP id fb26-20020a056a002d9a00b0066a386ce6a3mr7234412pfb.34.1687474939828; Thu, 22 Jun 2023 16:02:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687474939; cv=none; d=google.com; s=arc-20160816; b=aG87kJjnJo/tI8yAnmFyTqmQlaW+MQrd1fLb5Sr43xeszX2NO3hAvcl/gb4Vj/j2px PZcV9DU55V3FbqZm5rF/FmpP3BskB7lvhkitsYVO94jQgzXA3mw8LZ8JzlpAjl2240RS oZNUCQ7ENwOfubkD688PFatqu0FIumaNRKOEYeYfmFQYqD9GDNAieOQyoiLfjLi48H1J doDuVbmTNt5/RvlM3rXUBxCcwuNEkB8D9DKSewVPHI5rwnM0+r1y1ShIpo4dU7WGsHQ9 UwpcnB15JaRATCyvkP7TS/XK+c+uKsxhBQhTGRjzIknpE7SnquY72cMt/L2RFGINNP0r ykKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RWTgYq2UUxEsCsczZywS54H3UJIh7PEQ08XF3T1QNQI=; b=Q7lfd565X0vs7WmWf6qqquGGiOZojPPNGmG4J0fUHaTv/ThWEIrVgip1e/j0jBKJsY 0xoyDDr0Dt6Bw7p/SxCmQNVa5ZNzZ87QYAbrcJctujxCZaDDRCWfgTPyn2KEUJpDBOX5 5AYzfWjS/26IA21s9eb1i/xhLDDMo+E8jBzgRp98BYB1EVDfoNLEWrQR7/aWawjxR4m6 /IfAVheox6zcY5PMW3UVhfW8i9b5hHjw8eRdz6rA+B97Qe1BF5aMq3tgoNpCQj22l4Y7 mr5fgnPkyWemjvXZf5j+FcCTP0GwsR+ZCPWAU01eak2F8bC8NRhdsrmwzxK5U/5vbU+T K8AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=erEg5tOQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fromorbit.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k62-20020a638441000000b00535540cc8ccsi4777000pgd.375.2023.06.22.16.02.06; Thu, 22 Jun 2023 16:02:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fromorbit-com.20221208.gappssmtp.com header.s=20221208 header.b=erEg5tOQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fromorbit.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjFVWPv (ORCPT + 99 others); Thu, 22 Jun 2023 18:15:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230452AbjFVWPu (ORCPT ); Thu, 22 Jun 2023 18:15:50 -0400 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A2F2114 for ; Thu, 22 Jun 2023 15:15:49 -0700 (PDT) Received: by mail-oi1-x234.google.com with SMTP id 5614622812f47-39eab4bcee8so4811680b6e.0 for ; Thu, 22 Jun 2023 15:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20221208.gappssmtp.com; s=20221208; t=1687472148; x=1690064148; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RWTgYq2UUxEsCsczZywS54H3UJIh7PEQ08XF3T1QNQI=; b=erEg5tOQrXPIIkPMrTVT0g485cXgkF/mSZwczNIMFvys3/3M8s5touTnozJgkJnrv8 MFgmH40Daa20QkYuk/ODWSbN3LRXmOTp58f7zONk5K1txgIR2E8530LaoJ51BKnZY5aO q2mU71Au/pRMDG+NvsVvPFmQc6ZfVXk4ZJnNrQHF6MhxbN3POquh8W6sbg6BpsfU+l9Z TkwUKpPMpEYhD1uL94U3aeq6C4rVRimj2eXjJmERe1oophqJqKOGbPxQE61zl4rUBY/F iOzC66FM7hcAoKz+QXRHotEMNHJjsYwHuYiVdOFUNE5F6uu2fIgvAz22mSWoEyV6S/OC H5vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687472148; x=1690064148; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RWTgYq2UUxEsCsczZywS54H3UJIh7PEQ08XF3T1QNQI=; b=O4HHePUjKQfKgaRbGLLuS+Xw7QBR7ZEB0/mlwhwJ8Eb8rNvtxZ6m6H4vEOmSrb0QBf m/CFIw74dhxByrRn3jM5WFgaDK6oACPCmulp4nMfr7Hk7e8k8ShqTJh/gjKBqXdA4Vr9 TZPY8NVWLZ37u/knEDsPkkE1NhEVvtISJ4u+Wmk0IFh0wYzw80O/PgPzWHE3ZtmS/zRF +IBWRp/24fM0ic8/MZeP/YF8y+opmkM+MYgY0m4PSaO6VSC+xMIZeO6Jb7xE3CtnA8w4 EkIl7WL2Pjlj9Myi/+7dq3ku8bIXpxsbGh/81J/zObF0Sn9b6PSN++uAxxbA5i+sdWQs /EzA== X-Gm-Message-State: AC+VfDxXSCuhJ9kHJnXDK4qBnCH/lecr8HxHecFfZPyjlskORZuTalOa xg0mBT6xoja9D2GLvQE7I56mWg== X-Received: by 2002:a05:6808:1b0f:b0:39a:aafd:dda7 with SMTP id bx15-20020a0568081b0f00b0039aaafddda7mr22999807oib.35.1687472148243; Thu, 22 Jun 2023 15:15:48 -0700 (PDT) Received: from dread.disaster.area (pa49-180-13-202.pa.nsw.optusnet.com.au. [49.180.13.202]) by smtp.gmail.com with ESMTPSA id d24-20020a17090ac25800b0025b83c6227asm217949pjx.3.2023.06.22.15.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 15:15:47 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1qCSaf-00F0Us-05; Fri, 23 Jun 2023 08:15:45 +1000 Date: Fri, 23 Jun 2023 08:15:45 +1000 From: Dave Chinner To: stsp Cc: Chuck Lever III , Jeff Layton , "linux-kernel@vger.kernel.org" , Al Viro , Christian Brauner , "linux-fsdevel@vger.kernel.org" , Shuah Khan , "linux-kselftest@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH 2/2] selftests: add OFD lock tests Message-ID: References: <20230621152214.2720319-1-stsp2@yandex.ru> <20230621152214.2720319-3-stsp2@yandex.ru> <4db7c65bee0739fe7983059296cfc95f20647fa3.camel@kernel.org> <7bbb29d2-4cae-48bd-1b97-9f4dbf6ffb19@yandex.ru> <8F45F47C-86C0-472E-B701-001A4FF90DBC@oracle.com> <26a798ae-b93b-2f68-71ed-35950240927d@yandex.ru> <187C3E49-A977-492E-99CB-97F032B24E5F@oracle.com> <4582a51d-2b29-f430-2f8f-ed1239d70f70@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4582a51d-2b29-f430-2f8f-ed1239d70f70@yandex.ru> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 22, 2023 at 10:31:06PM +0500, stsp wrote: > > 22.06.2023 22:12, Chuck Lever III пишет: > > I don't have a strong preference. A good choice is to > > push the test before the kernel changes are merged. > It will fail though w/o kernel changes. > So what exactly is the policy? filesystem unit test functionality needs to be pushed into fstests and/or ltp. The preference is the former, because just about every filesystem developer and distro QA team is running this as part of their every-day testing workflow. fstests is written to probe whether the kernel supports a given feature or not before testing it. It will _not_run() a test that doesn't have the required kernel/fs/device support, and this is not considered a test failure. Yes, it means you have to also write the userspace feature probing code, but that should be trivial to do because userspace already has to be able to safely discover that this extension exists, right? -Dave. -- Dave Chinner david@fromorbit.com