Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ac1d0543-9bab-a05d-30cf-2bbbb579162f@intel.com>
Date:   Thu, 22 Jun 2023 16:17:55 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.11.1
Subject: Re: [PATCH v6 09/27] cxl/acpi: Move add_host_bridge_uport() after
 cxl_get_chbs()
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <Jonathan.Cameron@huawei.com>, <linux-cxl@vger.kernel.org>
CC:     <rrichter@amd.com>, <linux-kernel@vger.kernel.org>,
        <bhelgaas@google.com>
References: <20230622035126.4130151-1-terry.bowman@amd.com>
 <20230622035126.4130151-10-terry.bowman@amd.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230622035126.4130151-10-terry.bowman@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2NhdFBaVlYzZnY0VnpTMkMxTVo1R1ZhVnNqNUd0ZDFsMTZ3QkdIOGI1OExi?=
 =?utf-8?B?Y2xqK1pYdDByYkdJK0krZjFwVjhudW1tMVdUbW1yS0hpWEcwTUhLNVJoN1dM?=
 =?utf-8?B?Q25PK3pqOWtlaGxUbDBiVFIrVktvT252aUNQV3paajl1MmlPeVpka2VtRVkr?=
 =?utf-8?B?NGxtVy81dmpqM2g4aXZDN0VTQjZFcHV1NGpOTDNYSlFSb3hrekh1eU4xZ0sv?=
 =?utf-8?B?MmNtdDBYa3ord21RUVRLcHJlS055VFJueEpCM3dublgzSEgweWZFWEZEVDdD?=
 =?utf-8?B?WWVwNnNHL1FLbkpyUTQ1VW1lbUFaOFBsRjN0VFRINXJnVHhNM28wT1p2R3hm?=
 =?utf-8?B?MHpEbDFDV1h6Y08ydjBQOG4wZlErRTlzZkt3WjVQU2xIQllHRmZ4a21tc1RO?=
 =?utf-8?B?RWtvR3h6d1BtQnhzWEg3cG9TdFRmNHB5VkZzam9venBzSGRDREJ0aTUrVVg0?=
 =?utf-8?B?QS9ybVlVMkJHbjRoV0VqUS9rOERWQXc4YVQ4WkZ4UHhiOUROOUxxT2hlY1Nr?=
 =?utf-8?B?a1dYakUrL05pekZ1dFNWNEpQd1J6N0xhQlJVUzM2Sml5NjVBODR4VjlVeWRq?=
 =?utf-8?B?U1lLbzYwRFMrcVVBNHdxaFErQzBpM3RCSUVpUUN2WmpyWkpYc2p2ai80WTFO?=
 =?utf-8?B?SXgrcFFQdmovWDBjQm41Y3BmRG10OG1uK2RkeTJHN1BjUE9ObVdZUGJiL05z?=
 =?utf-8?B?dUx6OE5tMEdzZzFBRTVwSnhFN0ltalpNS0NhME1vRWR5NUd4bWJmbGd2S3Bx?=
 =?utf-8?B?Q2Z4WDhZcXpTNGNDRVk3bDduWWdWUUhVQzAzeGRNTnh6R1FUMWZERnh3UUdw?=
 =?utf-8?B?K05IR2UxWW0wZU1IMWZyWERQVTRLcVFlRTA1VXdjdENaR0Yxa2FLZEZDdnV6?=
 =?utf-8?B?Z3puclIwTmdGMHRvYXNUdllxenhSVXhuU0hFMlZNZHRPOTVSRjRKYnJ6d1Uw?=
 =?utf-8?B?ZFZLbUZvYmdpQklZaFQxcStrd296V0hJS1M3VUtXQkJvWUlVbXgrMStmbG55?=
 =?utf-8?B?aWt3L0wrcGxlZUk1L1FWSUFsZ0RnUEhHdkRsZkpSM240MWwyTFlJdHVGQzFh?=
 =?utf-8?B?azRyOGQ1NFZtSm82ci9KWFJGcEpoVVZjdlJ2dDR5VkpTWXlBQkpLcHczdWZQ?=
 =?utf-8?B?OCtZNmxzYjJiTkZPbm9sSyt2K1ZKRGRKaDhNUHgwTVRMWTFBS1FQaXJQRk1q?=
 =?utf-8?B?aUVlYUZnR0FWRWt0TE9nbUlRVWk4MklQQXpjam9KSW1DWWxMTmdXcEpXNTRa?=
 =?utf-8?B?QkR3UzVzZTlhUEwzUzEyZG1qQWJMZnB3QzJsTDlmTUh3eGdrTmYzNWJmMTJ1?=
 =?utf-8?B?U0hpbkIyQmU3U2FvNDVYbTlVVUxjNFMvWVlkTDBlU0J4aStib1dEKzVuWWQv?=
 =?utf-8?B?S3p1R2hTeHZaNDFSUU91RjJRelEzSFJaenBLSUZFdE4zUStZcXd4ODE3ZTA2?=
 =?utf-8?B?VHNGYlF3MWcyb0ZGcG1Ec1BKTlJ2bGNyZTNkTG5yaHBQa1lhcVY5ZlU0YSs1?=
 =?utf-8?B?SElLQUJBU2xETUx2dTJXQjc1RzZGemNYZW04cTlEK211eGNFc2hSbEdTbzhS?=
 =?utf-8?B?ejlFS3paNDB0aFhTS0F6VFU1YWYvUlgrcXgrVTA0MGxnTlBiMDRzR2pRaSs1?=
 =?utf-8?B?OUpLUU9xSDZJMWRWUVR0MmFYaEd0QlpJLzZCNzFqZ2g3dU45amFzRkNFTG1i?=
 =?utf-8?B?VUlnek4rSlhCSWtPcUgzZmJCSFk1eHUzbzBZazVKYUR6TTl3VHlDOVVCU0FQ?=
 =?utf-8?B?SkRGUzE5RFpKVGYrYkRSWE5rcTlPNXRRa204c0RQYkFCVmd5NW5CUTkwRDVw?=
 =?utf-8?B?eEtjd0ZySjlORzVZWHNGeHFSZDl3RkxaWm1EYWVLRHhxb25tS1ZoT1lZUDFH?=
 =?utf-8?B?OUhBTGtsSlQyTVdXVXV5MzlKaXdsekY5bUl5N1hmaXo5N1QrczlkdUtWUXNB?=
 =?utf-8?B?OHI2L2RRTU85eHZ3UzFVd3NyNVZ3OU9RdnBUOVRnMkpYVXN1bG8yOUhYVDJW?=
 =?utf-8?B?QzRtUElVRGg0a0pZTldOT1d1S25KTkNibVFNNHJBWWh2c3RBMEZvYWQ5aU1F?=
 =?utf-8?B?N0hScStxdlYwSm1ObWhDa0lQNmd0bEhtV2p3aVpjUlJ5YU1PNEhwMWhkTnZD?=
 =?utf-8?Q?WHOb3XnazG8vEuxohr8Sqk6Ia?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c93f3d65-0098-4509-51d6-08db7376eb13
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 23:17:59.2871
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zqWosAZrYmB/0aCVKX26d7aiT5Cx35hLbJLKTVW1ZBGEZW5d7Cm14em0cZNFUBjIwZJLfayVHCNhOOXb9IA5GQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8057
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/21/23 20:51, Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> Just moving code to reorder functions to later share cxl_get_chbs()
> with add_host_bridge_uport().
> 
> This makes changes in the next patch visible. No other changes at all.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/cxl/acpi.c | 90 +++++++++++++++++++++++-----------------------
>   1 file changed, 45 insertions(+), 45 deletions(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 70cd9ac73a8b..0c975ee684b0 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -327,51 +327,6 @@ __mock struct acpi_device *to_cxl_host_bridge(struct device *host,
>   	return NULL;
>   }
>   
> -/*
> - * A host bridge is a dport to a CFMWS decode and it is a uport to the
> - * dport (PCIe Root Ports) in the host bridge.
> - */
> -static int add_host_bridge_uport(struct device *match, void *arg)
> -{
> -	struct cxl_port *root_port = arg;
> -	struct device *host = root_port->dev.parent;
> -	struct acpi_device *hb = to_cxl_host_bridge(host, match);
> -	struct acpi_pci_root *pci_root;
> -	struct cxl_dport *dport;
> -	struct cxl_port *port;
> -	struct device *bridge;
> -	int rc;
> -
> -	if (!hb)
> -		return 0;
> -
> -	pci_root = acpi_pci_find_root(hb->handle);
> -	bridge = pci_root->bus->bridge;
> -	dport = cxl_find_dport_by_dev(root_port, bridge);
> -	if (!dport) {
> -		dev_dbg(host, "host bridge expected and not found\n");
> -		return 0;
> -	}
> -
> -	if (dport->rch) {
> -		dev_info(bridge, "host supports CXL (restricted)\n");
> -		return 0;
> -	}
> -
> -	rc = devm_cxl_register_pci_bus(host, bridge, pci_root->bus);
> -	if (rc)
> -		return rc;
> -
> -	port = devm_cxl_add_port(host, bridge, dport->component_reg_phys,
> -				 dport);
> -	if (IS_ERR(port))
> -		return PTR_ERR(port);
> -
> -	dev_info(bridge, "host supports CXL\n");
> -
> -	return 0;
> -}
> -
>   /* Note, @dev is used by mock_acpi_table_parse_cedt() */
>   struct cxl_chbs_context {
>   	struct device *dev;
> @@ -467,6 +422,51 @@ static int add_host_bridge_dport(struct device *match, void *arg)
>   	return 0;
>   }
>   
> +/*
> + * A host bridge is a dport to a CFMWS decode and it is a uport to the
> + * dport (PCIe Root Ports) in the host bridge.
> + */
> +static int add_host_bridge_uport(struct device *match, void *arg)
> +{
> +	struct cxl_port *root_port = arg;
> +	struct device *host = root_port->dev.parent;
> +	struct acpi_device *hb = to_cxl_host_bridge(host, match);
> +	struct acpi_pci_root *pci_root;
> +	struct cxl_dport *dport;
> +	struct cxl_port *port;
> +	struct device *bridge;
> +	int rc;
> +
> +	if (!hb)
> +		return 0;
> +
> +	pci_root = acpi_pci_find_root(hb->handle);
> +	bridge = pci_root->bus->bridge;
> +	dport = cxl_find_dport_by_dev(root_port, bridge);
> +	if (!dport) {
> +		dev_dbg(host, "host bridge expected and not found\n");
> +		return 0;
> +	}
> +
> +	if (dport->rch) {
> +		dev_info(bridge, "host supports CXL (restricted)\n");
> +		return 0;
> +	}
> +
> +	rc = devm_cxl_register_pci_bus(host, bridge, pci_root->bus);
> +	if (rc)
> +		return rc;
> +
> +	port = devm_cxl_add_port(host, bridge, dport->component_reg_phys,
> +				 dport);
> +	if (IS_ERR(port))
> +		return PTR_ERR(port);
> +
> +	dev_info(bridge, "host supports CXL\n");
> +
> +	return 0;
> +}
> +
>   static int add_root_nvdimm_bridge(struct device *match, void *data)
>   {
>   	struct cxl_decoder *cxld;