Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i5ec1447f:Fastmail
Message-ID: <349dd967fd5c201619cea0c54e3a09e933bfd377.camel@ljones.dev>
Subject: Re: [PATCH v4] ALSA: hda/realtek: Add quirks for ROG ALLY CS35l41
 audio
From:   Luke Jones <luke@ljones.dev>
To:     Andrei Matei <andreimatei1@gmail.com>, tiwai@suse.de
Cc:     linux-kernel@vger.kernel.org, perex@perex.cz,
        ruinairas1992@gmail.com, sbinding@opensource.cirrus.com,
        tiwai@suse.com
Date:   Fri, 23 Jun 2023 11:29:41 +1200
In-Reply-To: <CABWLsesOzR=Wpc1TTp3PLXAuWUfX-heUnUys7ffM=Jzn-mEbxw@mail.gmail.com>
References: <CABWLsesOzR=Wpc1TTp3PLXAuWUfX-heUnUys7ffM=Jzn-mEbxw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-06-22 at 08:35 -0400, Andrei Matei wrote:
> Hello,
> Is this patch specific to the Ally, or does it cover other Asus
> laptops discussed in this thread [1]?
>=20
> Thanks!
>=20
> [1]
> https://lore.kernel.org/lkml/b4c202b2-ab29-e2aa-b141-0c967b2c1645@opensou=
rce.cirrus.com/T/#m42ec3f3f4ceb610430587b916281b570fbb666df


It is Ally specific. Most of the laptops will require a set of similar
quirks, but for a different codec susbsystem ID.

Some others have now been submitted, if your laptop is not yet
supported please file a bug report, if it is a ROG laptop you can
submit something here https://gitlab.com/asus-linux/asusctl and I will
help plus submit any fixes upstream per usual.

Do keep in mind that the 2023 range of ASUS laptops are almost all
missing the _DSD properties for the Cirrus amp they are using, and so
you will be missing bass/midrange until a solution is agreed upon (or
you add an ssdt patch) - you also need the correct firmware tunings for
your laptop. It is very highly unlikely ASUS will add the missing
properties to a bios update for each and every one of the laptops + the
variants in the full 2023 range.

Regards,
Luke.