Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <94ad8187-e4a3-fb9c-d043-ff1e2130b0ed@intel.com>
Date:   Thu, 22 Jun 2023 17:04:24 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.11.1
Subject: Re: [PATCH v6 19/27] cxl/port: Remove Component Register base address
 from struct cxl_port
To:     Terry Bowman <terry.bowman@amd.com>, <alison.schofield@intel.com>,
        <vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <Jonathan.Cameron@huawei.com>, <linux-cxl@vger.kernel.org>
CC:     <rrichter@amd.com>, <linux-kernel@vger.kernel.org>,
        <bhelgaas@google.com>
References: <20230622035126.4130151-1-terry.bowman@amd.com>
 <20230622035126.4130151-20-terry.bowman@amd.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230622035126.4130151-20-terry.bowman@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0tmQlpVeUM1YzgydFVoeGNjVmlGZE8xbW13NWFyWkZOdFY5VHp2Z1VzcGJD?=
 =?utf-8?B?aUNDT09jOUU3Sll0blVuQy85emx1ZUlpNTN2ankrWHA5bWVYRWlBQ3NaYVJ5?=
 =?utf-8?B?ZlRrbGIrYTZUdVN5dWdBL01rb3NrNC9HWWFyT3lwdk92dlFYb0EvbjM1aXhh?=
 =?utf-8?B?aDZQNXRSSzlxLzFkYWVpbzhZZG9POHpMS3g5SllPU3hHcHNiMnlJNk1keE9M?=
 =?utf-8?B?cFlFTDhwMGp2ZGw5TG9lYWdKWXJBMkoyUG5qQ0Y1Tm5FN2pRYWVzelk3c0lV?=
 =?utf-8?B?M2pPL1J3Yk52dzVsNEt1YTRnN0NrTnRhMGxZeDlnOFhlUDVQTnVhanR6Tzgy?=
 =?utf-8?B?VDV0YStNY1Y4eXZBek42Wmo3OElmbVZFYUxlaTdzTFJrd2FOQkEzWFVTbUVR?=
 =?utf-8?B?QnRmYlF6U29oNDkwNnlaZFFpNmFzOGRFMWJ6TkViaFlYVjdSRDk5ZmpvRHRq?=
 =?utf-8?B?VG9LMDVLZnI2OXJLc1AyRE9iRXd4WXRvV3labXNtTzZtRFp6UEdhZi9Zdmx0?=
 =?utf-8?B?S01VUXl0NW4zTjJpVllTaXg1ZDVzMWxLUGQxWGtoMGo1VzhmQTA2M1AzSkdV?=
 =?utf-8?B?SGxRSEIxUDRlVUY5UEM0bG5nL3UraTM1TUNZeXIyL3JqdUJ0MmIvcFROM2Fp?=
 =?utf-8?B?WmFQZ3JBWk9Zb2ZpaG9MRU41THY2YXhOYXFCUEdqTEZ2eWJNYmpJMkM1cWJ4?=
 =?utf-8?B?M0d5WTR5TW9IYmJHMkN6WW5RVFZodit4dVlERmxKREhzN0FBMm1DTFczM1Rs?=
 =?utf-8?B?VUw2WUZ5NUFBSXRVc1BPci9MbS9abjlsazA4T1hQU21RTGdNRGNRZVV5QnRC?=
 =?utf-8?B?ZUNDMy9uUm92L3RWOFZqTVpOUWZoajhmVmtFR2hlK2VZYmpOMGRmYndaQ2dK?=
 =?utf-8?B?THVMRTVPeXBVSHFDei9VM01VOG5VQU8ySGJtY290ODJlNmF2TDlqSUZ6d09F?=
 =?utf-8?B?V1NybWNNTDdMTGhSTUhoQjZlMjVIc2RQbzJ6b0ZTd0NBei9oWVVXZW85UEkz?=
 =?utf-8?B?VXJSWGZzQmdPV2Y1ODZZRVNtMm5KSnBka1Z4MUNUdXMzK2lGcnJCZnczM3RK?=
 =?utf-8?B?VVJlSnlwRk1EV3NPSUJCMnd1anh4TDlVU1dVdVBSMXBhbzVuZWwyU3JlSTk2?=
 =?utf-8?B?a1JrUHY5Rk9WZnlWeVpEQjdmNzR5aDBCTW15YTV3TWR3LzE2VWFLNy84N2dV?=
 =?utf-8?B?TlFNNXhrSnc5a1FoTWNPa1FQUFhRQkxIcUhQUHFycFJhWlhJVW9kYW1xSWZQ?=
 =?utf-8?B?M0lUeWYvWEM0YkdXa3NIdVBRdlZOaVdDQ1owRGhPL0lDak5XQkR6NVJhZXlm?=
 =?utf-8?B?Znd1NExpeUtOd3p5ZXFuNkRkV21yMHh0Ymkwa1JiTGd0L3hYS0xQblphUDNG?=
 =?utf-8?B?b01ERStUcTdaSGNqdHI2dUd1aVZQV1ZvN1ZoSHVOVU1sZG96WlRaQXpqN3JX?=
 =?utf-8?B?dmxLQk85Q2VRMGF4Q3NiTkUyUUNzMFJLaW0wMUVEWWxyTW1xVFBOK1pnZzJh?=
 =?utf-8?B?dW11cFAraDZWZXJnVXp0MEE2N21DcTA3Vm9iZXZIc1BFTlladlc1R2RtSXFp?=
 =?utf-8?B?QjRBa2tjRXlGNmkwaWxvSXhnVmxMcUsxWlloS1d1cUV1a1F2QlVpL3FvODYv?=
 =?utf-8?B?V1ZlVDhJN2RmQi9acnUyUFBKYXBXOCtQdW9tV1ZrUXBSelJTb3VYQTJiV0Vj?=
 =?utf-8?B?RnU2V1dPNkkrOGQvVUhPS0h4NWY4VGk1VTFYdUlKeE8yOFhEZGxjTWJGV1hL?=
 =?utf-8?B?ZVBudkxZbDhrcEdXNER2Z3VvdzhyajdHeWJEUy80QkhjZjRGM1pWeW8xc052?=
 =?utf-8?B?UG9PakdKSjRFSXpoTlRLUzVHK3dmWG5tQXYwV2NzNnZsZEx2dUh3dGpHNGFZ?=
 =?utf-8?B?dXg1OFBSaTNORm1lTE5XUU9TMU9tRDFydm5WRlZYK0pUSTFIcUlhdkM3T0hl?=
 =?utf-8?B?b2Y3bnN4NjJVWFl6djNXam1aN3FwS0kzNCtHakVjYklFdWNvQnVXVDdFSm9r?=
 =?utf-8?B?aDVxOHJKbjF3U2VKUCtSQzBuV0dWejgyV2FGKzJpeW0xSzByUmJ2UGZsc1FJ?=
 =?utf-8?B?ZHNZWldOcnpQNGJEVndJN3pMNmtpT3NadTFSUFVWdC9jZnoxTmw4ZkxYU29G?=
 =?utf-8?Q?yXh25M/759JjLE11FoY6iYloE?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4ff46d4-1758-4648-6e48-08db737d694d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 00:04:27.9563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iELJbRZPk8kUk7233iilQ9jlmcbimuhPoOlXp//+2fYfrDwl7b91M4hIUR6L7QmkbctKA8qWliPW4dwQvqLcIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6654
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/21/23 20:51, Terry Bowman wrote:
> From: Robert Richter <rrichter@amd.com>
> 
> The Component Register base address @component_reg_phys is no longer
> used after the rework of the Component Register setup which now uses
> struct member @comp_map instead. Remove the base address.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Signed-off-by: Terry Bowman <terry.bowman@amd.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   drivers/cxl/core/port.c | 4 +---
>   drivers/cxl/cxl.h       | 2 --
>   2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 45fe7d89f7f3..cfae8307de90 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -616,7 +616,6 @@ static int devm_cxl_link_parent_dport(struct device *host,
>   static struct lock_class_key cxl_port_key;
>   
>   static struct cxl_port *cxl_port_alloc(struct device *uport_dev,
> -				       resource_size_t component_reg_phys,
>   				       struct cxl_dport *parent_dport)
>   {
>   	struct cxl_port *port;
> @@ -667,7 +666,6 @@ static struct cxl_port *cxl_port_alloc(struct device *uport_dev,
>   	} else
>   		dev->parent = uport_dev;
>   
> -	port->component_reg_phys = component_reg_phys;
>   	ida_init(&port->decoder_ida);
>   	port->hdm_end = -1;
>   	port->commit_end = -1;
> @@ -726,7 +724,7 @@ static struct cxl_port *__devm_cxl_add_port(struct device *host,
>   	struct device *dev;
>   	int rc;
>   
> -	port = cxl_port_alloc(uport_dev, component_reg_phys, parent_dport);
> +	port = cxl_port_alloc(uport_dev, parent_dport);
>   	if (IS_ERR(port))
>   		return port;
>   
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index b1adca9b27ba..9f46a4e1fbec 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -551,7 +551,6 @@ struct cxl_dax_region {
>    * @nr_dports: number of entries in @dports
>    * @hdm_end: track last allocated HDM decoder instance for allocation ordering
>    * @commit_end: cursor to track highest committed decoder for commit ordering
> - * @component_reg_phys: component register capability base address (optional)
>    * @dead: last ep has been removed, force port re-creation
>    * @depth: How deep this port is relative to the root. depth 0 is the root.
>    * @cdat: Cached CDAT data
> @@ -571,7 +570,6 @@ struct cxl_port {
>   	int nr_dports;
>   	int hdm_end;
>   	int commit_end;
> -	resource_size_t component_reg_phys;
>   	bool dead;
>   	unsigned int depth;
>   	struct cxl_cdat {