Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chang, Junxiao" <junxiao.chang@intel.com>
To:     Andrew Halaney <ahalaney@redhat.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: RE: [PATCH net] net: stmmac: fix double serdes powerdown
Thread-Topic: [PATCH net] net: stmmac: fix double serdes powerdown
Thread-Index: AQHZpEgvZv2rokUmVk+XS3HYZ85FKK+XLV2AgABWhrA=
Date:   Fri, 23 Jun 2023 00:05:32 +0000
Message-ID: <BN9PR11MB5370CEFCA9D23A48015AF78CEC23A@BN9PR11MB5370.namprd11.prod.outlook.com>
References: <20230621135537.376649-1-brgl@bgdev.pl>
 <20230622185425.vfewm2qgxqpndfyf@halaney-x13s>
In-Reply-To: <20230622185425.vfewm2qgxqpndfyf@halaney-x13s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AazT9l7lV25YIRn6N7FBhv5Sv7gPFDA0LgZMN43iNAusaZvxAg6OCAFewBvV?=
 =?us-ascii?Q?SlufJPAOLVdozapIPQPyb776YHs4oUubx6690GH0skNd7sFi84pBwfJQ7k0G?=
 =?us-ascii?Q?xaalWKBlUJ1POHQB+rbvLpVGPQWVmMvSTb08AZHMa1W1qnefIS9wuvST+s/R?=
 =?us-ascii?Q?0kWBENyg4EGHP4HHZ3X4omq0ieiYZZZq/uSCkN2V0bHgc1Z1nB8sj5qqIxvN?=
 =?us-ascii?Q?3B7UHQGksB305D1rAcomIjsptRGnaUpcpYgSAmFwOSJTIgcO24zUDos7RwHT?=
 =?us-ascii?Q?AUf1wOalQ0fKEK0fFGGF+fzZLSlqFo2DGREjm2uYbqMcOAdobSMV7PhSXA/j?=
 =?us-ascii?Q?99iahQhy23925CP+o5VHdT2et5Ce3tritDaUVJCDk9S/yID3gjudORTfIGPA?=
 =?us-ascii?Q?LUoX5+IjCfZlVayIJ/D9vc/Qul7OhprEv3tHI1WaEFjEusJt+N833PgyQfar?=
 =?us-ascii?Q?Swl0HYwjKbJsYWUfwTuZ7CkkemAXvzQSMs0Be5mOpDtgbnZ5Erh8knmaTSLp?=
 =?us-ascii?Q?yX87JWbTmw2Vk5KshKQEQ0r4xFdShs/1MYEv/jCjcSwWZ9JkimOC5vqPXpps?=
 =?us-ascii?Q?d1zTNPARK5PdinbuYlDKk0rlZ4X+mFZvJHMvgp2FxWFBfy3TI3pZiah/Fn7k?=
 =?us-ascii?Q?MXyZSq0evCnmvvn7dSjr41F474FGQJHpsKvgZGOyfUEqQHTw3IXRIPCmTIfa?=
 =?us-ascii?Q?23/821wR+uZW3tw6uxXb99jFz0H3pULPrqYZBUuK4aWEEYt8beM0Rshu1PBO?=
 =?us-ascii?Q?m1cFALN36m2nyOPOCurDwK9bwE+4Kzz1RhJlkPSG2T+xfWayLdLOvJPOvY87?=
 =?us-ascii?Q?vefD92LOYRitjebms5K3jbFwRxYWnaoSd1CRGgTxuHhL7nm+d9eAr0sDvVFx?=
 =?us-ascii?Q?ZbiGNPBgqDaUS4Z7ssZe7fQAHOLioRlLAXJIROBVlYcGpCEf5BvyHasAyovX?=
 =?us-ascii?Q?6cJUtm6+gpi/xSJ+ck/zRaYPTO96bZFQzckTxV9HejxWc1dzDVo7WxLvf8qg?=
 =?us-ascii?Q?HUsBqBjWRDk0YCfXhDep3jfwcbROZnsXPgoMkhPZYCnD5b5oaRIf2jDsnoYP?=
 =?us-ascii?Q?c7RG+SZvs3CDPeKcSf2ajES7MVAp2SCibAhFUY1oUSVQO8t4A/z/OIWCUooK?=
 =?us-ascii?Q?MheiZ9JNdOhlLsFbYjl97HBRzIBg5E5U3keBZjY384PsAXkBJZ9RDWhpDQf2?=
 =?us-ascii?Q?jxhW8EKkuikocis4Bq2jiEDheQnTNNXqpvVs65j3SLzMjNwcbM1jhsTjxw5E?=
 =?us-ascii?Q?jsXsAX3hYEyi+2NHCBG2V8vHQ9zOJdJt9ltIDmNOJgmwVYdrmtWAOtUPWB/N?=
 =?us-ascii?Q?OfYWlVNAys32UpDvhgIKtBBZ3YQ278HEOGnBdWSwI7HjL0KPJfk/gPYEHm+D?=
 =?us-ascii?Q?9FIWyXoTRyFqy6U81mJvksq//NyPjuq8L/52M6pewiF+bhxKLnqMYKFqQDTy?=
 =?us-ascii?Q?MhJppWMg/EBl9tSzwr4Xt3WYzBSVGCJCeFh4Oo3AzZGcS1X5OmvcTbtWL152?=
 =?us-ascii?Q?xBJOdg/CtJZUpZZ+X1nZV6POe0s7tHAgbcFFTJKdjK2DQCG3IBK/AtpHPaxj?=
 =?us-ascii?Q?eZBxiXfwjo9RiUe9e0H0UQ1BXDcJ1rOk/r10FPtN?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5370.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c779af50-d811-4495-40dd-08db737d8ff8
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2023 00:05:32.6217
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BrLhdMY1/XBnCR93xr0BCTL3IqACv51DgBKuZhuBQccsFQJMCSYZBHA/H2HXNJLm320ZD98IeG8hvKmOTRprZw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4922
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Acked-by: Junxiao Chang <junxiao.chang@intel.com>

-----Original Message-----
From: Andrew Halaney <ahalaney@redhat.com>=20
Sent: Friday, June 23, 2023 2:54 AM
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue <alexandr=
e.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>; David S . Miller =
<davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <=
kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin <mcoquel=
in.stm32@gmail.com>; Chang, Junxiao <junxiao.chang@intel.com>; netdev@vger.=
kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@list=
s.infradead.org; linux-kernel@vger.kernel.org; Bartosz Golaszewski <bartosz=
.golaszewski@linaro.org>
Subject: Re: [PATCH net] net: stmmac: fix double serdes powerdown

On Wed, Jun 21, 2023 at 03:55:37PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>=20
> Commit 49725ffc15fc ("net: stmmac: power up/down serdes in
> stmmac_open/release") correctly added a call to the serdes_powerdown()=20
> callback to stmmac_release() but did not remove the one from
> stmmac_remove() which leads to a doubled call to serdes_powerdown().
>=20
> This can lead to all kinds of problems: in the case of the qcom ethqos=20
> driver, it caused an unbalanced regulator disable splat.
>=20
> Fixes: 49725ffc15fc ("net: stmmac: power up/down serdes in=20
> stmmac_open/release")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Tested-by: Andrew Halaney <ahalaney@redhat.com>

> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 ------
>  1 file changed, 6 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c=20
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 10e8a5606ba6..4727f7be4f86 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -7461,12 +7461,6 @@ void stmmac_dvr_remove(struct device *dev)
>  	netif_carrier_off(ndev);
>  	unregister_netdev(ndev);
> =20
> -	/* Serdes power down needs to happen after VLAN filter
> -	 * is deleted that is triggered by unregister_netdev().
> -	 */
> -	if (priv->plat->serdes_powerdown)
> -		priv->plat->serdes_powerdown(ndev, priv->plat->bsp_priv);
> -
>  #ifdef CONFIG_DEBUG_FS
>  	stmmac_exit_fs(ndev);
>  #endif
> --
> 2.39.2
>=20