Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa298357-0b3c-5534-0619-1bd8911846f7@ni.com>
Date:   Thu, 22 Jun 2023 21:03:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFC PATCH] pps: Increase PPS_MAX_SOURCES value.
Content-Language: en-US
To:     Rodolfo Giometti <giometti@enneenne.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brenda Streiff <brenda.streiff@ni.com>
References: <20230605203147.694716-1-charlie.johnston@ni.com>
 <fe435e68-8e05-9078-0fe6-63ef7cce2fc9@enneenne.com>
 <b794bccc-0233-4d78-df6f-bf7c688a7d7d@ni.com>
 <70ce864c-ca13-4fc4-fcb5-9b7f91579a90@enneenne.com>
 <38f38f66-0fd5-4e6c-4839-8272cef77046@ni.com>
 <5aff32cf-74ea-b632-9d4d-a01ca0d31821@enneenne.com>
 <41affdf0-edba-6202-4e76-fd969da6497b@ni.com>
 <c770492b-dfee-c38e-f15a-aad382caec25@enneenne.com>
From:   Charlie Johnston <charlie.johnston@ni.com>
In-Reply-To: <c770492b-dfee-c38e-f15a-aad382caec25@enneenne.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWVKNFB2VzlnUGYyMDMwV0hZWVZ2RktjRFZIM1ZTcVl3TXBFSy9KRWdnanZ3?=
 =?utf-8?B?eXVaRzhrUFFielVIUTl6cWtZNXRzZFN4a3h1dUEybXpaMjRiaWNoRCt5VDNU?=
 =?utf-8?B?Z1JiVFoxMDU3d0Zuais3R1BPYzlyd0FBYVp2VlJHSjB0OVNSQzd5Y0tyb1Bj?=
 =?utf-8?B?c0F2SlB0V2FBR0VNYTJXUFEzN203SnB1RXRzejdBWEQ1YXNFci9GSkl1NDZO?=
 =?utf-8?B?dnhoMWo5TTRiUjBWNjA2RENxR0lnVDQ5b2dQUU1nTXJmdEwwYnpxMEMzYndP?=
 =?utf-8?B?RG1DMzUybVQzSTMyamhPbzdnL0w1ZEVFdXZiUXZJQzIyaUo4eFZsS2pDWkY5?=
 =?utf-8?B?SUd2a09aWDJjbkx4NnlvQzhuYS9aN2pQYTBrN2lsVmlUbndjRXpMWVVWWFNn?=
 =?utf-8?B?Z1N2NkZtNTE3cXlRRU9RODBRQUlhL2ZXbDF6ckFuUjhCN2ZKbUdPa0M2Qk9Z?=
 =?utf-8?B?U1BML0F1clEyRVRjdGh5YUhCc0laVW5xOGVINXU3SGVPL0xwYUQrVERMK0tv?=
 =?utf-8?B?YlROQlljcVZ1OEp4YVpuWU9JQVhsL0lmNXB6VGZwMWNMb1FiYXZmSXY4anJD?=
 =?utf-8?B?NENqbHZERHJzRGg5ak1NbHNjTG1TUnNXWnRkSzhJdTVJTER1dXAvU0tRNFc4?=
 =?utf-8?B?b1VDTGR5UFBFWFdKMW5CbndlWkFUNlBzblg2MGUwcXcrczM3aVNTQVRaTE4r?=
 =?utf-8?B?WDhBSC9wTTNGZWFpRlFRbzc0UmovRkNjWDhYRU5FbTl2WWpkR1NUMXJVczU4?=
 =?utf-8?B?YVBsM1VrdExoQW9OTjg4a2RqdmNxYTZVczl5RTdsRzgyZWtkY0cvbW56SFMx?=
 =?utf-8?B?VmxGbnhrTk5YSHJlNFg3LzZ4WUp1VkxHcjBhVXBIUVdmaEQ2M3lITlZPSVZr?=
 =?utf-8?B?Q2x2NW9wc3RMNjgreWNsSTAwVVM3Z3RDb2gvOU5pMXBXRG1jcFhqZ2hxWFNp?=
 =?utf-8?B?RGtCNU41c2cwMXVZdnZENlA4eGJYV2pHd3hQcXozM2djRnFEVVlhVlo0ZWIw?=
 =?utf-8?B?YUJJR25OZnFsLzF3bDgzUmhpMmR2T05YZkZmKysvZDJPVWlCQlZyZlJIQXBT?=
 =?utf-8?B?eTlpOVpzM1ZodDgwWG03MkRXd0FETHVodVNKZVR3eW14YUthNEZQb2tYakU4?=
 =?utf-8?B?cTByKzJGdnY4VXdNODZ0YmwwUXRxek1NYS9rT3RJRFFmRTZRVTEwYkVkd3Z4?=
 =?utf-8?B?SGNQbFdsKzNLc0dJQmJrMkprMExSL0pHT3kxQlVWcjFhSDBacHRBcnQrem9t?=
 =?utf-8?B?UGZ5MlJack5iYjdWQjFMUkN2R2dlMVNEekFTbEg4SHlPcTFqSSsrWEU4UGh2?=
 =?utf-8?B?OW1PSXQ1RFE3M0tyMThGSzB5L2RtTWtoR2F1aUY5RW1UbTFQMGl4V01Vb2ZV?=
 =?utf-8?B?VEJwWGpoT3dvVjJMU0ZaS2dtZDB2QTYrUXZTRlhSeEdnQUtldDkzV1R4K0ZQ?=
 =?utf-8?B?M0tieEtVelkyMjJtZVd2WGtncnNQOXNiK0tiaUoyVjFwRURYMlV5ZDliK1lJ?=
 =?utf-8?B?VTh6eUt2UHB6bStBNkpvZDFmUFdnSGlKRkx5alZHaHVhcmRtZ1VkVTFTdlIx?=
 =?utf-8?B?cjZIcWk2Tk9nSlQrS2wxUWRyRUlac01WTnJYMXh5YnBrNW83aVl0MEIxQ3pn?=
 =?utf-8?B?Q3IxeW5wZVZqM2JyUWlOQWNUZUFEd1lYdk9DOUwzaE4wc2JKSitNMUkzV29z?=
 =?utf-8?B?KzZ5Wm9RQ1JuZTQ0OTY2WGJOVnh4OFB2TjdFN0hCRC9TKy9oSWNya0pMNTFi?=
 =?utf-8?B?MHluekNCbUtwSHB6WE5WQUVWbkFIVGNBVnBQdjBNMWo2ZjN3Y0tVbTdGWENt?=
 =?utf-8?B?YnBJeU9CaGx2Q3I4cUxGbGthdDRQa0hCTERHeXlQYUNSd29uUFlrNXNnR2tB?=
 =?utf-8?B?ektBa3Y3VSthR3Vnd2x0OXpiTFdKa1lJVG1INnp2SlBGSWRaRVRkL2NjZ0lB?=
 =?utf-8?B?aG5nQ0t5QWdnWE5DbXRQdGdrVDZwQmo2bXN2YW9XanA4bmxsK1BBaCtJNGp1?=
 =?utf-8?B?UTUxQXIzTkJxNHJFc0pzdUVwZ3pMTHF5Q0dBSTQ3MUpwaW0vWkJTUUcrSHdQ?=
 =?utf-8?B?byt4Q001WWNXc0x5UkJiT2JGczdwWHFrQUdmaWhaYnNLR1g5RlFqYWI4TUZi?=
 =?utf-8?B?eCs1Nmg1NTVnTHh3dVoyTjhMSmxWNlNkL3lnVWZFaDM4YUgrOU9VQ1dQK0tl?=
 =?utf-8?B?Z0E9PQ==?=
X-OriginatorOrg: ni.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea42ca2c-9762-42fe-0356-08db738e0e8a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR04MB4870.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 02:03:38.0868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 87ba1f9a-44cd-43a6-b008-6fdb45a5204e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FgpdXdVmGjhOOAIS2ov+I1H9S/75H2r/9D4AbKJTS6YQPtJXECPI4WKtzu0HZgTsfgXb6+fpb288dkkplcRs8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7328
X-Proofpoint-GUID: D6EZSE5LNbfU6FvfoxdZ-1mRVPW-vi6_
X-Proofpoint-ORIG-GUID: D6EZSE5LNbfU6FvfoxdZ-1mRVPW-vi6_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-22_18,2023-06-22_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30
 priorityscore=1501 malwarescore=0 clxscore=1011 lowpriorityscore=0
 phishscore=0 impostorscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=30
 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306230015
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/21/23 10:31, Rodolfo Giometti wrote:
> On 20/06/23 22:42, Charlie Johnston wrote:
>> I've resubmitted the patch with just PPS_MAX_SOURCES = MINORMASK. The system which hits the limit and causes the problem is currently available for testing.
>>
>> Is there anything you'd like me to try running? Or just confirm the limit change works?
> 
> Sorry for the delay (i was very busy in these days)! Please, test the attached 
> two patches.
> 
> Ciao,
> 
> Rodolfo
> 

Had some time to test today. Everything I tried appeared to work and the message log indicated sources were available for each port.

[    1.853052] pps_core: LinuxPPS API ver. 1 registered
[    2.749945] pps pps0: new PPS source ptp0
[    2.790179] pps pps1: new PPS source ptp1
[    2.818900] pps pps2: new PPS source ptp3
...
[    6.326282] pps pps26: new PPS source ptp27
[    6.354941] pps pps27: new PPS source ptp28
[    6.383575] pps pps28: new PPS source ptp29

Thanks for the quick turnaround on the patches!
Charlie