Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 07:35:51 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Choong Yong Liang <yong.liang.choong@linux.intel.com>,
        Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>,
        David E Box <david.e.box@intel.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Wong Vee Khee <veekhee@apple.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Revanth Kumar Uppala <ruppala@nvidia.com>,
        Shenwei Wang <shenwei.wang@nxp.com>,
        Andrey Konovalov <andrey.konovalov@linaro.org>,
        Jochen Henneberg <jh@henneberg-systemdesign.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org,
        platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
        bpf@vger.kernel.org, Voon Wei Feng <weifeng.voon@intel.com>,
        "Tan, Tee Min" <tee.min.tan@linux.intel.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Lai Peter Jun Ann <jun.ann.lai@intel.com>
Subject: Re: [PATCH net-next 3/6] net: phy: update in-band AN mode when
 changing interface by PHY driver
Message-ID: <ZJUvNz7xOV8kCOgP@corigine.com>
References: <20230622041905.629430-1-yong.liang.choong@linux.intel.com>
 <20230622041905.629430-4-yong.liang.choong@linux.intel.com>
 <ZJReJ2yxqKGQx1BU@corigine.com>
 <ZJRjd0oqj95U0nHc@shell.armlinux.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZJRjd0oqj95U0nHc@shell.armlinux.org.uk>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bZn4jy0oQOUwGRbY8LuQSSx7iK22lpGwEA6Ro0pvUxd8/ytUYTfRRxXDquhR?=
 =?us-ascii?Q?Yyb+6P7D9g2RoB9q9RPYWNcbVFjZGnZo3mnpmnyR1czdd72jF4+hnlNc+JT+?=
 =?us-ascii?Q?AE4Ztm39LuSyKRlHpHCgffJJEIR4mFAmiTNsmdqibSeB+FQRgJcF1D3jYFFR?=
 =?us-ascii?Q?LaYygLrAZXU2tXdtYG6GNvKCJz4SBdUhlNEmTa2GxN7+NYSJ27ePtgDCh37h?=
 =?us-ascii?Q?+WnflBPqoN+W+jD5lOEpOPBE/SRXWttrZ/yycbq90fB4CuQ5QFJ3+E263H9U?=
 =?us-ascii?Q?WfCctNC4lMFE2lZKHUb+YJUjqPd1sfkIcNRCbrF13r7hT9JKdsyrYjNQyJaE?=
 =?us-ascii?Q?d/d3n9UvyzFdvB5Nf2ZBFG430Dt90dnGTM/zRMkVxjRtgq+wqEbWZAybFGsP?=
 =?us-ascii?Q?AJG6CFvjHKagS/D50KofWebDQWUmbXg55YUe75XUguUZGYZnhMn2WprZiJrX?=
 =?us-ascii?Q?0aIPgL/jHTc5KnoBWfhmwI2FMwHs077p2W4ozFJEkTpZaMPrjqne3Ek29AeD?=
 =?us-ascii?Q?uGOvM37VpXjvBtvXGo3XNdYefXyY1ltJNIz+5v247MVt4SOjd3AJsEQ2BVme?=
 =?us-ascii?Q?PJ5R61GnHFRZUjyXMwMYSSr8ABy21o+g/lyrrrRIR7SSOYHSgkCQ4YFhxVhH?=
 =?us-ascii?Q?944txhmqHACgvn4NcdBCxlCi867NYd0s5ZpBCSoY8MrFYplQTirB+vM/NJa9?=
 =?us-ascii?Q?2aWqvz7l4bbno1m4Cciuknxd37egbx7740xzSdmz61dXBxPpxcAEiKf2BNmk?=
 =?us-ascii?Q?4Ak122mci8kWQPJfNMi4gxhGC8dUK2LX5QGioGpZBmA9bywILIF6e4FIYDh+?=
 =?us-ascii?Q?N0S7zGxaJROrnbWohSqO0M5LSyhSr/F26ntAs/K+uPURgJtYHDGC76qrblcd?=
 =?us-ascii?Q?QZxQmYKfeZz9vrv9Sdlsofpm6hhKpDtQ7dLqLWrlpZKotCFQcOX9HTJvACWi?=
 =?us-ascii?Q?t7a25wuQ1uIbFuvyQAZ7Z55PEmpNlepB5fhRkX7lkjm4MlhPeDnQu625LRTb?=
 =?us-ascii?Q?FwV9F0cj4HTK45UE4tasGZfDzrAI71yuCmT0P9A6Hb9bD/pKaFwk2pI47bfm?=
 =?us-ascii?Q?W5GRGTozOx+i/Plj4uBaoLPftSLvgoAsmEBF3yMv43NJGEUzh5M4JK3cw2uS?=
 =?us-ascii?Q?OaafqezJfGpLhlFbFvl3vVFmq9mzzkKMogHZ0ZfnHaGInZQ3YT/agatGVQ5O?=
 =?us-ascii?Q?cRUgoxwN/S2hNadTfEJkXem4ff1gx+1ySn87t4HVLo7G8Tnt4Va0uPUyo2wF?=
 =?us-ascii?Q?o3lUYKsxtJl0j26gNbiaymlOmgxLM+6ahcIoE9gMOOWwRGOD4Xih/zuTwzej?=
 =?us-ascii?Q?DCTOX1C7SjbGFhes7ebK+WcDvjcvjuk0iguD+spD09pyUQr47QSJngwEc/t5?=
 =?us-ascii?Q?DutNMsxJ9sVALP09gqWeeEyYNMAfBLw8PDp+cVkYVNj4yhBsOU8mwOhc82I7?=
 =?us-ascii?Q?/ZM8hVOaAWSmzoJ8ejPITpCq0ubSyk70k+SJi/Plnu3Ka3KeMRDVIWboKAXt?=
 =?us-ascii?Q?raNocpHHpCQSQnfbNHdRavVXn1nOy+oUJ+swT3zqfZCnKMHKoQNVfcUt49nI?=
 =?us-ascii?Q?f8+gVAxLYOjxt9tDgi8DrUHcwq6D33m9Cs7zvMACDK/1tXsHXqEk7V0qJ0Sq?=
 =?us-ascii?Q?wM+o6BBAzlkHtlIc57d7sIHpu4MkYqDKmKzuqmxtX4IODaXAv8F7TAKorPoQ?=
 =?us-ascii?Q?kraCyg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fae67e4c-49ce-470c-3043-08db73abbbde
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 05:36:03.4226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MRg0Xp1Gs6cyLsftAAoxWmIHl8zzqxxQ05EA5Oe9y5sd4RRH+TS6t6vwMKyQIFIwW+FKWA6PRRY10V5KYLN5IJUPrAJoLMpPmbag6JQ4Yao=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR13MB6394
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 22, 2023 at 04:06:31PM +0100, Russell King (Oracle) wrote:
> On Thu, Jun 22, 2023 at 04:43:51PM +0200, Simon Horman wrote:
> > On Thu, Jun 22, 2023 at 12:19:02PM +0800, Choong Yong Liang wrote:
> > > From: "Tan, Tee Min" <tee.min.tan@linux.intel.com>
> > > 
> > > Add cur_link_an_mode into phy_device struct for PHY drivers to
> > > communicate the in-band AN mode setting with phylink framework.
> > > 
> > > As there is a mechanism in PHY drivers to switch the PHY interface
> > > between SGMII and 2500BaseX according to link speed. In this case,
> > > the in-band AN mode should be switching based on the PHY interface
> > > as well, if the PHY interface has been changed/updated by PHY driver.
> > > 
> > > For e.g., disable in-band AN in 2500BaseX mode, or enable in-band AN
> > > back for SGMII mode (10/100/1000Mbps).
> > > 
> > > Signed-off-by: Tan, Tee Min <tee.min.tan@linux.intel.com>
> > > Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com>
> > 
> > ...
> > 
> > > diff --git a/include/linux/phy.h b/include/linux/phy.h
> > > index 11c1e91563d4..c685b526e307 100644
> > > --- a/include/linux/phy.h
> > > +++ b/include/linux/phy.h
> > > @@ -756,6 +756,8 @@ struct phy_device {
> > >  	/* MACsec management functions */
> > >  	const struct macsec_ops *macsec_ops;
> > >  #endif
> > > +	/* For communicate the AN mode setting with phylink framework. */
> > > +	u8 cur_link_an_mode;
> > >  };
> > 
> > Hi Choong Yong Liang,
> > 
> > Please consider adding cur_link_an_mode to the kernel doc
> > for struct phy_device - which is above the definition of struct phy_device.
> 
> This looks like it's grabbing something from phylink and stuffing it
> into phylib.  However, I have no idea, because I don't seem to have
> received the original patches. I'm guessing the reason is:
> 
> 2023-06-22 05:21:24 1qCBoy-0003ji-G9 H=mga03.intel.com
> [134.134.136.65]:57703 I=[78.32.30.218]:25
> X=TLS1.2:ECDHE_SECP521R1__RSA_SHA512__AES_256_GCM:256
> F=<yong.liang.choong@linux.intel.com> rejected after DATA: unqualified
> address not permitted: failing address in "Cc:" header is: Tan
> 
> Which I suspect came from:
> 
> 	Tan, Tee Min <tee.min.tan@linux.intel.com>
> 
> and someone doesn't realise that a "," in the display-name part of
> an address *must* be quoted, otherwise "," is taken to be a separator
> in the address list.
> 
> Consequently, it has now become:
> 
> 	Tan@web.codeaurora.org, Tee Min <tee.min.tan@linux.intel.com>,
> 
> It should have been:
> 
> 	"Tan, Tee Min" <tee.min.tan@linux.intel.com>
> 
> with the double-quotes.
> 
> Please do not review this series further, but instead, please can the
> author repost it forthwith with correct conformant headers so that a
> proper review can be undertaken by all?

Hi Russell,

Sorry for not noticing this myself.
I agree that we should wait for a properly formed post as you suggest.