Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <239e7171-1d29-0208-ca6c-abc85ccbe0e9@kernel.org>
Date:   Fri, 23 Jun 2023 00:36:43 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 00/12] New Crypto service commands
Content-Language: en-US
To:     tien.sung.ang@intel.com
Cc:     linux-kernel@vger.kernel.org
References: <20230623032029.1755017-1-tien.sung.ang@intel.com>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <20230623032029.1755017-1-tien.sung.ang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/22/23 22:20, tien.sung.ang@intel.com wrote:
> From: Ang Tien Sung <tien.sung.ang@intel.com>
> 
> hi,
> This patch set comprises updates to the svc driver to add new crypto
> services for AES encryption/decryption, SHA2 digest generation, SHA2
> MAC verification, ECDSA hash signing, ECDSA SHA2 data signing, ECDSA
> hash signature verification, ECDSA SHA2 data signature verification
> crypto key management and lastly ECDSA public key retrieval.
> The additions of the commands are all standard entries to svc driver
> with minimal logic.
> 

I guess I'll ask the same question, who's the consumer for these?


> Ang Tien Sung (12):
>    firmware: stratix10-svc: support open & close crypto session
>    firmware: stratix10-svc: crypto key management
>    firmware: stratix10-svc: AES encrypt and decrypt
>    firmware: stratix10-svc: increase msg arg size
>    firmware: stratix10-svc: SHA-2 digest
>    firmware: stratix10-svc: HMAC SHA2 verify
>    firmware: stratix10-svc: ECDSA Hash signing
>    firmware: stratix10-svc: ECDSA SHA2 data signing
>    firmware: stratix10-svc: hash signature verification
>    firmware: stratix10-svc: SHA2 signature verification
>    firmware: stratix10-svc: public key request
>    firmware: stratix10-svc: ECDH request
> 
>   drivers/firmware/stratix10-svc.c              | 309 +++++++-
>   include/linux/firmware/intel/stratix10-smc.h  | 708 ++++++++++++++++++
>   .../firmware/intel/stratix10-svc-client.h     |  86 ++-
>   3 files changed, 1100 insertions(+), 3 deletions(-)
>