Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp11998890rwd; Thu, 22 Jun 2023 23:19:51 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6QaxN+Sx+qitGjq3bQUXzNt/BaW6E2AcgPBqYz2r72siEGulmBwq0SrrFJd1GUep3K3m76 X-Received: by 2002:a17:90a:207:b0:25e:aaff:400c with SMTP id c7-20020a17090a020700b0025eaaff400cmr13433281pjc.20.1687501191211; Thu, 22 Jun 2023 23:19:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687501191; cv=none; d=google.com; s=arc-20160816; b=qswQSbqMBUoTu2wf0YOjuCiTd9coWmPHegrf3pKVAG8FUGFfHSqJ7WId0o27C1VJSz CzlNEOg25W2HqdvfHWBdgET/0sqsyIO3aqtrWsTWVWTV0VK1Dmr9of4vameTiU3zqq75 VJXGOHiNdzT82bXyBIgo+NBDOOeV87TZsAApKLYEfJExkR/w/5mtrMwrZ1GXBW2Mr+73 UBI/8ZdZCx3PiLpJI5V04K1P3Mo+fddNRb78gAsBt0JdxdwRp5Li2+XO0c/FUA68ysdI ruWhhIUkkj1vLdjTMxCwkfGerrenINr3ptNftETKZY7cJQTJJn5R/F4HdHAhbSaZrNUa 8bXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:mime-version:message-id:date :dkim-signature; bh=xG7S9EdmjVVI6rCoFSNq3FA5xO2SVwNz93G04XmDDpE=; fh=kPuekZifW1q9v//gNq3XvWdrCm4hziXwTv2ml8INx6E=; b=Q5nmfljGDEd7eSvBCcW2Xa+HKxS2LDvSysBHT1OK9OvdzhNudgVDUSzjK6EU5JskYz I/cwxxMnm5rsMh2FTEGONhMDsxFVWjXQM4p+OkXcOw+iyT4w8UHF4+7U+4wWo8RMLmvp Om9De2z4IEi8+0esIsLSQ8KtthW5KAyXQ48Hwp7E3w/oJkuQuDXj73WWvz6P2uLFDS/U DoyF6GvhGrJ5A1CcAGkx4loERP1dD2Q6Lc+i2kEw1mNN2101xcCZz+xIxj7PcjoJtmPx e7UdGPy5k7u0kvhlYLLI6OuOXULs5nYOTiQS88VjACsOD9m7J3TVlE5KrbNaVnLP2Uje FGmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=68Z680TG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ml16-20020a17090b361000b0025bd695c39dsi1230883pjb.66.2023.06.22.23.19.37; Thu, 22 Jun 2023 23:19:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=68Z680TG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231316AbjFWFp3 (ORCPT + 99 others); Fri, 23 Jun 2023 01:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbjFWFp1 (ORCPT ); Fri, 23 Jun 2023 01:45:27 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CA81BF7 for ; Thu, 22 Jun 2023 22:45:26 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-bb2202e0108so410582276.1 for ; Thu, 22 Jun 2023 22:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687499125; x=1690091125; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=xG7S9EdmjVVI6rCoFSNq3FA5xO2SVwNz93G04XmDDpE=; b=68Z680TG3vm/v6niWksrjQzjzAkc3G3TDkGOKUG0WoHhGqC0SVX7RPuBg0oh4W0yb7 ruNpsGw1efaC8IOZv/zZjsG+odZmV5qqfWTC4ql2/Er/UraJSmAkvga43/PK4zjlQyXb tSvt3LUqCBpryJG57liUyDuOKaG8D+Uhv3Z6Nr5boOIqM96NRC/3C/HgjXblgkomnHLy hF+R8tXRjk3uMduojw203VtZx7lk9zo3aWz0GTQD4bGV6M44b24akj34EIa2YkRGTg0b iA+7hLoMGQ0bRwqnNF1LuWNInTPRS8bC6D6/oD5brKW73tBJxNGSD64EwCK7tl2JpyG1 BLmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687499125; x=1690091125; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xG7S9EdmjVVI6rCoFSNq3FA5xO2SVwNz93G04XmDDpE=; b=Fx1VuTuA7UbHvJUZgnlHoTeMwnlKzcElAh/QxhLx3BVda2ym/wmaL5KmAxjaAhASAL dhdF4tDe/PONKzRSf76eqE45T7TqcDS0l+R+ElPihzCPK+CwgnqfMGrOz9OcXU6S9k3c S+d5KgeBI8wQIgXfdQJfDoaS4YhJftPTpdDgyXkuW51D6C6iodO2szg7CBYyp13C2uk/ blKhtzsFw1Tu25mwFS/8fiRT1t2t2K4p/ALTRq67tV/aPvuvtF9d72Myam1vIUf2igyJ mbrUKrfKH6qOM1b+GImcWGrO3S/tlIIJmpun77jaGzzRUzqDnaf5nnuJA2fpk7glN9vr eGGw== X-Gm-Message-State: AC+VfDxEnsE0PW66AJHi3A9iWwu8U0+hHEe0BUhl0nKBZQA0IOU3AKUa v7XEcNeGVU5N0qvSl/xdsIBpw1WfrlhN X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:6559:8968:cdfe:35b6]) (user=irogers job=sendgmr) by 2002:a25:ce11:0:b0:bc3:9cd9:6e0e with SMTP id x17-20020a25ce11000000b00bc39cd96e0emr3015289ybe.10.1687499125559; Thu, 22 Jun 2023 22:45:25 -0700 (PDT) Date: Thu, 22 Jun 2023 22:45:17 -0700 Message-Id: <20230623054520.4118442-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.162.gfafddb0af9-goog Subject: [PATCH v3 0/3] Remove symbol_name_rb_node From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Yang Jihong , Carsten Haitzler , Changbin Du , Athira Rajeev , Christophe JAILLET , Jason Wang , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use a sorted array of symbol pointers to avoid the potentially unnecessary 3 pointers (rb_node) for the name sorted symbols. Saves been 24 and 16 bytes per symbol. v3. Move sort by name dso lock into its own patch. v2. map__find_symbol_by_name_idx so that map__find_symbol_by_name doesn't need an optional parameter. Separate out symbol_conf.sort_by_name removal. Ian Rogers (3): perf dso: Sort symbols under lock perf symbol: Remove symbol_name_rb_node perf symbol_conf: Remove now unused sort_by_name tools/perf/builtin-kallsyms.c | 1 - tools/perf/builtin-lock.c | 2 - tools/perf/builtin-report.c | 1 - tools/perf/tests/builtin-test.c | 1 - tools/perf/util/dso.c | 7 +- tools/perf/util/dso.h | 3 +- tools/perf/util/map.c | 14 +++- tools/perf/util/map.h | 12 +-- tools/perf/util/probe-event.c | 16 ++-- tools/perf/util/symbol.c | 131 ++++++++++++++++--------------- tools/perf/util/symbol.h | 12 +-- tools/perf/util/symbol_conf.h | 1 - tools/perf/util/symbol_fprintf.c | 10 +-- 13 files changed, 106 insertions(+), 105 deletions(-) -- 2.41.0.162.gfafddb0af9-goog