Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 09:31:10 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: phy: broadcom: drop brcm_phy_setbits()
 and use phy_set_bits() instead
Message-ID: <ZJVKPuuSikoGGKOm@corigine.com>
References: <ZJRqMLepCTPqvCD9@corigine.com>
 <20230622184721.24368-1-giulio.benetti@benettiengineering.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622184721.24368-1-giulio.benetti@benettiengineering.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FVAecTMojzPrCh2kmFOeC9GobQC3GgUw4Ej1RKIKH+rOTN5YqwqSXCFar4TJ?=
 =?us-ascii?Q?4EnJj4L0M9Y9hfDKPTBvtOHEg46SPmIaYciTQ3Chz5dTywch230qAdrX516/?=
 =?us-ascii?Q?xG0Wby8ZTMMyik6x01qHAMCL9wFjH2v1qkF9Ieed/wF1c6Dr/BHzF2bOvznw?=
 =?us-ascii?Q?sro82tX/IgtnB7zQgRm1ndOqDqEpHCo+NMT8e2dhNjePFmosDh7V0sqisXZB?=
 =?us-ascii?Q?ejoaOdMDy5SF2/4wGP7z+5LfedmOy+LvXKo3P/Ub4TxW2XS/bvtxCHebWlP4?=
 =?us-ascii?Q?igw6d/b4Wv76Ge55FBWj/F7qj2q3tqBXf0XTJY+Zi19ONkWDmqxlk4U0BSxs?=
 =?us-ascii?Q?l+h4ewLYZs0x6xC6C5thYKtZ6FyYhJiI+M6viBbQAXkYHIT6WUA2YK9EnJWE?=
 =?us-ascii?Q?Im3GrLZEKXJg/5ywaNf+cwSCxFZn2aCTwhDcqecD6jlh0lR4IspReY98CwCU?=
 =?us-ascii?Q?Jtj/7KzttPXbsATrzO2ApknSpDg9ndbIWF0/Klj6YRqlwlx4DfrySI4MaQqU?=
 =?us-ascii?Q?UB92sszmKaSyMbZGRLoE3OjENJ1FNVN8ZX/FUDeb7biEX+yX9S/fNbBUZ6wu?=
 =?us-ascii?Q?9zDso6PFnWfNpfXCM1fK9uVcBGRoro8KxOh6Srlnfy4MM5rWEwZubeu7ppkZ?=
 =?us-ascii?Q?DM0k6tKHxCk7stkFnFwKd5wgjAzUgeIbtefKAazqy3GT+0E+CgwUw06Ler1o?=
 =?us-ascii?Q?i75/BDEdizPcqa2cBaLPcSIALYO4VMC7sOBOT2NJtOITsbJe+aqrBDTSh45M?=
 =?us-ascii?Q?fpAH06PmX2PEFQLUWahHjbGEzTVdDokRlt7VwfyQAisjvjca4jwhfks/VdB/?=
 =?us-ascii?Q?HeCj+uUVW4ejue4yTOL4wjbcEsU0iG4v6U7jRrp5fP+1wsk1KaExNdKSGlJc?=
 =?us-ascii?Q?lSHAW24Cr+6D/c30M9Qv63qVtx3+fLWfXHqRznZ7EPOgRCq1Dlkolti5EicM?=
 =?us-ascii?Q?8QSmIC+8Ibb88AaYYMaP8DTYbrEVldIaFKGhw24A+a8lkkNvi6SnE3rHVZtL?=
 =?us-ascii?Q?iroHC4l/U91mYnRtN7/TMmXP4Nh9tr46N2DuML3fryaGHrr3BImBZgWMTOg4?=
 =?us-ascii?Q?wPMBxAyzyd9iFdgt817ptsgSE63N/G+P8bUDs8Na3hTw6tLO3Zg7rp4WFApq?=
 =?us-ascii?Q?pv7iP2pNZ8si0VjYjwnMJoBdA08s02ArBkyy18sGqgJ0AYEfeybi87WwOYUU?=
 =?us-ascii?Q?Kon9RV9RT0ldT314glgBRNvzHkChlxejcv8w90peTb+9ueUA+AvGh+OmS0kn?=
 =?us-ascii?Q?twTlnxMZ/D9YNyS61dO16Go8ifqLoUtTfNEANEm4sjQhgC6ZtTYxl9jUvZSV?=
 =?us-ascii?Q?Ws7EhwqKGGMV6hHwKKY6plOsEwhKVc7FBOsCGwX2E0cvDpsQ8o7CV5tSELYG?=
 =?us-ascii?Q?vadteH4GK6qWHw5L0Vj6TRtmSn9M7AuLE/RnLQDkPySMwBp0j7kFn2ytKhEw?=
 =?us-ascii?Q?ZOcbBI48mG2NFE9R19F/OGxWPeWB9ITFTI21hjHimG7kWeJmzUrnOr7s7Z/b?=
 =?us-ascii?Q?uVJOswl0zRb47UNE80bHFxQyOV1IEWBNe2PUEVa+E/L2XCxAuzGb633MNxsZ?=
 =?us-ascii?Q?RlSY2WO+Ecjj2KHNa0UniSZuUKfMjtk/gbJScRmbrHpBwggRlUDtXiNYu3Qa?=
 =?us-ascii?Q?+fIimWZAGHAVp4gNP8MkYldZFlNxh1FSx9IrpJKmyUM91eK4+IwcELQPtuSu?=
 =?us-ascii?Q?4u6ZeA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4cdbfd77-1a13-40a7-d0f6-08db73bbd4ed
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 07:31:17.2449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sLGwKhouWE32zoPUsU7FNHOid1S7vPzsQvM+OTUa4q5pvHWblIdpe36SVHWLGWLBrxLOKHVy4+3qWXZk8pPJtvX9Fw+M/U5xlwXN91CNgWM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3754
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 22, 2023 at 08:47:21PM +0200, Giulio Benetti wrote:
> Linux provides phy_set_bits() helper so let's drop brcm_phy_setbits() and
> use phy_set_bits() in its place.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * fix code style and add branch net-next to subject as suggested by Simon
>   Horman
> ---
>  drivers/net/phy/broadcom.c | 19 ++++---------------
>  1 file changed, 4 insertions(+), 15 deletions(-)

Reviewed-by: Simon Horman <simon.horman@corigine.com>