Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6f0dfe19-426a-19cd-05f2-7184377b4862@linux.alibaba.com>
Date:   Fri, 23 Jun 2023 16:03:38 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: [PATCH][next] ocfs2: remove redundant assignment to variable
 bit_off
Content-Language: en-US
To:     Colin Ian King <colin.i.king@gmail.com>,
        Mark Fasheh <mark@fasheh.com>,
        Joel Becker <jlbec@evilplan.org>, ocfs2-devel@oss.oracle.com,
        akpm <akpm@linux-foundation.org>
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230622102736.2831126-1-colin.i.king@gmail.com>
From:   Joseph Qi <joseph.qi@linux.alibaba.com>
In-Reply-To: <20230622102736.2831126-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/22/23 6:27 PM, Colin Ian King wrote:
> Variable bit_off is being assigned a value that is never read, it is
> being re-assigned a new value in the following while loop. Remove the
> assignment. Cleans up clang scan build warning:
> 
> fs/ocfs2/localalloc.c:976:18: warning: Although the value stored to
> 'bit_off' is used in the enclosing expression, the value is never
> actually read from 'bit_off' [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/localalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
> index c4426d12a2ad..c803c10dd97e 100644
> --- a/fs/ocfs2/localalloc.c
> +++ b/fs/ocfs2/localalloc.c
> @@ -973,7 +973,7 @@ static int ocfs2_sync_local_to_main(struct ocfs2_super *osb,
>  	la_start_blk = ocfs2_clusters_to_blocks(osb->sb,
>  						le32_to_cpu(la->la_bm_off));
>  	bitmap = la->la_bitmap;
> -	start = count = bit_off = 0;
> +	start = count = 0;
>  	left = le32_to_cpu(alloc->id1.bitmap1.i_total);
>  
>  	while ((bit_off = ocfs2_find_next_zero_bit(bitmap, left, start))