Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:09:09 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Avadhut Naik <avadhut.naik@amd.com>
Cc:     rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, yazen.ghannam@amd.com,
        alexey.kardashevskiy@amd.com, linux-kernel@vger.kernel.org,
        avadnaik@amd.com
Subject: Re: [PATCH v4 3/4] platform/chrome: cros_ec_debugfs: Fix permissions
 for panicinfo
Message-ID: <2023062357-deceased-rejoicing-03d6@gregkh>
References: <20230621035102.13463-1-avadhut.naik@amd.com>
 <20230621035102.13463-4-avadhut.naik@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230621035102.13463-4-avadhut.naik@amd.com>
Precedence: bulk

On Wed, Jun 21, 2023 at 03:51:01AM +0000, Avadhut Naik wrote:
> From: Avadhut Naik <Avadhut.Naik@amd.com>
> 
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
> 
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable.
> 
> As such, rectify the permissions of panicinfo file to ensure it remains
> read-only.
> 
> Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>