Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:09:20 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Avadhut Naik <avadhut.naik@amd.com>
Cc:     rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, yazen.ghannam@amd.com,
        alexey.kardashevskiy@amd.com, linux-kernel@vger.kernel.org,
        avadnaik@amd.com
Subject: Re: [PATCH v4 2/4] fs: debugfs: Add write functionality to debugfs
 blobs
Message-ID: <2023062313-crabgrass-puppet-3528@gregkh>
References: <20230621035102.13463-1-avadhut.naik@amd.com>
 <20230621035102.13463-3-avadhut.naik@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230621035102.13463-3-avadhut.naik@amd.com>
Precedence: bulk

On Wed, Jun 21, 2023 at 03:51:00AM +0000, Avadhut Naik wrote:
> From: Avadhut Naik <Avadhut.Naik@amd.com>
> 
> Currently, debugfs_create_blob() creates read-only debugfs binary blob
> files.
> 
> In some cases, however, userspace tools need to write variable length
> data structures into predetermined memory addresses. An example is when
> injecting Vendor-defined error types through the einj module. In such
> cases, the functionality to write to these blob files in debugfs would
> be desired since the mapping aspect can be handled within the modules
> with userspace tools only needing to write into the blob files.
> 
> Implement a write callback to enable writing to these blob files in
> debugfs.
> 
> Signed-off-by: Avadhut Naik <Avadhut.Naik@amd.com>
> Reviewed-by: Alexey Kardashevskiy <aik@amd.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>