Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8bda5b4b-54ac-0b20-4167-686856347e54@amd.com>
Date:   Fri, 23 Jun 2023 09:48:16 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 0/3] can: xilinx_can: Add ECC feature support
Content-Language: en-US
To:     Marc Kleine-Budde <mkl@pengutronix.de>,
        Srinivas Goud <srinivas.goud@amd.com>
Cc:     wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, gcnu.goud@gmail.com,
        git@amd.com, michal.simek@xilinx.com, linux-can@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <1686570177-2836108-1-git-send-email-srinivas.goud@amd.com>
 <20230616-unneeded-denote-eaa4053514d8-mkl@pengutronix.de>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20230616-unneeded-denote-eaa4053514d8-mkl@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0FmMlVGNDNhZGdsbUVJZTFXeXdSdzJ1M25QSkpuaUI5eFdlRm90NWU4enRm?=
 =?utf-8?B?MHZvM0Ixc0lBeE5jdWw4T1gwR3VKSmRpaXRuYlFNWnFNb3FmaGxXU3o0YVlj?=
 =?utf-8?B?dXQ5LzQxbGZNTTNqS0FVM252WFJDMERZeEpYU1FGUWUvTWt2a2hwZ3FVd0pM?=
 =?utf-8?B?VG10MXFOSWRZUkhDSkhJczd2ZjNmSGZmMy9wZmU2d3VOQ1RwSmdpamJIaStp?=
 =?utf-8?B?YjZwTE84SEJKcEVqNjd5Vjlmakp5OXZiUTV5U1NOYVpDRmJ6Q05BRWhYY3E2?=
 =?utf-8?B?VkxLM1A2RFNObjRWa1RKZFVZNDF5VEs5K0JMS1FpcEd1MnFyemkrNnBpejZy?=
 =?utf-8?B?ZlZ1SDlGV0o1VytqWHU5N1lBU0hmNFI4b1hyUjhUbEkyaFMvSjFWTWd4c1dJ?=
 =?utf-8?B?ZUJQZmdML0tmbHJBRUdqTzRoTzNvR2N6dnJUU09abG1UcHZVWDd2SlduNWlr?=
 =?utf-8?B?aDR1UnpuRU83Qlh3Z2syR0FjUXRQbGlwb3JlcFRja1JvRFBjbkpzT2FhU05Z?=
 =?utf-8?B?ampvejhqVUUrNUV6NWt6YmV1SFQ5NStSZGVMQXVRTGlNRjNSMXRpaDhhWHVS?=
 =?utf-8?B?TThldEFaajFVdDkzZWMxSUhVOElRWnRkY0lUVUpPYitCQnJTYTZoUWZwVUhq?=
 =?utf-8?B?dDdWRHJ3TEJRQ0IxWFV2TzFYeUsxbkRpQzg1cTJzaGxyaDE5UXg5ZEg0M285?=
 =?utf-8?B?VnNiRitrTC9XWE1EY2ZxOFRJQWZVSTFpWi9TaUNUblJDeFd3NzlsTFg1QXRL?=
 =?utf-8?B?S2M1eENJWWcrOTFJcGl6STl2akFIbEpsTUo3NlQrTUR4V1lpcndHV3VjOXlJ?=
 =?utf-8?B?cUkybHVnQ3BrWE9FdCt3aURoQ1ZxeGZPUWxzQjNvRUhGaCsxQWJVQndET3M0?=
 =?utf-8?B?d2dVdUNKR0JZQTVQK2ptTnFIRGs3YktJanFUYnY4Q1VYWFN1OFgrZmZON1lh?=
 =?utf-8?B?RHFYUklSV3plNzJZMU1qYXdqd1U4MTM1Zzk2SDRQbVgxYnFwRi83cStXWTN4?=
 =?utf-8?B?ay9NVytqRVcreGRVakJOczl0K1czd0w1YldvRm92NU1nWWkySURpQTl5M0hX?=
 =?utf-8?B?SmFnZEo0UitVZE40NVRCN3NEdTJJdzgrcTNrSHR5ajZEdE9jc3BHTEI2NzN2?=
 =?utf-8?B?OEMraTdYSms3eW8vVUpOZXlaQUVsNEpqWWVUUnZodEZRN1ZUVVVickdGeXh0?=
 =?utf-8?B?UzlxUDhyRjh0WVhsV09DZ2lKZWtJMjB3RGMrVGdKSXh1RU1uSHUvNU1SY1Fk?=
 =?utf-8?B?SWFQU1EwVmZYWi9xLzVCaWxUS3ljTTU2S0hkeDBlbTBEc3UzOEI4K3p5djg5?=
 =?utf-8?B?TkhRdGxkVzUzcVRPQ1Z2SmY0RHBQa2wvdjVxK29Wc1ZtSW9rU09nTFBkMWZk?=
 =?utf-8?B?Wm9WbklJM2R1aFNSaWFZQ3NIZjEya0V3a1d1c1NqT0xzQnhrQW9DUDNrMVdT?=
 =?utf-8?B?ZlZrMjFvMitYNy9IUzQxejM4akRiNTY0MkNMSDYxUkxObXE5ZS9WNm4vVHZW?=
 =?utf-8?B?aENWY0NkQTE4RXdaKzBVRG54TmFROVMrenBYanJZK2hITjVXY1ZPVXRvSE83?=
 =?utf-8?B?N1NuVjIwY1haUlFBOTBtRGVDZ052VWtOci9jdG4rQ2NlRFNkZnVqeUw0YzVu?=
 =?utf-8?B?S0pTNUo3M0o3aUd1QmExYW4yTTBIV3RuNE14dUxzYlpWellSKzFqRVdWbmtG?=
 =?utf-8?B?bjl1NVdKSDRRY0h6VkRwMUZHSC9KSitTTWw4Y2ZraDZTNTBIbk1qRjljWjNw?=
 =?utf-8?B?dVAwR2tabVJaZlROQkk3Q05rSTEvaHJiMDdxWEt5UDBORUxyQXhaMlJSMUEx?=
 =?utf-8?B?N20rcllPZThEcjZrQXVQV2U0WUR6V25nVVBEbWt5WXJhZGFtZnhBTnljRnVr?=
 =?utf-8?B?Q2h0bFYyYlc2UlRRUkpBUDFBQjVHeFltMm1ObnlqaGVPb2tjTmhKK2tXVHdE?=
 =?utf-8?B?QWRNS1BnbkpMZnZuemJNd3Jrc2FMNk41YlZRWEtIRnVDd2h0dEtBOEl6czBJ?=
 =?utf-8?B?ajFGd1k1bDVZL04wU1FjMktqbUdQVGVITm80SHBMNmVuempjS0NXSWlpM1cz?=
 =?utf-8?B?cnhzVUFBRGg2bVVxWkU1dDlWNWMrSDN0aDZNNVhDMnRVNUYwdU5yN1BwbzdV?=
 =?utf-8?Q?ccd93EhLb9xx6Ou1wz5hh+VAp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 56d17852-6462-4bec-003b-08db73be3d02
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 07:48:30.9121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kfP4yqPXPHJQeDyrFJCRgTAueJbh31iQlx6rgJaGGBmsgjVKDW4q/FmkV31K0jlf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7554
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc,

On 6/16/23 13:12, Marc Kleine-Budde wrote:
> On 12.06.2023 17:12:54, Srinivas Goud wrote:
>> ECC feature added to Tx and Rx FIFO’s for Xilinx CAN Controller.
>> Part of this feature configuration and counter registers added
>> in Xilinx CAN Controller for 1bit/2bit ECC errors count and reset.
>> Please find more details in PG096 v5.1 document.
> 
> The document "PG096 (v5.1) May 16, 2023 CAN v5.1" [1] lists the
> XCAN_ECC_CFG_OFFSET as reserved, although it has a section "ECC
> Configuration Register".
> 
> [1] https://docs.xilinx.com/viewer/book-attachment/Bv6XZP9HRonCGi58fl10dw/ch1ZLpOt4UKWNub7DXjJ7Q
> 
> The other registers (XCAN_TXTLFIFO_ECC_OFFSET, XCAN_TXOLFIFO_ECC_OFFSET,
> XCAN_TXOLFIFO_ECC_OFFSET) are also listed as reserved and not even
> mentioned on the document. Am I missing something?

We cross check available public documentation with HW team and there is no 
public documentation for this feature yet. We didn't get any exact day when 
documentation is going to be released.
Unfortunately it is not the first or even last time when this is happening but I 
still think is good to get this feature done properly till the time when 
documentation catch it up. Please let me know if you have any concern about it.

Thanks,
Michal