Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:22:24 +0200
From:   Wolfram Sang <wsa@kernel.org>
To:     Wang Zhang <silver_code@hust.edu.cn>
Cc:     Peter Korsgaard <peter@korsgaard.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Andreas Larsson <andreas@gaisler.com>,
        hust-os-kernel-patches@googlegroups.com,
        Peter Korsgaard <jacmet@sunsite.dk>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] i2c: ocores: use devm_ managed clks
Message-ID: <ZJVWQIZRb49mhofo@shikoro>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Wang Zhang <silver_code@hust.edu.cn>,
        Peter Korsgaard <peter@korsgaard.com>, Andrew Lunn <andrew@lunn.ch>,
        Andreas Larsson <andreas@gaisler.com>,
        hust-os-kernel-patches@googlegroups.com,
        Peter Korsgaard <jacmet@sunsite.dk>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <b5c00122-0fe0-4020-9036-e4cc37d1b51a@lunn.ch>
 <20230526070534.76112-1-silver_code@hust.edu.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="w5OhO3QWIyoet40D"
Content-Disposition: inline
In-Reply-To: <20230526070534.76112-1-silver_code@hust.edu.cn>
Precedence: bulk


--w5OhO3QWIyoet40D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 26, 2023 at 03:05:33PM +0800, Wang Zhang wrote:
> Smatch complains that:
> drivers/i2c/busses/i2c-ocores.c:704 ocores_i2c_probe()
> warn: missing unwind goto?
>=20
> If any wrong occurs in ocores_i2c_of_probe, the i2c->clk needs to be
> released. But the function returns directly without freeing the clock.
>=20
> Fix this by updating the code to use devm_clk_get_optional_enabled()
> instead. Use dev_err_probe() where appropriate as well since we are
> changing those statements.
>=20
> Fixes: f5f35a92e44a ("i2c: ocores: Add irq support for sparc")
> Signed-off-by: Wang Zhang <silver_code@hust.edu.cn>

Applied to for-next with Andrew's Rev-by from v3 added, thanks!

Please send new versions of a patch as a new mail thread. This makes
handling easier for maintainers.


--w5OhO3QWIyoet40D
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSVVkAACgkQFA3kzBSg
KbbC+w/9F+9+pQmW2yguaFIUfTdzAJfOEQHEIHl+qsoI+GCu8AQ0ikoYk1ynUd5X
YjuEuQfymtEGCfhfGj4iOuxZUtU7Mbw/khJKqWrOKlHHZqnqUBdC5JsP9glEQeAN
H+9KOQGQFjx+0JFvErIEJ1iUjbhb8ONatiDmkmzjL59ZiCJijYF5x75yySlrzW+r
n6yeUVucb/h96P6NYkXeJtgz47gHHXmIWkPHmZAPLezWD6+pkWvZVHsk0kjEsNA4
EIjmX0w+wVuE+4ROctSDPH+TKq4dB66YmAO/xkrl7DsREd55DgDJ1I9PDE+ZAHh6
FbsbIM6Qygwu5Ogy1Z+pSYefe/2IR1P++uLM36r+gXtc/s9VunfzM+dwLChv8Deh
KfbDdgnPuIS0sCvBmHOBQgP4qS0lmq5JCVxqp0SlaQMrVXDc2LEEItVUfLKbt0SO
/t6Kjget1ieel6WT4IqBGruSYqjEwXLY2bxPl2cfi5t65IPtJCAvF08YRr7IcfoF
gVxrcH5t9mFBPiTCmtw/zkXGS1AHFf5dCaxLY6Kx4Lc2g87NGIlwwuuCt1PXdjkk
YwwvJGpy63LLF8H20Fov/g0jSI/FP4knbw3LYUM05A+SDVvTPVMMSP/kLE7gkX3Q
BSUfh7ExD/D3/M9+CMySRVapC+8NlzCkpmaZMd77RM1kQs4UwYo=
=G43Q
-----END PGP SIGNATURE-----

--w5OhO3QWIyoet40D--