Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <963f8bfa-ab05-466e-88b1-e5a17804f10f@redhat.com>
Date:   Fri, 23 Jun 2023 11:05:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] drm/mgag200: set variable mgag200_modeset
 storage-class-specifier to static
Content-Language: en-US
To:     Thomas Zimmermann <tzimmermann@suse.de>, Tom Rix <trix@redhat.com>,
        airlied@redhat.com, airlied@gmail.com, daniel@ffwll.ch
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20230517134140.874179-1-trix@redhat.com>
 <f3d8cbe7-11a6-14a3-e161-906c73c5ade3@suse.de>
From:   Jocelyn Falempe <jfalempe@redhat.com>
In-Reply-To: <f3d8cbe7-11a6-14a3-e161-906c73c5ade3@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23/06/2023 10:28, Thomas Zimmermann wrote:
> 
> 
> Am 17.05.23 um 15:41 schrieb Tom Rix:
>> smatch reports
>> drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol
>>    'mgag200_modeset' was not declared. Should it be static?
>>
>> This variable is only used in its defining file, so it should be static
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
> 
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> 
>> ---
>>   drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c 
>> b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> index 976f0ab2006b..abddf37f0ea1 100644
>> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
>> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
>> @@ -20,7 +20,7 @@
>>   #include "mgag200_drv.h"
>> -int mgag200_modeset = -1;
>> +static int mgag200_modeset = -1;
>>   MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>>   module_param_named(modeset, mgag200_modeset, int, 0400);
> 

applied to drm-misc-next

Thanks for your contribution.

-- 

Jocelyn