Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Lee, Kah Jing" <kah.jing.lee@intel.com>
To:     Conor Dooley <conor@kernel.org>
CC:     Dinh Nguyen <dinguyen@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "Yuslaimi, Alif Zakuan" <alif.zakuan.yuslaimi@intel.com>
Subject: RE: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout for
 UBIFS
Thread-Topic: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layout
 for UBIFS
Thread-Index: AQHZpOcYZtUFqZ6fuE+XlvkVMV11dq+XMvYAgAD3XaA=
Date:   Fri, 23 Jun 2023 10:07:29 +0000
Message-ID: <PH0PR11MB567331CBF3E1FB1315F25A7CCB23A@PH0PR11MB5673.namprd11.prod.outlook.com>
References: <20230622085319.562868-1-kah.jing.lee@intel.com>
 <20230622-campsite-uncloak-37c292c37862@spud>
In-Reply-To: <20230622-campsite-uncloak-37c292c37862@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gi5RvCyXtA6lx/vNGud3ZeChg3fOQPkpv/uogCXqpAXpBrGFhFv8Yq7AkhAV?=
 =?us-ascii?Q?xJWmeQTtdWsq/Y2O2jkHmq+KgeG/xvAB1XT7pZd7L8IJfwkS0G85lKkIqno/?=
 =?us-ascii?Q?421rlWP/P/M79Wz49vvkTH5oI/IKwSAcJtQzQ2EyQ1Ur+zOR6BaXQkhzTcru?=
 =?us-ascii?Q?OfDqSAexsyS9pEubxwrT3PlLiEvJL6xAkk476ixCiGXcOlyS/thsIPcIHoOR?=
 =?us-ascii?Q?dOtA/qE6ht/rch30E8K/r8BNpZhK1KjiMV06waQr5BH3NN1ScwoGhBO+iA3j?=
 =?us-ascii?Q?itre1jJ0A3UUteNjqMxDcv4sPFqZScBCLGVSGvyhHBzFefQRcxf1Fn1Khjwz?=
 =?us-ascii?Q?2MlZnrLe6soeEz5Uf7ECWkPn5+/uEPSC21ZqSaQbA8DoruQZbNu/oHdyb5D5?=
 =?us-ascii?Q?q+35+F92updBh6vhpNsY1qPGtyINlKzadeqarVOwEC4foVyV5uzq6uRVkLDB?=
 =?us-ascii?Q?BgVtxL2xLyn6yCHVIR9JvUtz3Fyr/Ht7tEaKMP8anwXcgyUKHr+uEn5u3ouF?=
 =?us-ascii?Q?Tx7reUrX7n2l/kMhAjpLGeCv2K+Xf06tEVX0oSCWtDd7B96BQnpNN2IkWOSg?=
 =?us-ascii?Q?fXzaBpjtW+gOacWvb/G8yC9X8onPiY2YMeCVnvKQIVTBsft+jhLKTFqibj2y?=
 =?us-ascii?Q?jbfu4uIkWQMXzyQYWnmsx0Ak5jwF5xtP6ThdZYa5YDXrjMkS2BuAwMhYSKhL?=
 =?us-ascii?Q?XhkWA7OEREC+MKjLnZMu7ply+TRYhrvqA1asbofGTrIMTyReYGtJehB7keeA?=
 =?us-ascii?Q?lKEVrLHcgm9qwBb2PXTCiLVL55GN9xcCbT4lZLhqKsuBE13gUzDzmKshORi4?=
 =?us-ascii?Q?BzP9OD2XK/u3Fthw73BtRYyr+KMN6JXUMTRyvMQnw0npWU7AckPlybdbvIiQ?=
 =?us-ascii?Q?FImU+S3culSebp9Gi3B3VrSUU4bCz/zeC14N29vdP3ume6uHReLGYqeWGWBi?=
 =?us-ascii?Q?sNwwb5UPqzNvle0sj5IQrZp1m6u+64C/zJ1yWFXbjNyuGlL6mQFUS6pcYYKY?=
 =?us-ascii?Q?9lLeu199E5BYaTGxAxUgDmV/80EEyOjWXEeJCrPbDfGMRnx2UQpACmWJQNdX?=
 =?us-ascii?Q?uYY/VXVdaWIpzjiyhEkX6jRRbaKuFUDti7CG1kzyYo3ZXUvQ+t23tRk9AqOz?=
 =?us-ascii?Q?HFn1DzSKWaOAFXl1WT4jp95m1rThFGdMxLadysvlQ3PobLCML//rjWKRpkLR?=
 =?us-ascii?Q?lYXpMbfS6Oqrqzq6zF/QxTZKZcV/lZPtY1OE5uGCLxATajS9qOvZylZd2p2E?=
 =?us-ascii?Q?8Lhvfcb6fJEkgfZY5JgCIsnm1xTflue2e5S2j4mK2JTgDd/5BqO9wDj5T+QC?=
 =?us-ascii?Q?foHu9bccRDK9lS3AAMGLGEFIaQWoM4ZNdEGhFqYw6xRajYO4Ewd/gGRis/Ny?=
 =?us-ascii?Q?1rOdiwaoWVa1BaSBlFTvQRblQZaLBcSZm05g8sh/LH3TAFUlmQ2eZDnVcZwi?=
 =?us-ascii?Q?A2gOdom0t+mbyapdYcUdUfytPq2A64+SmEwpDEHdsg+PWoQwA3mAR9mJtbCS?=
 =?us-ascii?Q?ZrCiksUeCVfIxmCMxO1lUHosha3rC5eALQXVOjOxhJ467zXrfLdhzj124q6k?=
 =?us-ascii?Q?z+Yrhcc0bsZKlgmZKCs+VakOCDTGJDpuiDG9ZPQ4?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5673.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc344b0b-4931-4ce0-0e71-08db73d1a720
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2023 10:07:29.1813
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AHXzGwSvbxlNS7639Nrvw8qhlvqyE0JYR8z0HKtZVAhIXxL1rL2C8GLv0nrF1sPBhnEDTIi0ODCmVVwBn1kVcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5963
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, 23 June, 2023 3:19 AM
> To: Lee, Kah Jing <kah.jing.lee@intel.com>
> Cc: Dinh Nguyen <dinguyen@kernel.org>; Rob Herring
> <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Catalin Marinas <catalin.marinas@arm.com>; Will Deacon <will@kernel.org>;
> linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Yuslaimi, Alif
> Zakuan <alif.zakuan.yuslaimi@intel.com>
> Subject: Re: [PATCH 1/2] arch: arm64: boot: dts: Updated QSPI Flash layou=
t
> for UBIFS
>=20
> On Thu, Jun 22, 2023 at 04:53:19PM +0800, kah.jing.lee@intel.com wrote:
> > From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
> >
> > This patch is to update the QSPI flash layout to support UBIFS in mtd
> > root partition.
>=20
> That much is clear from the diff. Surely it'd be better to explain *why* =
this
> change is being made, no?
Updated in v3 - Commit message:
Update the QSPI flash layout to support UBIFS in mtd root partition.
Flash layout is updated in order to store non-UBIFS related boot and fpga d=
ata in
qspi_boot(mtd0) while keep the rootfs with UBIFS in the root partition(mtd1=
).
>=20
> Thanks,
> Conor.
>=20
> >
> > Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
> > Signed-off-by: Kah Jing Lee <kah.jing.lee@intel.com>
> > ---
> >  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
> >  arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts     | 8 ++++----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > index 38ae674f2f02..12b960b9183c 100644
> > --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> > @@ -202,12 +202,12 @@ partitions {
> >
> >  			qspi_boot: partition@0 {
> >  				label =3D "Boot and fpga data";
> > -				reg =3D <0x0 0x03FE0000>;
> > +				reg =3D <0x0 0x04200000>;
> >  			};
> >
> > -			qspi_rootfs: partition@3FE0000 {
> > -				label =3D "Root Filesystem - JFFS2";
> > -				reg =3D <0x03FE0000 0x0C020000>;
> > +			root: partition@4200000 {
> > +				label =3D "Root Filesystem - UBIFS";
> > +				reg =3D <0x04200000 0x0BE00000>;
> >  			};
> >  		};
> >  	};
> > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > index 07c3f8876613..608017e6e36a 100644
> > --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> > @@ -128,12 +128,12 @@ partitions {
> >
> >  			qspi_boot: partition@0 {
> >  				label =3D "Boot and fpga data";
> > -				reg =3D <0x0 0x03FE0000>;
> > +				reg =3D <0x0 0x04200000>;
> >  			};
> >
> > -			qspi_rootfs: partition@3FE0000 {
> > -				label =3D "Root Filesystem - JFFS2";
> > -				reg =3D <0x03FE0000 0x0C020000>;
> > +			root: partition@4200000 {
> > +				label =3D "Root Filesystem - UBIFS";
> > +				reg =3D <0x04200000 0x0BE00000>;
> >  			};
> >  		};
> >  	};
> > --
> > 2.25.1
> >

Thanks.=20

Regards,=20
Lee, Kah Jing