Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexey Romanov <AVRomanov@sberdevices.ru>
To:     Sergey Senozhatsky <senozhatsky@chromium.org>
CC:     Minchan Kim <minchan@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] zsmalloc: do not scan for allocated objects in empty
 zspage
Thread-Topic: [PATCH 1/2] zsmalloc: do not scan for allocated objects in empty
 zspage
Thread-Index: AQHZpYzRyNUr9zsPBkK5T8L0XRRTxK+YA1KA
Date:   Fri, 23 Jun 2023 10:49:07 +0000
Message-ID: <20230623104917.2n6vcxvhvlwmjm2m@cab-wsm-0029881>
References: <20230623044016.366793-1-senozhatsky@chromium.org>
 <20230623044016.366793-2-senozhatsky@chromium.org>
In-Reply-To: <20230623044016.366793-2-senozhatsky@chromium.org>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10E761D8E9F63E41BB49AB9A123FFF8E@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Hello!

On Fri, Jun 23, 2023 at 01:40:01PM +0900, Sergey Senozhatsky wrote:
> zspage migration can terminate as soon as it moves the last
> allocated object from the source zspage.  Add a simple helper
> zspage_empty() that tests zspage ->inuse on each migration
> iteration.
>=20
> Suggested-by: Alexey Romanov <AVRomanov@sberdevices.ru>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> ---
>  mm/zsmalloc.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 3f057970504e..5d60eaedc3b7 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -1147,6 +1147,11 @@ static bool zspage_full(struct size_class *class, =
struct zspage *zspage)
>  	return get_zspage_inuse(zspage) =3D=3D class->objs_per_zspage;
>  }
> =20
> +static bool zspage_empty(struct zspage *zspage)
> +{
> +	return get_zspage_inuse(zspage) =3D=3D 0;
> +}
> +
>  /**
>   * zs_lookup_class_index() - Returns index of the zsmalloc &size_class
>   * that hold objects of the provided size.
> @@ -1625,6 +1630,10 @@ static void migrate_zspage(struct zs_pool *pool, s=
truct size_class *class,
>  		obj_idx++;
>  		record_obj(handle, free_obj);
>  		obj_free(class->size, used_obj);
> +
> +		/* Stop if there are no more objects to migrate */
> +		if (zspage_empty(get_zspage(s_page)))
> +			break;
>  	}
> =20
>  	/* Remember last position in this iteration */
> --=20
> 2.41.0.162.gfafddb0af9-goog
>=20

I think we can add similar check in zs_reclaim_page() function.
There we also scan zspage to find the allocated object.

--=20
Thank you,
Alexey=