Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 08:47:58 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     =?utf-8?Q?C=C3=A9dric?= Le Goater <clegoate@redhat.com>
Cc:     ankita@nvidia.com, alex.williamson@redhat.com, aniketa@nvidia.com,
        cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
        vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
        jhubbard@nvidia.com, danw@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Message-ID: <ZJWGbsaMzHvqqewi@nvidia.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
 <46a79333-12f6-229f-86f9-1e79bdba7d11@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <46a79333-12f6-229f-86f9-1e79bdba7d11@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXB0WEg3NitqS1NDcU1YWHZNOHNHTFlkTlR3amk1NUdjaVhIREE1WVplTEto?=
 =?utf-8?B?NjhpeW1Pa1FDSFR1bHY3S3dMK0VJWHJTaXZob25iVjNWb2xSTFdaNFFPRGRm?=
 =?utf-8?B?YlBrSkNPT214alZ1SWxVOHorci9XY2tvYXk1eUpXUVBDTWhGT1RsL3V1WW00?=
 =?utf-8?B?NXhFemZlRWduUE1IQW1XN3pLc2pBT2ZYRHhCemI4VWJISUNGL0dHakRybGdq?=
 =?utf-8?B?RFIreXY1czE3LytpaGVJSkozZHJYUnJGckdkcUxvaXk1V2o4K3U4cWtpZGhQ?=
 =?utf-8?B?bVA2Unlma0NIVkIxNVl0by81anBPcmx4blovNDZjRElrOGNMWVNTa2tFRlpN?=
 =?utf-8?B?cDZWbzdWNG1YNHhiS1BPbGsvUGVXb0NIQ3RRTklkVENpckVVYkNYL1liY0x6?=
 =?utf-8?B?ZlRqcTR2NlIyb3ZnejZmaTVoOFU2bGJQeFlSYUlYM3lDVERUeExmZ1dJdzhF?=
 =?utf-8?B?QkdjOWdkZHJ1VWc1ZXdUVlZuT1RzbVhOL3RZOUdTZWpPTjN2RUs5OUlNRjZ3?=
 =?utf-8?B?RmJjNll5a2xxbUZoU3d1M0FIZmx1amZHNTlRUnFsMlVSME5RNGMwNkxwbTZ4?=
 =?utf-8?B?VUk0SmtNMVQ3WnJRVXVjZ3Nndjd3L2Jab00wT2IxT2VQNWwraDRzZlo3VzQ4?=
 =?utf-8?B?RmFGeGpRai9nd1k4clhTcEtGODJGUDlZaTk1cnFvczQ0dW94dlZGUThXdXdP?=
 =?utf-8?B?RWVwVjFiZ3pGT3ZpWjR6YjN0RS8rQ3lyVlhiT3QwYmdLQ0Y5aEN1cUtnbjV6?=
 =?utf-8?B?Q0huL1JyVEQ0Y0x3SHlCM1hiemd5cHNjRlhYcUp6NHJaRkRPY0M2cGw5V0tn?=
 =?utf-8?B?R1BOaHFYU1hiUDFaeGdCM0JhMy9UVHhNcjJCNDR0d0tPWTFjcEZ0MFp4TW5l?=
 =?utf-8?B?N0RqQXlhcndNOG1razFpczBDNHJmLzVZUmRyWk42ZERGSmdpdGZENTE4VFFK?=
 =?utf-8?B?QVI1T3l2eTlMeEdwNm1QdjZJdEh4dXJSTEdUMjkvN3VuSVJlRnFyUUtWTUNF?=
 =?utf-8?B?Mkt0VmlNcWhHWlhpakRzak4zcFd5b2xRWktSZzdCZTl0STU2bEJRUjBTTE8w?=
 =?utf-8?B?OWNEZWIwS0IzcmZxK1VmN0RWK3JhOTU4cDdQRFhGc013Z0kvdk52Z2pVcC9W?=
 =?utf-8?B?YW90RlowRmtialBLaGY4elJ1c3ozUDdQK2lqamJDNit2ME5yWkRNMFBvdGJX?=
 =?utf-8?B?Rnp4ZHcrcE5TUDRYQStGR0k5dGVoZVE5NGxGRjFhU2xkRzhDTzlIWGYxYVNh?=
 =?utf-8?B?bDNZRE91N2dGcFphY2pyRVNlaUNPdFdCUVkvb1VydTQ0dWo1N3VyTVdTNnAx?=
 =?utf-8?B?U1RKd2M4d1pETWtRYmVhWWJ1blR3OFN3TFBvbWJIWms2L2lUZTE3VE9yU1Vu?=
 =?utf-8?B?YlZTZ1J1U0ZYaXBiTmFnYWdBdGlUQXhBejdFT2gwVGR4bi9QejcrSHZTVHZx?=
 =?utf-8?B?MDJJTUcxVWJ3UjlONHhhM2ZPR2Rjd3FWMlYrNzNZcnhONWxvY254dXJEdW5m?=
 =?utf-8?B?OUtpSitkT3dTUHhtRnJkUlpUNUs2S2h0emNGNFRPbEhJMlJKNjVlaVNVWm5u?=
 =?utf-8?B?TkRlMjE0V1RMWVg5cnNST01TMm03MUlsU1BiV25xa0NPaXdtN095MkhXVTlP?=
 =?utf-8?B?bWx2MHFuY1RiaWZyVTJwczRzSUg2cUpqTy94RTZucHFGN2VXbllkR1BUMUVP?=
 =?utf-8?B?R2xYNGZQeGdzQTN2Ymp5NTN1bWkweEpsVlI3STl6S3pzKzMzdyszTWJBcHRL?=
 =?utf-8?B?ZW42SDBIaFZzcHpLSWNVRTk5UTByaURXWW0wTXVTMHoyM295dnR5MlgvUVY1?=
 =?utf-8?B?dlFWS2M0Vk9UMVM3dDczVUdzRStkdUFUWmhRejFTRFUyMUV5c1Bjb2EzMW8w?=
 =?utf-8?B?MEx2MTQreERaQi9pTDRCQW9UMnV6NWg3M2lMeEd1TlMyeHM5ajExaE5zUjFU?=
 =?utf-8?B?TVZHazZ2TjgzUTBsT2FYY2EyVWZHOURFcmVTR3F5TTQ3WG5hMmxCWGpiZFps?=
 =?utf-8?B?dDFRMStMeTdkRUdocWt0MVhFOThER2VjSGlYZEVyeTI2WU5Yc1hTeTJPOGNv?=
 =?utf-8?B?ek1jcHg4cVpsVUlRajVFTk9sVlZ3Mk1na2FWZzQ5cElDeTBvbzlNdm8wOWE5?=
 =?utf-8?Q?WazPaw0BsCR2DFRX/fxBZA64K?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5cafa732-9e6d-4ea3-1a62-08db73dfb20c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 11:48:00.6449
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YcSCAD75zXBihjJELshw+qQyCXzVZY79Q8IxW+TquQnbIC6z9Eg64GNuJYtgfFQZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4496
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 08:27:17AM +0200, Cédric Le Goater wrote:
> > +	req_len = vma->vm_end - vma->vm_start;
> > +	pgoff = vma->vm_pgoff &
> > +		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
> > +	if (pgoff >= (nvdev->mem_prop.mem_length >> PAGE_SHIFT))
> > +		return -EINVAL;
> 
> you cound introduce accessor macros for nvdev->mem_prop.mem_length and
> nvdev->mem_prop.hpa

Accessors are not the usual style..

> > +static const struct pci_device_id nvgpu_vfio_pci_table[] = {
> > +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x2342) },
> > +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x2343) },
> > +	{ PCI_DRIVER_OVERRIDE_DEVICE_VFIO(PCI_VENDOR_ID_NVIDIA, 0x2345) },
> 
> It would be good to add definitions for the PCI IDs.

The common form these days is to have a comment with the marketing
name, we stopped putting constants for every device a while ago.

Jason