Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12394727rwd; Fri, 23 Jun 2023 05:41:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5c81aXfiO8QF0Ehr21FGhYm/sO8S3Y8y/v30C0q+MYdEhQkyBJ6ERExQ6ppjxMS/6ZRf91 X-Received: by 2002:a17:90a:690b:b0:25b:f4a5:7510 with SMTP id r11-20020a17090a690b00b0025bf4a57510mr14274977pjj.12.1687524100704; Fri, 23 Jun 2023 05:41:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687524100; cv=none; d=google.com; s=arc-20160816; b=ncpbNVfpPz3HXpFQyNk+yw/lUg9hEWDbpSXh0JbaZGunhCK11G8wVnNdi+5gTVSkZi OG3ufneNxbOMX/q47PE4LIzGM4gd6xzk6jsCVFc9X5qpfaatw2MlHfc0Dgo8RtpCEaCC Akqy9ETMgvna+HNYSd8T5r354CGfbMjmwPueIpM9Dg+MdSmBxITgqkmQDjJSxaTe7Jgo 6sg0J3tsLV0x5LipJL+PkJxc6AYd+qVkihmo7ovaSRV67U+ExHjPotojJS8dB4TxAPAg qwHZ4aWrt6Uh1MhS0/sgstt1BZvLKWQHlNA0JUonc3WtWgead+SlGYGuJoixytbFGVmI 8kdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mDDcJSuZKuAz38uyopXBK/NJraNeeK5LhGpY8lco2Lg=; fh=ygBcwuNa6za8YFPbB+FU2hOpd6l36Fm7a5BRhrrZ5Ug=; b=ShPiXmei+5A95zcuCUxu27T/Np4zUM/te87GyEmH9OL9rFeUQiSXG5BR/JTDmU9SI6 qVo1uRL9c1oFFhiLS9KjSkYMGWIrQo4W0CBiP//vYfVElgAUSQXp4nLHjUo2mxeEitRj 0CHaf5xUbb1gYM+yUwsuZn/Di6P10opRGe0PcLa9BrvLloZtJHgvDG4VV6Dd9NDN4CLB IZxMe47Fr8fLS8zjj9nNzgDWMARhB/GRfVPscTNfAuMSTcppzOPmyaXnsd1aCWlD/lBF 1vTzInOQNlG2jCUdmUaS1tjaAEuNdT6yA2Epmv3/2lVEahbtbCdcML7x1ntVaTeIIZau ixNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sj1Ql0R3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a17090aad4400b0025e0ecee2dfsi1814952pjv.113.2023.06.23.05.41.27; Fri, 23 Jun 2023 05:41:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sj1Ql0R3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbjFWMZ5 (ORCPT + 99 others); Fri, 23 Jun 2023 08:25:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjFWMZ4 (ORCPT ); Fri, 23 Jun 2023 08:25:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2671A1FCE; Fri, 23 Jun 2023 05:25:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A88FF61A38; Fri, 23 Jun 2023 12:25:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5498C433C8; Fri, 23 Jun 2023 12:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687523155; bh=xwSl00aaRAfiJKxykoKczzBMPG2eee6QLKUurUHxVV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sj1Ql0R3SD/pai44v68uY1yoIEcM+LN+oOVC4wkMR9MLmZH5qEsp7c8aYgqAesMHI uppUwkpd/caKvlQD3wsorLrmPKmfVFzrAmgqNRyW95CxYo752T4up40Y93QFv/a6y+ Kc8E935vpOp/PU/0qj2sR+tPaDKTCXqD3tOf4QcdM1QnoX062j7Sw4pklz6rxUGkm9 zDTtSZYwpM0WEuwupwIdKpa7cIv4LkqKuOA2wcsKVArqHb2isX5ya58Vn1mkK/SJ8s eiZog9etZmON+uXR9zqG5pSKY/c0Wkz0B1RcIjCJzZo+GItnck/wgrwTDJhvq9qsV2 NYIr4g1NisWng== Date: Fri, 23 Jun 2023 14:25:50 +0200 From: Christian Brauner To: Sohil Mehta Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] syscalls: Remove file path comments from headers Message-ID: <20230623-kalkulation-bangen-c6d30d1423a5@brauner> References: <20230621223600.1348693-1-sohil.mehta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230621223600.1348693-1-sohil.mehta@intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023 at 10:36:00PM +0000, Sohil Mehta wrote: > Source file locations for syscall definitions can change over a period > of time. File paths in comments get stale and are hard to maintain long > term. Also, their usefulness is questionable since it would be easier to > locate a syscall definition using the SYSCALL_DEFINEx() macro. > > Remove all source file path comments from the syscall headers. Also, > equalize the uneven line spacing (some of which is introduced due to the > deletions). > > Signed-off-by: Sohil Mehta > --- Looks good to me, Reviewed-by: Christian Brauner