Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Fri, 23 Jun 2023 14:38:04 +0200
Message-Id: <CTK1AI4TVYRZ.F77OZB62YYC0@otso>
Cc:     <linux-arm-msm@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] scsi: dt-bindings: ufs: qcom: Fix warning for
 sdm845 by adding reg-names
From:   "Luca Weiss" <luca.weiss@fairphone.com>
To:     "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
        "Abel Vesa" <abel.vesa@linaro.org>,
        "Manivannan Sadhasivam" <mani@kernel.org>,
        "Andy Gross" <agross@kernel.org>,
        "Bjorn Andersson" <andersson@kernel.org>,
        "Konrad Dybcio" <konrad.dybcio@linaro.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        "Conor Dooley" <conor+dt@kernel.org>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "Alim Akhtar" <alim.akhtar@samsung.com>,
        "Avri Altman" <avri.altman@wdc.com>,
        "Bart Van Assche" <bvanassche@acm.org>
References: <20230623113009.2512206-1-abel.vesa@linaro.org>
 <20230623113009.2512206-6-abel.vesa@linaro.org>
 <cd84b8c6-fac7-ecef-26be-792a1b04a102@linaro.org>
In-Reply-To: <cd84b8c6-fac7-ecef-26be-792a1b04a102@linaro.org>
Precedence: bulk

On Fri Jun 23, 2023 at 2:31 PM CEST, Krzysztof Kozlowski wrote:
> On 23/06/2023 13:30, Abel Vesa wrote:
> > There is a warning on dtbs check for sdm845, amongst other platforms,
> > about the reg-names being unevaluated. Fix that by adding reg-names to
> > the clocks and reg properties check for such platforms.
> >=20
> > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Docu=
mentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > index 0209713d1f88..894b57117314 100644
> > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> > @@ -166,6 +166,10 @@ allOf:
> >          reg:
> >            minItems: 2
> >            maxItems: 2
> > +        reg-names:
> > +          items:
> > +            - const: std
> > +            - const: ice
>
> reg-names looks like a new property, so it should be defined in
> top-level and just constrained per-variant.
>
> Also there was similar approach:
> https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-2-dc7a04699579@fai=
rphone.com/
>
> but I guess no resends and it can be superseded.

Right, the patches got reviews but was never applied... I really need to
find a strategy to keep track of sent patches until they're applied with
my work mailbox, it's not the first time that a patch has gotten
forgotten.

With my private mailbox I just have a different folder for patches that
have been sent which I archive once they're applied, but with work GMail
I don't see how I can easily replicate this since it's also not grouping
threads properly.

Also patch 4/5 in this series has an equivalent from me:
https://lore.kernel.org/all/20221209-dt-binding-ufs-v2-3-dc7a04699579@fairp=
hone.com/
^ this might also be preferable since I guess it doesn't break
dt_binding_check?

Regards
Luca

>
> Best regards,
> Krzysztof