Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:07:15 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     =?utf-8?Q?C=C3=A9dric?= Le Goater <clegoate@redhat.com>
Cc:     ankita@nvidia.com, alex.williamson@redhat.com, aniketa@nvidia.com,
        cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
        vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
        jhubbard@nvidia.com, danw@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Message-ID: <ZJWZA8ogUlGegx2C@nvidia.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
 <46a79333-12f6-229f-86f9-1e79bdba7d11@redhat.com>
 <ZJWGbsaMzHvqqewi@nvidia.com>
 <62dcff6b-852d-4a85-dfd4-0ce1f324602e@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <62dcff6b-852d-4a85-dfd4-0ce1f324602e@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3NOSmpjR0k0QjNQK291SEVrMDRMVlBsckEzMTUyVWRmK0p3UU9QWXIwNGo5?=
 =?utf-8?B?MlVWN0xXZmVwMFN1YXpVMC9ZSk1KL1d6ak5HZ2ZqUFoyWVZYM0RwQUxSUkc0?=
 =?utf-8?B?R3lqYm5HSjNXTnBmM0hDOXpyZkVWYjdjSGZaS0tIWXJEYzJhR3VkeXE3S1Nx?=
 =?utf-8?B?YStNWmVJSXRocEc5Z2pZYnVZbm1Dai9Fd1Zvd3pqYTZQSUEveVFaTUdIK0Yv?=
 =?utf-8?B?T2d0UmFHK25kTXh3Tno5MDd4TWttRDF6NWZzQUc1WFFKTHgzSmgvSEZHdTd0?=
 =?utf-8?B?MHZySTgvTWhHV2RRY21CTU1YWkRZVzBlWitHK3pscHJXL3F2TDdMdkZ4NEdT?=
 =?utf-8?B?M1RVTElCOTZIWDhSeGdPUXU4bVdIbTZQWk9hWDN4WndOelJqNlBnTHRzRWxC?=
 =?utf-8?B?VXRUUUpCSlFsRG1OYi9IS1YyY1lEV3BndUozYXJyeHlqblNDUTBSb3lGaTlB?=
 =?utf-8?B?NDRpM2paWkE5bzYrZjFaRmMvcGhaQnhkSDFwKzIzcUNITUFWbkdSczVCTmJH?=
 =?utf-8?B?dWx2TzlQYjlTbkp2V3lDVmxKVit1WFViMWZ1MS9LRmwzeUJORnhGbUMyYjZz?=
 =?utf-8?B?YVVrS1NjTGhNTE9nV1MxajkzOEFVczB1ZDFVT3lIcFhPR0FFaWgxYklNMG5R?=
 =?utf-8?B?RmZFazZZQzdvTE1Vdld0RmRPdTcxSk5HaWNuSm9ObURuNWhrcGtmUFZQRkFV?=
 =?utf-8?B?c0EzZzgxaStySTl5ZHdnZTFndVZ6Z052MHdWcm52d045azUyQTVnVi9iTlpy?=
 =?utf-8?B?WUJ0UHdmUzU1ZFo5eHVFSllTcWt2LzRkNnIvZFNjU1E0clpNNFcxQ09BYmJ4?=
 =?utf-8?B?MUllSmZPVUdFbi8zckpnVnp1M0Y3SlliWTJQeGxzYjh2ZGxjSE94SjNOSFJv?=
 =?utf-8?B?UUdhRjVyZU8ybzhzZXlxT053WllwUnJmUi96WndDcGpBdnlBVzBjZzhkQzVm?=
 =?utf-8?B?bnBPZlNLRU9rVGV6aFpFTkV1bWlRREFpaEZHYUNqMHZ3NzF2MW9EOStFRG0y?=
 =?utf-8?B?ZFlWYkFORXJJZHBNQ3ZjUmwzdE9vTEhBV1FzVDkyRWVUWWJqQWpTUWNmeHVs?=
 =?utf-8?B?d2pLSW9oYU9kbzFlOGZPOW8xYTNFcVMvNlNGaFNSS1lKUUJVY2VJZTFRMG95?=
 =?utf-8?B?WG5iditOSVVlSng0UHNDVURERzhVSVI1TlF4cjE3ZVNya0hpYmU4R0tsQnZE?=
 =?utf-8?B?MVpWd1hnY09lWElCSjg4S1Bid1FIZmEyK2Y1RkpKY3pQRVB4T2Qzc2d2dS9V?=
 =?utf-8?B?WUFDNEFaNHl4VG1lRzd1NHl0VWNTdmZJR2F0a05YdEd4aTNwajkyRVFtRWIv?=
 =?utf-8?B?elBjL3JyOXpVdU8zdWNWWWZ5cVJNVzNvZlNtOVN2TlFVUlcxZlFKRHFDc05l?=
 =?utf-8?B?MFFPcGNuRmZzSnBFMVlCMGpZdzlGNzJpRmp0MWNWQUhOeWk0VE03Vjlwb2px?=
 =?utf-8?B?Y1lOSFlsOWlDZWVIT1lncU9PYi9MdWtKVXU2RHI4Nm9KdnBtOENQT01WT1Z1?=
 =?utf-8?B?Y2lpMjNWSUZ5cEpkZFdPTElranNGWlNtRVFmQytBcG1NcjhNSnEwYytpSUZQ?=
 =?utf-8?B?dG5VbFpVbHRlcGtYcXdJRWYvUzVLV0t2R2pRNTd2OVlvdm1HRE9Vc2J0dVhJ?=
 =?utf-8?B?VG9VWFl6NzNTUFNVSUF0M21NSmpzeTFVUDdFbUI3Y2dBaFZvVzBkWlo2cFRX?=
 =?utf-8?B?WTZidHZMbm8yNDVBWGVyN1o5cVIxclNJbXRnZkJ4Q01wVEpBL2VTdTQvUjNF?=
 =?utf-8?B?Tkd6cTVvYW80REM4TDRmTDA2eFQzV1VRVGNucDgvSWMvME5Fb2RhRkZpd0Yz?=
 =?utf-8?B?SlVrVmlhVlZDQTg5WnZMVk9majdaMEZyaGdGa1Boam5LbW8zU1VwNEJNU0VE?=
 =?utf-8?B?UjhVWExtOUNsVHhabG41QkhMemJEYnpHV2EvVXJTVUl0V3E2ZVc4QlpVckdv?=
 =?utf-8?B?bWtqU0kvTmtSd21JOHE1MmlhMGNqVTNYdVJNbXd4RHpYSmlLNXMrZEVWK0Ja?=
 =?utf-8?B?QXAxSElHbXV4SG1IRHEwVjVPTjluNWFydG11TVpXNlZ4ZFJ4MjVpWGdhMGQ0?=
 =?utf-8?B?bUFOMzBrc3BvV1Uxc1ltVDdHN1RiNU9RdkdxWkhuZnJXM0NjaU5pMzRhajZF?=
 =?utf-8?Q?8ckE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22c1f7a4-c776-4041-c3bd-08db73eac569
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 13:07:17.7740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KdooQB7f7ppTDj6ytcvvUG+dxNBP1bGa5vebNsDxMZSZDqu6y1Om8J1upFWyXgzY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6966
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 03:04:17PM +0200, Cédric Le Goater wrote:
> On 6/23/23 13:47, Jason Gunthorpe wrote:
> > On Fri, Jun 23, 2023 at 08:27:17AM +0200, Cédric Le Goater wrote:
> > > > +	req_len = vma->vm_end - vma->vm_start;
> > > > +	pgoff = vma->vm_pgoff &
> > > > +		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
> > > > +	if (pgoff >= (nvdev->mem_prop.mem_length >> PAGE_SHIFT))
> > > > +		return -EINVAL;
> > > 
> > > you cound introduce accessor macros for nvdev->mem_prop.mem_length and
> > > nvdev->mem_prop.hpa
> > 
> > Accessors are not the usual style..
> 
> I meant something like
> 
>   #define nvgpu_mem_size(nvdev) (nvdev)->mem_prop.mem_length
>   #define nvgpu_mem_pa_base(nvdev) (nvdev)->mem_prop.hpa
> 
> This is minor.

Yeah, this is what I thought you ment, I'm against this kind of
obfuscation in the kernel without a very strong purpose, and if you do
something like this it should be a static inline function.

Jason