Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 23 Jun 2023 10:26:05 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     ankita@nvidia.com
Cc:     alex.williamson@redhat.com, aniketa@nvidia.com, cjia@nvidia.com,
        kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com,
        acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com,
        danw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Message-ID: <ZJWdbbNESp1+6GVN@nvidia.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230622030720.19652-1-ankita@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Qu71bGoB3pn+Fhp9dJYED/zK7bfA1WiWJlfqetxwO8ZPaDOhBdRWxvlf4XVa?=
 =?us-ascii?Q?RKY1aCz9IYcsi+VH5A2jDRFHh8Er83zXUBuUUDMSbRLdDto8L947H96jNmCx?=
 =?us-ascii?Q?8Dk3kFv1wCF5O1U4qcHn2GsPbz28MkjH388Y/PhzKgmL0OfUU8NxsrTK89KF?=
 =?us-ascii?Q?tpcIrTYbOxLNWUt3fioBxKpbZ29Ww7Q8nXtyEOxz96x3zueIq0xeZ2qdlzKc?=
 =?us-ascii?Q?bCFhx4djpFfFTK3vAmYHC+EKyHIwoGE3RDIA9e4PfUvbepZ6VBUNtmTNxdgC?=
 =?us-ascii?Q?TNEmvN4RuCUfORPcunzRW/B+24FjxohAedozUTjwhEaIgOCpf9zPCaeHZYO2?=
 =?us-ascii?Q?hav/WgPv/62Ld/Gd3dYPjLHlCXskVqhVTVKRDPuTok8GULZ8iwT9OYDL0vF5?=
 =?us-ascii?Q?IP8FEzUKOUqYBwFAN2oB/h3A7lV2cfJU0/ku/Jz0woM63DBL0XB3CW4SugkS?=
 =?us-ascii?Q?yTXOIfob/waYzuPPiWn7ZBPcuaj0CTfI4kLj/xqL4gmgJzYDpXQwm44ghP++?=
 =?us-ascii?Q?mYD8c6VZtLer8/u2e5879Ezh9epl39BIOK894N0tm9LLimPoaUwgeaO6rSAG?=
 =?us-ascii?Q?lU2O5P3ItTTwzka/JTBTGDQFbGys8KYcCvicvWJ+ukDATIkgmLJruJtCXifp?=
 =?us-ascii?Q?1/JJB8aSTzEa9PKPsfZWOrNltKyPknovTpjY/rEClWb7I10+nBFFLH+hT8XN?=
 =?us-ascii?Q?hhwI8i/aivfb0LFcFE1cq5nH6Q3p/KcQ3mqQsl081cGWpWasxDoDey7VSPy3?=
 =?us-ascii?Q?5dIRDB9IfuJVThkiWGXXrHabS8nwlkG8JAscnyrBqzbZ8P124lP2qZtlofct?=
 =?us-ascii?Q?hlVxNdeQ4GUHkmrWej7zg2DQVd4OPwDfrD3d7MaJ57FUf0BKskNdibzlmG5d?=
 =?us-ascii?Q?7ZV7bKTyfo6dNixw6RtN9dokgAMQwUEq4qJGTZhbL3Z15MP6AZ+YMOn1j8e/?=
 =?us-ascii?Q?xDbHrJ/VQAgzBlSmqWKyLi7jT3C2QUBe6AWQmSlPR7Shsg3FycaSNs0IMaZY?=
 =?us-ascii?Q?YMgftKr9VcaxW1hUEpMrxwikLdvSifcxwj9lXsNZSn7lN29gdV+XLsH4Kv1n?=
 =?us-ascii?Q?dVC6XKnowr9mUHztqTAybX8iGNZNBDJYN1e7Z2fukZKBRFpydz0p/RguUPii?=
 =?us-ascii?Q?0DcMZy6OJcZ4ZbtPScj1OYoPyBBqEo4J+wOxMlW4k5SBhTG8otWOSTUKp6ck?=
 =?us-ascii?Q?C2K/BZAh4UQPJ0dED5nWB1PAVAyufp9+9bs30a5q5PwJHzV4dnu0xKRZ/t4I?=
 =?us-ascii?Q?TVUnawPloSoZSc9JUOMwPx+jJXHJnQzM+CMDE0BwJUfKAUDmNmsY9hQPr2ch?=
 =?us-ascii?Q?/ZZ6FGU9ShViducDvzNjL53rXiHZI7zhoYGFemecVr4kb+VXmJGKY5jMmI67?=
 =?us-ascii?Q?0GOGimg6xhRUFgvT/+xpdPUZvi5GPZtVxsO1fSuZt0ygn3Ozu39XOMgid/za?=
 =?us-ascii?Q?Kb+JEGoruqYzkdvDzaBRN0EAiC6RrZew+djI24/qm3PIE8y0PLjyArMJZHoO?=
 =?us-ascii?Q?k2oljBG8X63eR0BppR9EqYaPN+dT14Ps007F7MKyCJUWFT+TVnmpaShoDzIL?=
 =?us-ascii?Q?sm5nkp3bbRSuYHxRcEt9QXPY9aPl44GbDDIA49f2?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a24ac50-9f3c-41ed-4f6c-08db73ed671b
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 13:26:07.9042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Btn8GwtvZgDEtY1RQebv0Qal8hEYMDUmO6YzKD0sw/XyH5V+wGDTSObJh6dam7ZE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4861
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 21, 2023 at 08:07:20PM -0700, ankita@nvidia.com wrote:
> +			if (caps.size) {
> +				info.flags |= VFIO_REGION_INFO_FLAG_CAPS;
> +				if (info.argsz < sizeof(info) + caps.size) {
> +					info.argsz = sizeof(info) + caps.size;
> +					info.cap_offset = 0;

Shouldn't this be an error if we can't fit the caps into the response?
Silently discarding the caps seems wrong..

> +static ssize_t nvgpu_vfio_pci_read(struct vfio_device *core_vdev,
> +		char __user *buf, size_t count, loff_t *ppos)
> +{
> +	unsigned int index = VFIO_PCI_OFFSET_TO_INDEX(*ppos);
> +
> +	/*
> +	 * Only the device memory present on the hardware is mapped, which may
> +	 * not be power-of-2 aligned. A read to the BAR2 region implies an
> +	 * access outside the available device memory on the hardware.
> +	 */
> +	if (index == VFIO_PCI_BAR2_REGION_INDEX)
> +		return -EINVAL;

What does the qemu do in this case? Crash the VM?

Jason