Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <66f00ffc-571b-86b3-5c35-b9ce566cc149@microchip.com>
Date:   Fri, 23 Jun 2023 15:16:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: net: macb: sparse warning fixes
Content-Language: en-US
To:     Ben Dooks <ben.dooks@codethink.co.uk>, <netdev@vger.kernel.org>,
        <pabeni@redhat.com>, <kuba@kernel.org>, <edumazet@google.com>,
        <davem@davemloft.net>
CC:     <linux-kernel@vger.kernel.org>, <claudiu.beznea@microchip.com>
References: <20230622130507.606713-1-ben.dooks@codethink.co.uk>
From:   Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
In-Reply-To: <20230622130507.606713-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Ben,

On 22/06/2023 at 15:05, Ben Dooks wrote:
> These are 3 hopefully easy patches for fixing sparse errors due to
> endian-ness warnings. There are still some left, but there are not
> as easy as they mix host and network fields together.
> 
> For example, gem_prog_cmp_regs() has two u32 variables that it does
> bitfield manipulation on for the tcp ports and these are __be16 into
> u32, so not sure how these are meant to be changed. I've also no hardware
> to test on, so even if these did get changed then I can't check if it is
> working pre/post change.

Do you know if there could be any impact on performance (even if limited)?

Best regards,
   Nicolas

> Also gem_writel and gem_writel_n, it is not clear if both of these are
> meant to be host order or not.
> 
> Ben Dooks (3):
>    net: macb: check constant to define and fix __be32 warnings
>    net: macb: add port constant to fix __be16 warnings
>    net: macb: fix __be32 warnings in debug code
> 
>   drivers/net/ethernet/cadence/macb_main.c | 25 +++++++++++++-----------
>   1 file changed, 14 insertions(+), 11 deletions(-)

-- 
Nicolas Ferre