Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   mirimmad@outlook.com
To:     shaggy@kernel.org
Cc:     Immad Mir <mirimmad17@gmail.com>,
        jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] FS: JFS: Check for read-only mounted filesystem in txBegin
Date:   Fri, 23 Jun 2023 19:17:08 +0530
Message-ID: <CY5PR12MB6455588C9343BADC6760A96CC623A@CY5PR12MB6455.namprd12.prod.outlook.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CY5PR12MB6455:EE_|DM8PR12MB5397:EE_
X-MS-Office365-Filtering-Correlation-Id: ea36cdbb-5ca6-4c72-95ca-08db73f0679c
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: WcdoU1Ro+TE4F65zrSa2+SuvNrLwI6XfE6pkRqWm71WNeF19qcdq3oMIb20DxkD2LP9JSwmK+bV+bL4coVC3sUGgE/p3k5E50f+Mvhj/L3eIXL/DG4zupx8EdDEH6f6xg0o3DEDrEpHRDFyL+7w8XlQ0VX9/sAYFI3bEHcGfkcNbF7Uea3w2W3e9V/14ki7lXW7LmrIw9k9vTrzgHE7bm1KXCEHmFkGCgykfju+V3wI4lBKAafMdsJek+/9nQo+H+x6B6swP8zJztSDXgUtMDowChhkjdXXdD2BWkBW8tJpwwNG+o4+FRvzlLUfGX1QqEU72P2HdaWilS7ywKwXVW14R5iHVPLMB442rW0UA4bSz5f12Ie+m3am3ipmWie3AJkgVYqyJ5enAfhQNoWh9DoQW0tieMkj5MeTaFl2NG42Q1dzGMvhN4ETkYL3i/941ZI3rTJMHxWHnm8Zjhv/TkcPIaopopV2UWOOPScE29NbWqXuubnpMBhobca8euZDXpra6fN9zhdbPBe/JWNBJBhyrYOZ8RVb43vD/GxJLkUeKvOI2M3szymvFIJLTta6s
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6IHUYEUK27NYh3SRNUtkASG+8v1FE++s9V2EZ53E1506eJkghsv76OlREzCq?=
 =?us-ascii?Q?IiwP3eTpSe60ICbjs2KRzSjir2kce7PBZUeK3O7sHq5WSD6kuvFOCxVwJeqx?=
 =?us-ascii?Q?fvzpQ1R9mfITcTMP0xmwFt2rYuSyswZOHzlozHwotzdqbcYNDKepuYIgGMH9?=
 =?us-ascii?Q?oQKy3FFSFsPvEiPFDLtqvgtx7lmcfjaEGefc74cGQaiBQRXnC2heTHvH9gJr?=
 =?us-ascii?Q?V39mAuR1ew7mxckJl+IHmiCzauCWMyC9WwvNVrXZiNRE+feZHHvtBj8JpQ3h?=
 =?us-ascii?Q?Z9TLw6IIJmVe0EZD1zGgVUKU1rgIHqQ4ZYS7QSKhSTsjZV8bd3Z+DEwbKoJP?=
 =?us-ascii?Q?Orpvcgsqjv4ltAEr6GpB+HnkZ6PCn3rv7F9ONdNOmb5dlsvXX3AUrEGQA4IQ?=
 =?us-ascii?Q?IdOOzIg/pQ0qddk4+Y3h+mayTKB1LThPatOzhoR2dYZd9SJrQPyCyXg1zUiL?=
 =?us-ascii?Q?ISGxnIFX2AyFQZ2zxRCaauhWhHk3k6Fv6//p5vMsZKY9sRkIAeP1yssPCKBS?=
 =?us-ascii?Q?wbmpfZ6rNhJwWExhR2bVtGcggAm4JBX87KUXeJ4VxC46gtyvELmWUM6UymQA?=
 =?us-ascii?Q?Ih2BaJLH9MRw8ixm7WUTnT39IYVVVXf2g6d/FWep82mkfQIEM76ahoQPoLaj?=
 =?us-ascii?Q?oBEjUdtWPGtk7A4M/BF4sZYSCiWR/odZs7YO0xZ2rxESco2fg+ysO/qefTwX?=
 =?us-ascii?Q?oeIcJvutcT0zZuXxiEJhBVKnY9PfbNey8AfevvxfgnVK3R22eDjwItUBZLsK?=
 =?us-ascii?Q?Z+FT602Hh/VJZSV+VrbElTO5cGT/Uy4QrI3FlJVKRQTzw4rTd9o2tqZSj5mt?=
 =?us-ascii?Q?po7qJED0VvJvbmPT/Qxyau42tIXvoEES6qlqY+xi0Sk2yPA3B9g4SFQl9KjE?=
 =?us-ascii?Q?GVHoSBUxLgO6nWpcyXY4HSPuDKDwN5bdlcyQ7IyfIO76b5opkZ/9mw6ehrAX?=
 =?us-ascii?Q?7iOlIEzLIbpDHdDaqS2a7TqC4IDFr3oV48OOK6LTFcnGfDIWBc4EPh7yHXbe?=
 =?us-ascii?Q?V4dv1NdvPh+dikkPqbcjZ12oA8wXUWJN2jwInBx3kSCgqHCQIosZ/WrQTLCS?=
 =?us-ascii?Q?FMS2gYJrtRxu+HEPOH1DC2dHPfeLVoBDeKoQCkbu8fZ2whgsZAjVs54sh+1X?=
 =?us-ascii?Q?RlNB0ql+mB2MzbTIAwyIjY0oJlcKBIjni/qyV2Y/dvUrKDRARUTkb52kTltr?=
 =?us-ascii?Q?xHjl/PcpfyX53VQzFAhbYdOQAsnwL+6Slu2ZMXZq4GvfvHwj4GZVQTEk0Vb3?=
 =?us-ascii?Q?U+uvgIjYYaEVn0ZKElPa3q6Uz1NkDgC847uF3UX9cA=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea36cdbb-5ca6-4c72-95ca-08db73f0679c
X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6455.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 13:47:37.5418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5397
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Immad Mir <mirimmad17@gmail.com>

 This patch adds a check for read-only mounted filesystem
 in txBegin before starting a transaction potentially saving
 from NULL pointer deref.

Signed-off-by: Immad Mir <mirimmad17@gmail.com>
---
 fs/jfs/jfs_txnmgr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
index ffd4feece..87dc4e3a4 100644
--- a/fs/jfs/jfs_txnmgr.c
+++ b/fs/jfs/jfs_txnmgr.c
@@ -353,7 +353,10 @@ tid_t txBegin(struct super_block *sb, int flag)
 
 	jfs_info("txBegin: flag = 0x%x", flag);
 	log = JFS_SBI(sb)->log;
-
+	if (!log) {
+		jfs_error(sb, "read-only filesystem\n");
+		return 0;
+	}
 	TXN_LOCK();
 
 	INCREMENT(TxStat.txBegin);
-- 
2.40.0