Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12559383rwd; Fri, 23 Jun 2023 07:43:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5B3s8iLkH9FG1DWwZHI8GqsKS04WLhjH+r5oSOZ2nrjUwIBB01eob0Ub6194CCVuANlLMP X-Received: by 2002:a17:902:f90d:b0:1b5:b28:2ff1 with SMTP id kw13-20020a170902f90d00b001b50b282ff1mr30941862plb.10.1687531425707; Fri, 23 Jun 2023 07:43:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687531425; cv=none; d=google.com; s=arc-20160816; b=xc5B+ao3s3CDnKXXC+34QMe/C+3qk6cgoXgleRorB6S/XSWuqA19xYDaZdFU3BEFPv 8koW/0blkeLT1EP5sWC25NIVoWX9ipD6slcTSTRwR3nF3Vwl7DH25gBpmFBDs6JeCGCB LGhTGhZbNIdlD8bMYGyvzfCCvhRSNcOoTY8zCkNps1o3UQgLcvetE4A22GZ5AAw2UTue WqbalxWtLwfMt9IA2NannA++od/hUbUyn1puDSngsyxdGcTU2nFvwly30h7XQkksJw7+ BG8Bap4Ly6mLkkMOO0jB0t8ZWJ0NEXRO7XQM03i5PV3kG41wXzO323JYWjdMsElN/r/E wt1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=zWcAUhlXtASby0c34sxyVURh1GAEvIaJTJuThkR4gkk=; b=uhyFhgOi9xBhOGMpvQEXp3BgPZPNy9Touh1EPLyEfABgQDSh47icSbjH8z3a+ErE1F qxloxG+da5TpkjOMbGkFQsSN/4wPeQhpeFEN9lvZXzQsEIgXdySzDKZerw0WYT7VXYld G8HIqv0GLz5FymYtiVGNhzkZ6+XE0tmE5rJPiux7K8MlRuQovYB2mc0KWSe3JRHr786p PbCxn6JlO1YQFj/Gq3+HXhWd6qEYwvFlewuITQdDGuz85/INuvfo0OJOUxDHSoKgeAmt PmJXAN02t1ckwnop/cqX0bsRVQN79rATb8wZyFC+SMl5blIxKkDbsXqii6bR+YKRPknR LJog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="dr/K+4M8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a170903244800b001a1deff6062si9728108pls.281.2023.06.23.07.43.33; Fri, 23 Jun 2023 07:43:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="dr/K+4M8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232094AbjFWO2h (ORCPT + 99 others); Fri, 23 Jun 2023 10:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbjFWO2f (ORCPT ); Fri, 23 Jun 2023 10:28:35 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ED682697 for ; Fri, 23 Jun 2023 07:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687530511; x=1719066511; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OMKOEe6vxOIvkUlJ4fPr7hFiy8k9LqukaDfPjPUN088=; b=dr/K+4M8Xt+DlJqhZs1VnkX7GZQZe227Fy+BsnUF/XXN2tPuMQf1WYAL 8HAOyS7jtHik+Et7nFQVV6IydaxMU8B6ohU+t08cm6ltMQjtn7+pVJRKv aKDMnQCS1aBuk9OU/9HQsRibMAvavKO5CfSag4NEDncR4VNnkP6nSdObW QzYSmMGJoW/Mut4/0UtzzOqcKvcgV/j+QLI4bFxKfffgC/OKirpcnzOMX Nl4GPwhKdY1+xKB/JX4gRRmO5s+V2uQUG59XUsu0KrpKR7i+s5llCWR+j k1BN781PoZz0jofhwU/yCT5dWchPN4Dq6+aucvN2ettriC5V0jhHtfd0e g==; X-IronPort-AV: E=McAfee;i="6600,9927,10750"; a="358265762" X-IronPort-AV: E=Sophos;i="6.01,152,1684825200"; d="scan'208";a="358265762" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 07:28:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10750"; a="715340305" X-IronPort-AV: E=Sophos;i="6.01,152,1684825200"; d="scan'208";a="715340305" Received: from dankowsk-mobl.ger.corp.intel.com (HELO localhost) ([10.249.147.61]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jun 2023 07:28:29 -0700 From: Iwona Winiarska To: linux-kernel@vger.kernel.org, Greg Kroah-Hartman Cc: Zev Weiss , Iwona Winiarska Subject: [PATCH] peci: Constify struct peci_controller_ops Date: Fri, 23 Jun 2023 16:28:05 +0200 Message-Id: <20230623142805.577612-1-iwona.winiarska@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zev Weiss As with most ops structs, we never modify it at runtime, and keeping function pointers in read-only memory is generally a good thing security-wise. Signed-off-by: Zev Weiss Link: https://lore.kernel.org/r/20230327224315.11135-1-zev@bewilderbeest.net Reviewed-by: Iwona Winiarska Signed-off-by: Iwona Winiarska --- drivers/peci/controller/peci-aspeed.c | 2 +- drivers/peci/core.c | 4 ++-- include/linux/peci.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/peci/controller/peci-aspeed.c b/drivers/peci/controller/peci-aspeed.c index 731c5d8f75c6..7fdc25afcf2f 100644 --- a/drivers/peci/controller/peci-aspeed.c +++ b/drivers/peci/controller/peci-aspeed.c @@ -468,7 +468,7 @@ static void aspeed_peci_property_setup(struct aspeed_peci *priv) ASPEED_PECI_CMD_TIMEOUT_MS_DEFAULT, &priv->cmd_timeout_ms); } -static struct peci_controller_ops aspeed_ops = { +static const struct peci_controller_ops aspeed_ops = { .xfer = aspeed_peci_xfer, }; diff --git a/drivers/peci/core.c b/drivers/peci/core.c index 9c8cf07e51c7..0f83a9c6093b 100644 --- a/drivers/peci/core.c +++ b/drivers/peci/core.c @@ -44,7 +44,7 @@ int peci_controller_scan_devices(struct peci_controller *controller) } static struct peci_controller *peci_controller_alloc(struct device *dev, - struct peci_controller_ops *ops) + const struct peci_controller_ops *ops) { struct peci_controller *controller; int ret; @@ -113,7 +113,7 @@ static void unregister_controller(void *_controller) * Return: Pointer to the newly allocated controller or ERR_PTR() in case of failure. */ struct peci_controller *devm_peci_controller_add(struct device *dev, - struct peci_controller_ops *ops) + const struct peci_controller_ops *ops) { struct peci_controller *controller; int ret; diff --git a/include/linux/peci.h b/include/linux/peci.h index 06e6ef935297..9b3d36aff431 100644 --- a/include/linux/peci.h +++ b/include/linux/peci.h @@ -42,13 +42,13 @@ struct peci_controller_ops { */ struct peci_controller { struct device dev; - struct peci_controller_ops *ops; + const struct peci_controller_ops *ops; struct mutex bus_lock; /* held for the duration of xfer */ u8 id; }; struct peci_controller *devm_peci_controller_add(struct device *parent, - struct peci_controller_ops *ops); + const struct peci_controller_ops *ops); static inline struct peci_controller *to_peci_controller(void *d) { -- 2.40.1