Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12570992rwd; Fri, 23 Jun 2023 07:52:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4N9F/Q5JwPdfMbbwOF3mpGQkEpV0913Yu+6ny1qW4rIRLXh2WqdVoadLAvaRFvoO+/wAha X-Received: by 2002:a05:6358:c624:b0:131:ff5:9160 with SMTP id fd36-20020a056358c62400b001310ff59160mr8360383rwb.1.1687531977443; Fri, 23 Jun 2023 07:52:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687531977; cv=none; d=google.com; s=arc-20160816; b=o7LJcyO/yYHQNz/GcRFSVrl8fJKOTIrK8t+AQ02WW+8LduMW1JjA6lPV9g96pbVXdb eLzg1RCV1p7yERvzc/JwUgiM7zOLRbdNnrUBvMO9zWnCYj3QC0HP+5HBwxMYMn1IYohX sbcJcu4naTJlcRahJqyGvYX0t5ZqyZu+yuwp+JijTs9coPVoF70bEbz3icJx+DhGdUU+ rB7jgIP3NqfsjJZibrUAv8oPCwkcj77dgm3p6mYTX4eauC5Zho8tcMwAnpDID7lMx7sl rSTvAjj+nAPnYgwcxa+U13PF1dVyvfVSO4pD5QZJBUXz3IZdlBKcHIIlf0ekJFAkAXdF AV2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=NxvtIP4itcIMy2xBoREx2ZnCs/7fWvEY+3NnP7o1OdA=; b=RoOLSCnCXD6XEpa3zSYhmZpkF/Jk3MHFpD1AEvKWD9ZjR3gItfgi5Sq6CZJfw4/21v UvyylYE3qV9urAgOSoJi3fu4RzdLtGzeMGPkCYHT2KO36BcDi+c7XLm6HBXUiuHJ4I7j 1BLyTxsH0VTgw/dVcC6t3GGTEVxYkz4r4xskcivQlRCmYfvjG+nPTIz2TnaDi+TEyD/c ZNXEvM78k5aEr9WgIDEoHRTfYEAsD9f5dwFuomgrNxbqNkBVP+FO+4x8P06aan59bHDy K1az3YhyuJfpAG51akvoEe2U5GeAd2nZme3mAZT5v7+z3XST1I3LPqZt41erkMcV/dOz 3HAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=0XkOlQg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020a63b510000000b00543cbd73c02si5086550pge.409.2023.06.23.07.52.45; Fri, 23 Jun 2023 07:52:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=0XkOlQg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232165AbjFWO24 (ORCPT + 99 others); Fri, 23 Jun 2023 10:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbjFWO2z (ORCPT ); Fri, 23 Jun 2023 10:28:55 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10B9E2681 for ; Fri, 23 Jun 2023 07:28:54 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-66872dbc2efso127477b3a.0 for ; Fri, 23 Jun 2023 07:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1687530533; x=1690122533; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NxvtIP4itcIMy2xBoREx2ZnCs/7fWvEY+3NnP7o1OdA=; b=0XkOlQg5GVdfxff7f0/O9y8KglQpCczs3RIHqW0nWmOhMHFKn7xefsYxhI1FLNYkF4 6w+3uWB3LulDMGQbEAC8cMvn1Uc5VMnorOOoPoHqoacZFbEIeWEcPQeKZ0CivfyV313K 8kepEOJo4KxsYf7P79KmuimhS2M+M+HGBJ60vYGROlGUaqhWRHQ5Mrcvoc9mOTmwOShx JLkfzK7y34wIMBPpQeQqeXz49JXFe58IkXXEQKsqSV6QqBgUNWkJwzm/oVm7p4ViSGTz voDlFCQqvPuUSyxpol/bVdtLn1QPeW+KAd8JZoDXfvBmd2TWoyb7riJyMWHojGvqCBoh Gpbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687530533; x=1690122533; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NxvtIP4itcIMy2xBoREx2ZnCs/7fWvEY+3NnP7o1OdA=; b=aW6vF5aTVzvia2YF+dabPWnwMbT4bTLlRpDSFd4pe6gWwVEs+WZwqTYHkZQFjq6khp yI2bcF0ooR0YswxOYssvADYISyhQjiDSyavBFPR8g4L3cevzwUnAV/K2iZ1zh8mQF/hF /5XaHKDjDmwjga4apzKEw0lHKCwbFMS+DBWKug+3smZ9WhFuptatpkt7JGodCbh5xjGy FMhv8AAk/pWi8w6GjE0GdlqH/H8zEFgLrapOlqERpsQf2okYO8nyyMuZcGkeUweK6DdZ 4oPdqGASxS3Yhtm+ydMEKDIKBrid2H+m1a/gHvMrmoQ1CE5+DpZKMjmiTJ5WX1n6YXrz wjrg== X-Gm-Message-State: AC+VfDwpntUFEMhh7OAKZFGw2YJld+qOQQGmscG4pH7IlFE3NNc+yFoE YbQJO/+0q6ugatUb5+teiS9ewQ== X-Received: by 2002:a17:90b:1bc2:b0:25c:1ad3:a4a1 with SMTP id oa2-20020a17090b1bc200b0025c1ad3a4a1mr25609493pjb.1.1687530533347; Fri, 23 Jun 2023 07:28:53 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id v8-20020a17090ad58800b00256a4d59bfasm1566198pju.23.2023.06.23.07.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:28:52 -0700 (PDT) From: Jens Axboe To: hch@lst.de, chaitanyak@nvidia.com, shinichiro.kawasaki@wdc.com, dgilbert@interlog.com, jejb@linux.ibm.com, martin.petersen@oracle.com, yukuai3@huawei.com, Yu Kuai Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com In-Reply-To: <20230621160111.1433521-1-yukuai1@huaweicloud.com> References: <20230621160111.1433521-1-yukuai1@huaweicloud.com> Subject: Re: [PATCH] scsi/sg: don't grab scsi host module reference Message-Id: <168753053177.470264.9198493732249259434.b4-ty@kernel.dk> Date: Fri, 23 Jun 2023 08:28:51 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13-dev-d8b83 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jun 2023 00:01:11 +0800, Yu Kuai wrote: > In order to prevent request_queue to be freed before cleaning up > blktrace debugfs entries, commit db59133e9279 ("scsi: sg: fix blktrace > debugfs entries leakage") use scsi_device_get(), however, > scsi_device_get() will also grab scsi module reference and scsi module > can't be removed. > > It's reported that blktests can't unload scsi_debug after block/001: > > [...] Applied, thanks! [1/1] scsi/sg: don't grab scsi host module reference commit: fcaa174a9c995cf0af3967e55644a1543ea07e36 Best regards, -- Jens Axboe