Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b0f4def-e2bd-b7b2-7c70-1df741780e1c@redhat.com>
Date:   Fri, 23 Jun 2023 17:07:37 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     ankita@nvidia.com, alex.williamson@redhat.com, aniketa@nvidia.com,
        cjia@nvidia.com, kwankhede@nvidia.com, targupta@nvidia.com,
        vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com,
        jhubbard@nvidia.com, danw@nvidia.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230622030720.19652-1-ankita@nvidia.com>
 <46a79333-12f6-229f-86f9-1e79bdba7d11@redhat.com>
 <ZJWGbsaMzHvqqewi@nvidia.com>
 <62dcff6b-852d-4a85-dfd4-0ce1f324602e@redhat.com>
 <ZJWZA8ogUlGegx2C@nvidia.com>
From:   =?UTF-8?Q?C=c3=a9dric_Le_Goater?= <clegoate@redhat.com>
In-Reply-To: <ZJWZA8ogUlGegx2C@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/23/23 15:07, Jason Gunthorpe wrote:
> On Fri, Jun 23, 2023 at 03:04:17PM +0200, Cédric Le Goater wrote:
>> On 6/23/23 13:47, Jason Gunthorpe wrote:
>>> On Fri, Jun 23, 2023 at 08:27:17AM +0200, Cédric Le Goater wrote:
>>>>> +	req_len = vma->vm_end - vma->vm_start;
>>>>> +	pgoff = vma->vm_pgoff &
>>>>> +		((1U << (VFIO_PCI_OFFSET_SHIFT - PAGE_SHIFT)) - 1);
>>>>> +	if (pgoff >= (nvdev->mem_prop.mem_length >> PAGE_SHIFT))
>>>>> +		return -EINVAL;
>>>>
>>>> you cound introduce accessor macros for nvdev->mem_prop.mem_length and
>>>> nvdev->mem_prop.hpa
>>>
>>> Accessors are not the usual style..
>>
>> I meant something like
>>
>>    #define nvgpu_mem_size(nvdev) (nvdev)->mem_prop.mem_length
>>    #define nvgpu_mem_pa_base(nvdev) (nvdev)->mem_prop.hpa
>>
>> This is minor.
> 
> Yeah, this is what I thought you ment, I'm against this kind of
> obfuscation in the kernel without a very strong purpose, and if you do
> something like this it should be a static inline function.

OK. We could drop the intermediate struct attribute instead then.

Thanks,

C.