Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp12660603rwd; Fri, 23 Jun 2023 08:58:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5LuSioqhmb3YlVB7BgdPz91S8E+iDn3yMOb/4RKReXXcwDZxMQQu85EG8UhPcx0E9es5Gi X-Received: by 2002:a17:903:1ca:b0:1af:b678:5168 with SMTP id e10-20020a17090301ca00b001afb6785168mr19961601plh.67.1687535930071; Fri, 23 Jun 2023 08:58:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687535930; cv=none; d=google.com; s=arc-20160816; b=Y2eDgpX0unxQx6kppa6OoRT4d5/2a+BC4v//6UyIEi5oQai5uGXuxq13NmpMvCdoi0 Pt1W1PBMMLXLupzU/Srv7OREzy0CoJo6PjBxmwpQdDopKq8JGT7YgvwX6RMokgc8v51E g7oUjxxy0w3uWv26QwpJm5GIKxIUXaCRQkqUo8UZIhYNh+BEa7UFswr6lT0li0I6vOXR es4VNkyhbbiNurqafT7IuBtB3zl5tBJj60iPeflqm+FWavlAipRnVZhKNF/vq/tBMkJv hJdQ4wnh21FfNTlXYUXRwptra0sKGDXQ9g+YjvqcLErsmzvKlrknv07aYx3AH+ephzT1 gkdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=cWFsvmv9WdGw1xQboLIcsNXZg1hTuOAR04u7VcSH6WE=; b=FusjTPge9FE5NfKsDNbtIUd8NgZyslmjJPcilUSpMHYcM4mnuODWop27Nlb0McAwhM Z9581u7mf3+9XtaSP5MHi0hMu5q9tPWsMf4AmWKhBXKNy8FZCrRMQnjnuQrEPKbJveYX NSSoVYEFBMogSINMWStE1y+j1VAruyqqOR3uAD7a3trTP0KJ8z/JL3Ji7Rqpc8anrI73 QXvTlQcSDyBpKaEonRmcyt5veYQV0KB3MUm8/iXUK7Bn7TQOCC/Ep3ctBM1cMH31HiNo Oe8RiGQEswcj0slzWl0Cvw5MOVitOGD/O5IK2lAeP3i8O+DT3rGam9B4tZ0gF0Mg7YPB ZfXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O5nav8yk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a170903125200b001b212ecbd17si10182578plh.233.2023.06.23.08.58.38; Fri, 23 Jun 2023 08:58:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=O5nav8yk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231744AbjFWPUn (ORCPT + 99 others); Fri, 23 Jun 2023 11:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232741AbjFWPUa (ORCPT ); Fri, 23 Jun 2023 11:20:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0FCBE52; Fri, 23 Jun 2023 08:20:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5344C61A0F; Fri, 23 Jun 2023 15:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C576C433C8; Fri, 23 Jun 2023 15:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687533627; bh=p4YqjWlpHfO8CnjWmeHcdlXPNWLtBviMP1yIdFYTk8o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=O5nav8yk4i7R8Bxuad4YzSjTKcNENCreuMYJUXw2hQcEJi470MFVjfg3oVVw0Qd5B E/h3b5PsjK8WM6ySOa8Pa/un2odzdkXyXWr9Znbl/I3sSWDAAAJC/keOhPJYtwzBl5 AKuzfoXv5jbkrvN+uaNgmcmcq+19En6tzkjgZKhoybY5xwMdSbmVTop5i80SreRUpC Q1vSHPV3uw7a0IWSrRUV8ZHftSVR855VD2CeVckiO2SS5ZSdTNWsfSfJRjepSvACAq 7WGIg1AbbfGUUdY0FSikwshCoGNusmZ0mSTVqRJR2iG9LJJpu+cDnKf8YZGibR42a3 v70BIi37bCZDA== Message-ID: <5c6dc00b-9e25-501f-1497-ce7f67694a0e@kernel.org> Date: Fri, 23 Jun 2023 08:20:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RFC PATCH v2 1/4] net: wire up support for file_operations->uring_cmd() To: Stefan Metzmacher , Breno Leitao , axboe@kernel.dk, asml.silence@gmail.com Cc: io-uring@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Matthieu Baerts , Mat Martineau , Marcelo Ricardo Leitner , Xin Long , leit@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dccp@vger.kernel.org, mptcp@lists.linux.dev, linux-sctp@vger.kernel.org, ast@kernel.org, kuniyu@amazon.com, martin.lau@kernel.org, Jason Xing , Joanne Koong , Greg Kroah-Hartman , "Jason A. Donenfeld" , Willem de Bruijn , Guillaume Nault , Andrea Righi References: <20230614110757.3689731-1-leitao@debian.org> <20230614110757.3689731-2-leitao@debian.org> <6b5e5988-3dc7-f5d6-e447-397696c0d533@kernel.org> Content-Language: en-US From: David Ahern In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/23/23 3:17 AM, Stefan Metzmacher wrote: > > I'd like to keep it passed to socket layer, so that sockets could > implement some extra features in an async fashion. > > What about having the function you posted below (and in v3) > as a default implementation if proto_ops->uring_cmd is NULL? > Nothing about this set needs uring_cmd added to proto ops. It adds uring commands which are wrappers to networking APIs. Let's keep proper APIs between subsystems.